qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Volker Rümelin" <vr_qemu@t-online.de>
To: Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Cc: "John Arbuckle" <programmingkidx@gmail.com>,
	"Howard Spoelstra" <hsp.cat7@gmail.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	QEMU <qemu-devel@nongnu.org>,
	"Zoltán Kővágó" <dirty.ice.hu@gmail.com>
Subject: [PATCH 5/5] audio: fix saturation nonlinearity in clip_* functions
Date: Mon,  2 Mar 2020 20:10:04 +0100	[thread overview]
Message-ID: <20200302191004.5991-5-vr_qemu@t-online.de> (raw)
In-Reply-To: <417bfe2f-e3c1-d83d-b437-47859daf524d@t-online.de>

The current positive limit for the saturation nonlinearity is
only correct if the type of the result has 8 bits or less.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 audio/mixeng_template.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/audio/mixeng_template.h b/audio/mixeng_template.h
index fc8e1d4d9e..bc8509e423 100644
--- a/audio/mixeng_template.h
+++ b/audio/mixeng_template.h
@@ -83,10 +83,9 @@ static inline int64_t glue (conv_, ET) (IN_T v)
 
 static inline IN_T glue (clip_, ET) (int64_t v)
 {
-    if (v >= 0x7f000000) {
+    if (v >= 0x7fffffffLL) {
         return IN_MAX;
-    }
-    else if (v < -2147483648LL) {
+    } else if (v < -2147483648LL) {
         return IN_MIN;
     }
 
-- 
2.16.4



  parent reply	other threads:[~2020-03-02 19:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 19:08 [PATCH 0/5] mostly changes related to audio float samples Volker Rümelin
2020-03-02 19:10 ` [PATCH 1/5] qapi/audio: add documentation for AudioFormat Volker Rümelin
2020-03-03  5:47   ` Markus Armbruster
2020-03-02 19:10 ` [PATCH 2/5] audio: change naming scheme of FLOAT_CONV macros Volker Rümelin
2020-03-02 19:10 ` [PATCH 3/5] audio: consistency changes Volker Rümelin
2020-03-02 19:10 ` [PATCH 4/5] audio: change mixing engine float range to [-1.f, 1.f] Volker Rümelin
2020-03-02 19:10 ` Volker Rümelin [this message]
2020-03-02 23:30 ` [PATCH 0/5] mostly changes related to audio float samples Howard Spoelstra
2020-03-08 19:11   ` Volker Rümelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200302191004.5991-5-vr_qemu@t-online.de \
    --to=vr_qemu@t-online.de \
    --cc=armbru@redhat.com \
    --cc=dirty.ice.hu@gmail.com \
    --cc=eblake@redhat.com \
    --cc=hsp.cat7@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).