qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Joe Richey <joerichey94@gmail.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Stefano Garzarella <sgarzare@redhat.com>,
	Liam Merwick <liam.merwick@oracle.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Cc: Joe Richey <joerichey@google.com>
Subject: [PATCH] optionrom/pvh: scan entire RSDP Area
Date: Tue,  3 Mar 2020 02:52:47 -0800	[thread overview]
Message-ID: <20200303105246.66390-1-joerichey94@gmail.com> (raw)

From: Joe Richey <joerichey@google.com>

Right now the PVH option rom scans for the RSDP from 0xE0000 to
0xE1FFF. This is probobly a typo, it should scan from 0xE0000 to
0xFFFFF.

This is actually an issue on some QEMU versions/machines. For example,
when I run QEMU the RSDP is placed at 0xf5ad0 which will not be picked
up by the current implementation.

This bug still allows a Linux guest to boot (in most configurations) as
the kernel will just scan for the RSDP if one isn't provided.

Signed-off-by: Joe Richey <joerichey@google.com>
---
 pc-bios/optionrom/pvh_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/optionrom/pvh_main.c b/pc-bios/optionrom/pvh_main.c
index a015e1bf22..28e79d7fc4 100644
--- a/pc-bios/optionrom/pvh_main.c
+++ b/pc-bios/optionrom/pvh_main.c
@@ -29,7 +29,7 @@ asm (".code32"); /* this code will be executed in protected mode */
 
 #define RSDP_SIGNATURE          0x2052545020445352LL /* "RSD PTR " */
 #define RSDP_AREA_ADDR          0x000E0000
-#define RSDP_AREA_SIZE          2048
+#define RSDP_AREA_SIZE          0x00020000
 #define EBDA_BASE_ADDR          0x0000040E
 #define EBDA_SIZE               1024
 
-- 
2.25.1



             reply	other threads:[~2020-03-03 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 10:52 Joe Richey [this message]
2020-03-04  8:55 ` [PATCH] optionrom/pvh: scan entire RSDP Area Stefano Garzarella
2020-03-04 12:20   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303105246.66390-1-joerichey94@gmail.com \
    --to=joerichey94@gmail.com \
    --cc=joerichey@google.com \
    --cc=liam.merwick@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).