qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
	"Peter Puhov" <peter.puhov@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Robert Foley" <robert.foley@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH  v2 2/9] tests/vm: Debug mode shows ssh output.
Date: Tue,  3 Mar 2020 15:06:15 +0000	[thread overview]
Message-ID: <20200303150622.20133-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200303150622.20133-1-alex.bennee@linaro.org>

From: Robert Foley <robert.foley@linaro.org>

Add changes to tests/vm/basevm.py so that during debug mode we show ssh output.

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Peter Puhov <peter.puhov@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200219163537.22098-3-robert.foley@linaro.org>
---
 tests/vm/basevm.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 4dee6647e6e..c99725b8c0d 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -120,11 +120,16 @@ class BaseVM(object):
         return fname
 
     def _ssh_do(self, user, cmd, check):
-        ssh_cmd = ["ssh", "-q", "-t",
+        ssh_cmd = ["ssh",
+                   "-t",
                    "-o", "StrictHostKeyChecking=no",
                    "-o", "UserKnownHostsFile=" + os.devnull,
                    "-o", "ConnectTimeout=1",
                    "-p", self.ssh_port, "-i", self._ssh_key_file]
+        # If not in debug mode, set ssh to quiet mode to
+        # avoid printing the results of commands.
+        if not self.debug:
+            ssh_cmd.append("-q")
         for var in self.envvars:
             ssh_cmd += ['-o', "SendEnv=%s" % var ]
         assert not isinstance(cmd, str)
-- 
2.20.1



  parent reply	other threads:[~2020-03-03 15:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 15:06 [PATCH v2 0/9] testing/next (buildvm and re-greening tweeks) Alex Bennée
2020-03-03 15:06 ` [PATCH v2 1/9] tests/vm: use $(PYTHON) consistently Alex Bennée
2020-03-03 15:06 ` Alex Bennée [this message]
2020-03-03 15:06 ` [PATCH v2 3/9] tests/vm: increased max timeout for vm boot Alex Bennée
2020-03-03 15:06 ` [PATCH v2 4/9] tests/vm: give wait_ssh() option to wait for root Alex Bennée
2020-03-03 15:06 ` [PATCH v2 5/9] tests/vm: Added gen_cloud_init_iso() to basevm.py Alex Bennée
2020-03-03 15:06 ` [PATCH v2 6/9] travis: enable tools build on OS X Alex Bennée
2020-03-03 15:06 ` [PATCH v2 7/9] configure: detect and report genisoimage Alex Bennée
2020-03-03 18:44   ` Richard Henderson
2020-03-03 15:06 ` [PATCH v2 8/9] tests/acceptance: bump avocado requirements to 76.0 Alex Bennée
2020-03-03 18:45   ` Richard Henderson
2020-03-03 15:06 ` [PATCH v2 9/9] travis.yml: install python3 numpy and opencv libraries Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303150622.20133-3-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=peter.puhov@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.foley@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).