From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, berrange@redhat.com, mdroth@linux.vnet.ibm.com
Subject: [PATCH v2 10/30] tests/test-qmp-event: Check event is actually emitted
Date: Tue, 3 Mar 2020 17:34:45 +0100 [thread overview]
Message-ID: <20200303163505.32041-11-armbru@redhat.com> (raw)
In-Reply-To: <20200303163505.32041-1-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/test-qmp-event.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c
index d64066139c..7dd0053190 100644
--- a/tests/test-qmp-event.c
+++ b/tests/test-qmp-event.c
@@ -26,6 +26,7 @@
typedef struct TestEventData {
QDict *expect;
+ bool emitted;
} TestEventData;
TestEventData *test_event_data;
@@ -52,7 +53,7 @@ void test_qapi_event_emit(test_QAPIEvent event, QDict *d)
qdict_del(d, "timestamp");
g_assert(qobject_is_equal(QOBJECT(d), QOBJECT(test_event_data->expect)));
-
+ test_event_data->emitted = true;
}
static void event_prepare(TestEventData *data,
@@ -87,6 +88,7 @@ static void test_event_a(TestEventData *data,
{
data->expect = qdict_from_jsonf_nofail("{ 'event': 'EVENT_A' }");
qapi_event_send_event_a();
+ g_assert(data->emitted);
qobject_unref(data->expect);
}
@@ -95,6 +97,7 @@ static void test_event_b(TestEventData *data,
{
data->expect = qdict_from_jsonf_nofail("{ 'event': 'EVENT_B' }");
qapi_event_send_event_b();
+ g_assert(data->emitted);
qobject_unref(data->expect);
}
@@ -107,6 +110,7 @@ static void test_event_c(TestEventData *data,
"{ 'event': 'EVENT_C', 'data': {"
" 'a': 1, 'b': { 'integer': 2, 'string': 'test1' }, 'c': 'test2' } }");
qapi_event_send_event_c(true, 1, true, &b, "test2");
+ g_assert(data->emitted);
qobject_unref(data->expect);
}
@@ -132,6 +136,7 @@ static void test_event_d(TestEventData *data,
" 'string': 'test2', 'enum2': 'value2' },"
" 'b': 'test3', 'enum3': 'value3' } }");
qapi_event_send_event_d(&a, "test3", false, NULL, true, ENUM_ONE_VALUE3);
+ g_assert(data->emitted);
qobject_unref(data->expect);
}
--
2.21.1
next prev parent reply other threads:[~2020-03-03 16:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 16:34 [PATCH v2 00/30] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 01/30] qemu-doc: Belatedly document QMP command arg & result deprecation Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 02/30] qapi: Belatedly update doc comment for @wait deprecation Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 03/30] docs/devel/qapi-code-gen: Clarify allow-oob introspection Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 04/30] docs/devel/qapi-code-gen: Document 'features' introspection Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 05/30] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 06/30] tests/test-qmp-cmds: Check responses more thoroughly Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 07/30] tests/test-qmp-cmds: Simplify test data setup Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 08/30] tests/test-qmp-event: " Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 09/30] tests/test-qmp-event: Use qobject_is_equal() Markus Armbruster
2020-03-03 16:34 ` Markus Armbruster [this message]
2020-03-03 16:34 ` [PATCH v2 11/30] qapi/schema: Clean up around QAPISchemaEntity.connect_doc() Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 12/30] qapi: Add feature flags to remaining definitions Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 13/30] qapi: Consistently put @features parameter right after @ifcond Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 14/30] qapi/introspect: Rename *qlit* to reduce confusion Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 15/30] qapi/introspect: Factor out _make_tree() Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 16/30] qapi/schema: Change _make_features() to a take feature list Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 17/30] qapi/schema: Reorder classes so related ones are together Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 18/30] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants} Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 19/30] qapi/schema: Call QAPIDoc.connect_member() in just one place Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 20/30] qapi: Add feature flags to struct members Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 21/30] qapi: Inline do_qmp_dispatch() into qmp_dispatch() Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 22/30] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 23/30] qapi: Simplify how qmp_dispatch() gets the request ID Markus Armbruster
2020-03-03 16:34 ` [PATCH v2 24/30] qapi: Replace qmp_dispatch()'s TODO comment by an explanation Markus Armbruster
2020-03-03 16:35 ` [PATCH v2 25/30] qapi: New special feature flag "deprecated" Markus Armbruster
2020-03-03 16:35 ` [PATCH v2 26/30] qapi: Mark deprecated QMP parts with feature 'deprecated' Markus Armbruster
2020-03-03 16:35 ` [PATCH v2 27/30] qemu-options: New -compat to set policy for deprecated interfaces Markus Armbruster
2020-03-03 16:35 ` [PATCH v2 28/30] qapi: Implement -compat deprecated-output=hide Markus Armbruster
2020-03-03 16:35 ` [PATCH v2 29/30] qapi: Implement -compat deprecated-input=reject Markus Armbruster
2020-03-03 16:35 ` [PATCH v2 30/30] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-03-03 17:21 ` [PATCH v2 00/30] Configurable policy for handling deprecated interfaces Peter Maydell
2020-03-04 8:18 ` Markus Armbruster
2020-03-04 9:01 ` Peter Maydell
2020-03-04 9:27 ` Markus Armbruster
2020-03-04 11:55 ` Peter Krempa
2020-03-04 13:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303163505.32041-11-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).