From: "Ján Tomko" <jtomko@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
qemu-stable@nongnu.org, mreitz@redhat.com,
dplotnikov@virtuozzo.com
Subject: Re: [PATCH] block/qcow2-threads: fix qcow2_decompress
Date: Wed, 4 Mar 2020 15:24:47 +0100 [thread overview]
Message-ID: <20200304142447.GD3045166@lpt> (raw)
In-Reply-To: <20200302150930.16218-1-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On a Monday in 2020, Vladimir Sementsov-Ogievskiy wrote:
>On success path we return what inflate() returns instead of 0. And it
>most probably works for Z_STREAM_END as it is positive, but is
>definitely broken for Z_BUF_ERROR.
>
>While being here, switch to errno return code, to be closer to
>qcow2_compress API (and usual expectations).
>
>Revert condition in if to be more positive. Drop dead initialization of
>ret.
>
>Cc: qemu-stable@nongnu.org # v4.0
>Fixes: 341926ab83e2b
>Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>---
>
>Hi!
>
>Reviewing Den's series about zstd in qcow2 support, I found an existing
>bug. Let's fix it. This is to be a new base of zstd series.
>
> block/qcow2-threads.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-04 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 15:09 [PATCH] block/qcow2-threads: fix qcow2_decompress Vladimir Sementsov-Ogievskiy
2020-03-02 17:04 ` Alberto Garcia
2020-03-04 14:24 ` Ján Tomko [this message]
2020-03-09 18:41 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304142447.GD3045166@lpt \
--to=jtomko@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).