* [PATCH] configure: Fix pkg_config --exists parameter
@ 2020-03-04 17:41 Liran Alon
2020-03-04 17:42 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Liran Alon @ 2020-03-04 17:41 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Bhavesh Davda, Liran Alon, dgilbert, quintela
pkg_config parameter should be "--exists", not "--exist".
This is probably a typo.
Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd")
Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 50c4d96e2a8c..280f3654f786 100755
--- a/configure
+++ b/configure
@@ -2464,7 +2464,7 @@ fi
# zstd check
if test "$zstd" != "no" ; then
- if $pkg_config --exist libzstd ; then
+ if $pkg_config --exists libzstd ; then
zstd_cflags="$($pkg_config --cflags libzstd)"
zstd_libs="$($pkg_config --libs libzstd)"
LIBS="$zstd_libs $LIBS"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Fix pkg_config --exists parameter
2020-03-04 17:41 [PATCH] configure: Fix pkg_config --exists parameter Liran Alon
@ 2020-03-04 17:42 ` Dr. David Alan Gilbert
2020-03-04 19:05 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-04 17:42 UTC (permalink / raw)
To: Liran Alon; +Cc: pbonzini, Bhavesh Davda, qemu-devel, quintela
* Liran Alon (liran.alon@oracle.com) wrote:
> pkg_config parameter should be "--exists", not "--exist".
> This is probably a typo.
>
> Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd")
> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
That's the same as 20200303124925.28079-1-dplotnikov@virtuozzo.com from
Denis yesterday.
Dave
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 50c4d96e2a8c..280f3654f786 100755
> --- a/configure
> +++ b/configure
> @@ -2464,7 +2464,7 @@ fi
> # zstd check
>
> if test "$zstd" != "no" ; then
> - if $pkg_config --exist libzstd ; then
> + if $pkg_config --exists libzstd ; then
> zstd_cflags="$($pkg_config --cflags libzstd)"
> zstd_libs="$($pkg_config --libs libzstd)"
> LIBS="$zstd_libs $LIBS"
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Fix pkg_config --exists parameter
2020-03-04 17:42 ` Dr. David Alan Gilbert
@ 2020-03-04 19:05 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-04 19:05 UTC (permalink / raw)
To: Dr. David Alan Gilbert, Liran Alon
Cc: pbonzini, Bhavesh Davda, qemu-devel, quintela
On 3/4/20 6:42 PM, Dr. David Alan Gilbert wrote:
> * Liran Alon (liran.alon@oracle.com) wrote:
>> pkg_config parameter should be "--exists", not "--exist".
>> This is probably a typo.
>>
>> Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd")
>> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
>> Signed-off-by: Liran Alon <liran.alon@oracle.com>
>
> That's the same as 20200303124925.28079-1-dplotnikov@virtuozzo.com from
> Denis yesterday.
And Alex 2 days ago:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html
>
> Dave
>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 50c4d96e2a8c..280f3654f786 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2464,7 +2464,7 @@ fi
>> # zstd check
>>
>> if test "$zstd" != "no" ; then
>> - if $pkg_config --exist libzstd ; then
>> + if $pkg_config --exists libzstd ; then
>> zstd_cflags="$($pkg_config --cflags libzstd)"
>> zstd_libs="$($pkg_config --libs libzstd)"
>> LIBS="$zstd_libs $LIBS"
>> --
>> 2.20.1
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-04 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-04 17:41 [PATCH] configure: Fix pkg_config --exists parameter Liran Alon
2020-03-04 17:42 ` Dr. David Alan Gilbert
2020-03-04 19:05 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).