From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62E9C3F2CE for ; Thu, 5 Mar 2020 00:12:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 701BF20842 for ; Thu, 5 Mar 2020 00:12:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yt3KdMBl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 701BF20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9e8H-0006yV-KU for qemu-devel@archiver.kernel.org; Wed, 04 Mar 2020 19:12:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57332) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9e6w-0005HA-Ix for qemu-devel@nongnu.org; Wed, 04 Mar 2020 19:11:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9e6v-0003mb-6A for qemu-devel@nongnu.org; Wed, 04 Mar 2020 19:11:34 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33179 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9e6u-0003iR-S6 for qemu-devel@nongnu.org; Wed, 04 Mar 2020 19:11:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583367092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mHzwVPuv77fgWBY71V72hhks/WbfScD9P0tgU3xjl8Y=; b=Yt3KdMBlnOUN/7lVKQg7/yleJSCbtcsD9IkB9fgtv1gT5y2nuRrB7AzWfsVJnZ3yG4DiAU Y5GwtGkl1xGxW88Owtm0id6lmX+s6q9EcOqTvy23AJFHCrrtsnh+ue7dYOlypE5j02Q+Ms iSU4ei0nam2FjuFwnWz5gh1p5ErAwt8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-GKVxr4XmOHixX_KHYvDwqA-1; Wed, 04 Mar 2020 19:11:28 -0500 X-MC-Unique: GKVxr4XmOHixX_KHYvDwqA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A46613E2; Thu, 5 Mar 2020 00:11:27 +0000 (UTC) Received: from probe.redhat.com (ovpn-120-212.rdu2.redhat.com [10.10.120.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60C2C5C1D4; Thu, 5 Mar 2020 00:11:26 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 0/3] iotests: add JobRunner framework Date: Wed, 4 Mar 2020 19:11:22 -0500 Message-Id: <20200305001125.27549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-block@nongnu.org, Max Reitz , Cleber Rosa , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Requires: 20200304213818.15341-1-jsnow@redhat.com (This requires the iotests pylint & logging series.) The basic idea is to make a generic job runtime manager and allow callers to subclass the manager. Then, instead of adding callback arguments to the function all the time, we have =C3=A0 la carte customizati= on of the loop. To showcase this a little bit, I removed the pre_finalization argument and made existing callers use a custom JobRunner; and then converted test 040 to use this style of job runner. Is it a simplification? No. Is it cool? Maybe. Did it remove the duplicated job-running code in 040? yes. V2: - Rebased on logging series; logging conditionals are pretty now. - Inlined callback login in 257 - No longer based on bitmap-populate job (no test 287) - Moved super() call to the beginning of test 040's callback - Added docstrings and type annotations John Snow (3): qmp.py: change event_wait to use a dict iotests: add JobRunner class iotests: modify test 040 to use JobRunner python/qemu/machine.py | 10 +- tests/qemu-iotests/040 | 51 +++++---- tests/qemu-iotests/255 | 9 +- tests/qemu-iotests/257 | 54 +++++---- tests/qemu-iotests/260 | 5 +- tests/qemu-iotests/iotests.py | 201 +++++++++++++++++++++++++--------- tests/qemu-iotests/pylintrc | 11 ++ 7 files changed, 233 insertions(+), 108 deletions(-) --=20 2.21.1