From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E09C3F2D1 for ; Thu, 5 Mar 2020 01:44:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D18220828 for ; Thu, 5 Mar 2020 01:44:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="X5UgwqxO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D18220828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9fZ7-0002Ms-6j for qemu-devel@archiver.kernel.org; Wed, 04 Mar 2020 20:44:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45873) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9fXz-0000NE-Iw for qemu-devel@nongnu.org; Wed, 04 Mar 2020 20:43:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9fXy-0006nw-DX for qemu-devel@nongnu.org; Wed, 04 Mar 2020 20:43:35 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:56301) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9fXx-0006k6-Cp; Wed, 04 Mar 2020 20:43:34 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 48XtnF3cb8z9sSJ; Thu, 5 Mar 2020 12:43:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1583372609; bh=Mpc/hupVpEIkY3C7UyiGMaWr+/4ielmmbo075mwyL+c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X5UgwqxOqkKlPhUZfeMFH0tW5bYEvqZBjrTnAjuz6jsMhEi9z6r1YasSNFCPjup4a /du8tj3q2420HvZ4c+m888xQ0Z9AOFYqxdiuT6cxJwG24Ip893wPWFQpIJTUSp/1J8 of72lStA9sM3GiitA8ecDZDVgfIe4Hs0ikPPUXX8= Date: Thu, 5 Mar 2020 11:40:12 +1100 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 3/5] hw/scsi/spapr_vscsi: Simplify a bit Message-ID: <20200305004012.GI593957@umbus.fritz.box> References: <20200304153311.22959-1-philmd@redhat.com> <20200304153311.22959-4-philmd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+QwZB9vYiNIzNXIj" Content-Disposition: inline In-Reply-To: <20200304153311.22959-4-philmd@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --+QwZB9vYiNIzNXIj Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 04, 2020 at 04:33:09PM +0100, Philippe Mathieu-Daud=E9 wrote: > We already have a ui pointer, use it (to simplify the next commit). >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 Applied to ppc-for-5.0. > --- > hw/scsi/spapr_vscsi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > index 7e397ed797..3cb5a38181 100644 > --- a/hw/scsi/spapr_vscsi.c > +++ b/hw/scsi/spapr_vscsi.c > @@ -261,9 +261,9 @@ static int vscsi_send_rsp(VSCSIState *s, vscsi_req *r= eq, > if (status) { > iu->srp.rsp.sol_not =3D (sol_not & 0x04) >> 2; > if (req->senselen) { > - req->iu.srp.rsp.flags |=3D SRP_RSP_FLAG_SNSVALID; > - req->iu.srp.rsp.sense_data_len =3D cpu_to_be32(req->senselen= ); > - memcpy(req->iu.srp.rsp.data, req->sense, req->senselen); > + iu->srp.rsp.flags |=3D SRP_RSP_FLAG_SNSVALID; > + iu->srp.rsp.sense_data_len =3D cpu_to_be32(req->senselen); > + memcpy(iu->srp.rsp.data, req->sense, req->senselen); > total_len +=3D req->senselen; > } > } else { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --+QwZB9vYiNIzNXIj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl5gSmwACgkQbDjKyiDZ s5IdbQ/+L+SCW55mztzOoUaxPqSTUQ8jTRkYuLnm97IO+N/f9vIYba7fE34IF+56 TMf8JnAWI9I/V3y8ONhIC0lhMv17epaUOOmeN+XiRtV5KYXI2rEbRSmEmt+wN42P wn69PLT6kqknjOQ3gL/D4nhRnCL2trnjAJd6J/eGpT7YHI+H9F5HxlrtJJ40ieiw fG3qmNbgwFppfowhA24KEOWgVrr+c3pJwQDorvvIAfQrXevOcyomLLaVSNVrf9pO eM/GSfrkv3IGWwsjK+n3ZQovDLFisuvTXGijMrcOlcyM2fXFLRBYRWGKEAlvqLZb mYZUiNNS/QxSYg9HT6ws3Y6kgeelFyMUpL4cfS1we/EXUN6IVFoJD/oC2YIkB1dU Yo9ykVrqIfSm4+t7TfzLNmxlNyiFVo6NFlRloGeRVY0UIvbroMPJsoixREbgtKre YGHGmyfM8SfC+950PdSvv4zZxSXGkhx59wEgTp8cy8atNB3oZJelcOVR45BJZDCD 8SXg0w+bFzPvPTe/h/Iv+25d1qGr/MVjRg1hZY83hx8hYA1C80m8u+jId7MmUDom UiGI1tQbvIWXFJ9n1GynIzKtKpAodF/TteitsmHcKsLkvguMZiSUIMGazTbnUS1I doVUVfMXP5QlkIMBvOC/bpMOkbP1Zy2dAv//armHY7Yu30k2VMY= =k0Ho -----END PGP SIGNATURE----- --+QwZB9vYiNIzNXIj--