From: Greg Kurz <groug@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Dmitry Fleytman <dmitry.fleytman@gmail.com>,
qemu-trivial@nongnu.org, Jason Wang <jasowang@redhat.com>,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] virtfs-proxy-helper: Make the helper_opts[] array const
Date: Thu, 5 Mar 2020 11:10:15 +0100 [thread overview]
Message-ID: <20200305111015.10ad9479@bahia.home> (raw)
In-Reply-To: <20200305010446.17029-4-philmd@redhat.com>
On Thu, 5 Mar 2020 02:04:46 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Reduce a bit the memory footprint by making the helper_opts[]
> array const.
>
... and, maybe most importantly, make it clear helper_opts[] is
not supposed to be modified at runtime.
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
Assuming this goes to the trivial tree:
Acked-by: Greg Kurz <groug@kaod.org>
> fsdev/virtfs-proxy-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index aa1ab2590d..de061a8a0e 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -43,7 +43,7 @@
> #define BTRFS_SUPER_MAGIC 0x9123683E
> #endif
>
> -static struct option helper_opts[] = {
> +static const struct option helper_opts[] = {
> {"fd", required_argument, NULL, 'f'},
> {"path", required_argument, NULL, 'p'},
> {"nodaemon", no_argument, NULL, 'n'},
next prev parent reply other threads:[~2020-03-05 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 1:04 [PATCH 0/3] hw/net,virtfs-proxy-helper: Reduce .data footprint Philippe Mathieu-Daudé
2020-03-05 1:04 ` [PATCH 1/3] hw/net/e1000: Add readops/writeops typedefs Philippe Mathieu-Daudé
2020-03-05 9:16 ` Dmitry Fleytman
2020-03-05 1:04 ` [PATCH 2/3] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data Philippe Mathieu-Daudé
2020-03-05 9:16 ` Dmitry Fleytman
2020-03-05 1:04 ` [PATCH 3/3] virtfs-proxy-helper: Make the helper_opts[] array const Philippe Mathieu-Daudé
2020-03-05 10:10 ` Greg Kurz [this message]
2020-03-05 9:53 ` [PATCH 0/3] hw/net,virtfs-proxy-helper: Reduce .data footprint Stefano Garzarella
2020-03-05 10:37 ` Philippe Mathieu-Daudé
2020-03-05 10:41 ` Stefano Garzarella
2020-03-06 9:25 ` Paolo Bonzini
2020-03-09 11:44 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305111015.10ad9479@bahia.home \
--to=groug@kaod.org \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).