From: Greg Kurz <groug@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 3/5] hw/scsi/spapr_vscsi: Simplify a bit
Date: Thu, 5 Mar 2020 11:21:46 +0100 [thread overview]
Message-ID: <20200305112146.0704d3aa@bahia.home> (raw)
In-Reply-To: <20200304153311.22959-4-philmd@redhat.com>
On Wed, 4 Mar 2020 16:33:09 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> We already have a ui pointer, use it (to simplify the next commit).
>
Small typo, s/ui/iu
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/scsi/spapr_vscsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> index 7e397ed797..3cb5a38181 100644
> --- a/hw/scsi/spapr_vscsi.c
> +++ b/hw/scsi/spapr_vscsi.c
> @@ -261,9 +261,9 @@ static int vscsi_send_rsp(VSCSIState *s, vscsi_req *req,
> if (status) {
> iu->srp.rsp.sol_not = (sol_not & 0x04) >> 2;
> if (req->senselen) {
> - req->iu.srp.rsp.flags |= SRP_RSP_FLAG_SNSVALID;
> - req->iu.srp.rsp.sense_data_len = cpu_to_be32(req->senselen);
> - memcpy(req->iu.srp.rsp.data, req->sense, req->senselen);
> + iu->srp.rsp.flags |= SRP_RSP_FLAG_SNSVALID;
> + iu->srp.rsp.sense_data_len = cpu_to_be32(req->senselen);
> + memcpy(iu->srp.rsp.data, req->sense, req->senselen);
> total_len += req->senselen;
> }
> } else {
next prev parent reply other threads:[~2020-03-05 10:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 15:33 [PATCH 0/5] hw/scsi/spapr_vscsi: Fix time bomb zero-length array use Philippe Mathieu-Daudé
2020-03-04 15:33 ` [PATCH 1/5] hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include Philippe Mathieu-Daudé
2020-03-05 0:39 ` David Gibson
2020-03-04 15:33 ` [PATCH 2/5] hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array Philippe Mathieu-Daudé
2020-03-05 0:40 ` David Gibson
2020-03-04 15:33 ` [PATCH 3/5] hw/scsi/spapr_vscsi: Simplify a bit Philippe Mathieu-Daudé
2020-03-05 0:40 ` David Gibson
2020-03-05 10:21 ` Greg Kurz [this message]
2020-03-04 15:33 ` [PATCH 4/5] hw/scsi/spapr_vscsi: Introduce req_ui() helper Philippe Mathieu-Daudé
2020-03-05 0:41 ` David Gibson
2020-03-05 0:42 ` David Gibson
2020-03-04 15:33 ` [PATCH 5/5] hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size Philippe Mathieu-Daudé
2020-03-05 0:43 ` David Gibson
2020-03-05 6:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305112146.0704d3aa@bahia.home \
--to=groug@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).