From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 883EEC3F2D1 for ; Thu, 5 Mar 2020 10:22:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61B7D2073D for ; Thu, 5 Mar 2020 10:22:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61B7D2073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9neW-0006fL-J9 for qemu-devel@archiver.kernel.org; Thu, 05 Mar 2020 05:22:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43363) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9ndj-000643-0x for qemu-devel@nongnu.org; Thu, 05 Mar 2020 05:22:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9ndh-0002Go-T2 for qemu-devel@nongnu.org; Thu, 05 Mar 2020 05:22:02 -0500 Received: from 5.mo4.mail-out.ovh.net ([188.165.44.50]:35351) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9ndh-0002EX-Mi for qemu-devel@nongnu.org; Thu, 05 Mar 2020 05:22:01 -0500 Received: from player774.ha.ovh.net (unknown [10.110.171.30]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id 653C721E4CB for ; Thu, 5 Mar 2020 11:21:59 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player774.ha.ovh.net (Postfix) with ESMTPSA id DFF8A102753C0; Thu, 5 Mar 2020 10:21:52 +0000 (UTC) Date: Thu, 5 Mar 2020 11:21:46 +0100 From: Greg Kurz To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH 3/5] hw/scsi/spapr_vscsi: Simplify a bit Message-ID: <20200305112146.0704d3aa@bahia.home> In-Reply-To: <20200304153311.22959-4-philmd@redhat.com> References: <20200304153311.22959-1-philmd@redhat.com> <20200304153311.22959-4-philmd@redhat.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 15188108271996475683 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedruddutddgudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecuffhomhgrihhnpehrshhprdgurghtrgenucfkpheptddrtddrtddrtddpkedvrddvheefrddvtdekrddvgeeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeejgedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhg X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 188.165.44.50 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 4 Mar 2020 16:33:09 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > We already have a ui pointer, use it (to simplify the next commit). >=20 Small typo, s/ui/iu=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/scsi/spapr_vscsi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > index 7e397ed797..3cb5a38181 100644 > --- a/hw/scsi/spapr_vscsi.c > +++ b/hw/scsi/spapr_vscsi.c > @@ -261,9 +261,9 @@ static int vscsi_send_rsp(VSCSIState *s, vscsi_req *r= eq, > if (status) { > iu->srp.rsp.sol_not =3D (sol_not & 0x04) >> 2; > if (req->senselen) { > - req->iu.srp.rsp.flags |=3D SRP_RSP_FLAG_SNSVALID; > - req->iu.srp.rsp.sense_data_len =3D cpu_to_be32(req->senselen= ); > - memcpy(req->iu.srp.rsp.data, req->sense, req->senselen); > + iu->srp.rsp.flags |=3D SRP_RSP_FLAG_SNSVALID; > + iu->srp.rsp.sense_data_len =3D cpu_to_be32(req->senselen); > + memcpy(iu->srp.rsp.data, req->sense, req->senselen); > total_len +=3D req->senselen; > } > } else {