From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Greg Kurz" <groug@kaod.org>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow
Date: Thu, 5 Mar 2020 13:12:46 +0100 [thread overview]
Message-ID: <20200305121253.19078-1-philmd@redhat.com> (raw)
This series fixes a possible buffer overflow.
Simples patches first (dissociate the buffer holding DMA
requests with pointer to SRP Information Unit packets) to
clean the issue in the penultimate patch.
v3:
- Fixed typo reported by Greg Kurz
- Addressed Paolo Bonzini review comments as an extra patch
- Added another patch converting a fprintf() call while here
v2:
- Addressed David Gibson review comments
Supersedes: <20200305083135.8270-1-philmd@redhat.com>
Philippe Mathieu-Daudé (7):
hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include
hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible
array
hw/scsi/spapr_vscsi: Simplify a bit
hw/scsi/spapr_vscsi: Introduce req_iu() helper
hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size
hw/scsi/spapr_vscsi: Prevent buffer overflow
hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event
hw/scsi/viosrp.h | 3 +-
hw/scsi/spapr_vscsi.c | 72 +++++++++++++++++++++++++------------------
hw/scsi/trace-events | 1 +
3 files changed, 45 insertions(+), 31 deletions(-)
--
2.21.1
next reply other threads:[~2020-03-05 12:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:12 Philippe Mathieu-Daudé [this message]
2020-03-05 12:12 ` [PATCH v3 1/7] hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include Philippe Mathieu-Daudé
2020-03-05 12:12 ` [PATCH v3 2/7] hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array Philippe Mathieu-Daudé
2020-03-05 12:12 ` [PATCH v3 3/7] hw/scsi/spapr_vscsi: Simplify a bit Philippe Mathieu-Daudé
2020-03-05 12:12 ` [PATCH v3 4/7] hw/scsi/spapr_vscsi: Introduce req_iu() helper Philippe Mathieu-Daudé
2020-03-05 12:12 ` [PATCH v3 5/7] hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size Philippe Mathieu-Daudé
2020-03-05 12:12 ` [PATCH v3 6/7] hw/scsi/spapr_vscsi: Prevent buffer overflow Philippe Mathieu-Daudé
2020-03-05 12:12 ` [PATCH v3 7/7] hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event Philippe Mathieu-Daudé
2020-03-05 12:30 ` [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow no-reply
2020-03-05 12:37 ` no-reply
2020-03-05 14:40 ` Paolo Bonzini
2020-03-05 23:03 ` David Gibson
2020-03-06 8:31 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305121253.19078-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).