* [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00
@ 2020-03-06 9:03 Gerd Hoffmann
2020-03-06 10:35 ` [SeaBIOS] " Paul Menzel
2020-03-06 13:41 ` Kevin O'Connor
0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2020-03-06 9:03 UTC (permalink / raw)
To: seabios; +Cc: qemu-devel, Gerd Hoffmann
Fixes console redirection for NetBSD primary bootloader.
https://bugs.launchpad.net/bugs/1743191
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
src/sercon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sercon.c b/src/sercon.c
index a5dadb7261af..66a1f2412e77 100644
--- a/src/sercon.c
+++ b/src/sercon.c
@@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
regs->ax = 0x0100;
} else {
// Disable sercon entry point on any vesa modeset
- if (regs->al == 0x00)
+ if (regs->al == 0x02)
SET_LOW(sercon_enable, 0);
}
}
--
2.18.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [SeaBIOS] [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00
2020-03-06 9:03 [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00 Gerd Hoffmann
@ 2020-03-06 10:35 ` Paul Menzel
2020-03-06 13:41 ` Kevin O'Connor
1 sibling, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2020-03-06 10:35 UTC (permalink / raw)
To: Gerd Hoffmann, seabios; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
Dear Gerd,
Maybe in imperative mood:
> Correct VBE modeset to int 10h function 4f02 not 4f00
On 2020-03-06 10:03, Gerd Hoffmann wrote:
> Fixes console redirection for NetBSD primary bootloader.
Add how to reproduce this:
wget http://ftp.netbsd.org/pub/NetBSD/NetBSD-7.1.1/amd64/installation/cdrom/boot-com.iso
qemu-system-x86_64 -nographic -cdrom boot-com.iso
For backports add:
Fixes: d6728f30 ("add serial console support")
> https://bugs.launchpad.net/bugs/1743191
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> src/sercon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sercon.c b/src/sercon.c
> index a5dadb7261af..66a1f2412e77 100644
> --- a/src/sercon.c
> +++ b/src/sercon.c
> @@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
> regs->ax = 0x0100;
> } else {
> // Disable sercon entry point on any vesa modeset
> - if (regs->al == 0x00)
> + if (regs->al == 0x02)
> SET_LOW(sercon_enable, 0);
> }
> }
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00
2020-03-06 9:03 [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00 Gerd Hoffmann
2020-03-06 10:35 ` [SeaBIOS] " Paul Menzel
@ 2020-03-06 13:41 ` Kevin O'Connor
1 sibling, 0 replies; 4+ messages in thread
From: Kevin O'Connor @ 2020-03-06 13:41 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: seabios, qemu-devel
On Fri, Mar 06, 2020 at 10:03:21AM +0100, Gerd Hoffmann wrote:
> Fixes console redirection for NetBSD primary bootloader.
>
> https://bugs.launchpad.net/bugs/1743191
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> src/sercon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sercon.c b/src/sercon.c
> index a5dadb7261af..66a1f2412e77 100644
> --- a/src/sercon.c
> +++ b/src/sercon.c
> @@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
> regs->ax = 0x0100;
> } else {
> // Disable sercon entry point on any vesa modeset
> - if (regs->al == 0x00)
> + if (regs->al == 0x02)
> SET_LOW(sercon_enable, 0);
> }
> }
Reviewed-by: Kevin O'Connor <kevin@koconnor.net>
-Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAEJNuHy_O23m0ttcPUYDeeFWLCC2dSvGk8WZPEVr9XkTaAx7Yg.ref@mail.gmail.com>]
* Re: [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00
[not found] <CAEJNuHy_O23m0ttcPUYDeeFWLCC2dSvGk8WZPEVr9XkTaAx7Yg.ref@mail.gmail.com>
@ 2020-03-06 13:57 ` Ottavio Caruso
0 siblings, 0 replies; 4+ messages in thread
From: Ottavio Caruso @ 2020-03-06 13:57 UTC (permalink / raw)
To: Gerd Hoffmann, seabios; +Cc: qemu-devel
On 06/03/2020 09:03, Gerd Hoffmann wrote:
> Fixes console redirection for NetBSD primary bootloader.
>
> https://bugs.launchpad.net/bugs/1743191
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> src/sercon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sercon.c b/src/sercon.c
> index a5dadb7261af..66a1f2412e77 100644
> --- a/src/sercon.c
> +++ b/src/sercon.c
> @@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs)
> regs->ax = 0x0100;
> } else {
> // Disable sercon entry point on any vesa modeset
> - if (regs->al == 0x00)
> + if (regs->al == 0x02)
> SET_LOW(sercon_enable, 0);
> }
> }
>
Unfortunately, this patch doesn't sort it for me. It also slightly
messes up with the console, see:
https://i.imgur.com/3ANAQC7.png
--
Ottavio Caruso
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-06 14:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-06 9:03 [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00 Gerd Hoffmann
2020-03-06 10:35 ` [SeaBIOS] " Paul Menzel
2020-03-06 13:41 ` Kevin O'Connor
[not found] <CAEJNuHy_O23m0ttcPUYDeeFWLCC2dSvGk8WZPEVr9XkTaAx7Yg.ref@mail.gmail.com>
2020-03-06 13:57 ` Ottavio Caruso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).
