* [PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
@ 2020-03-07 17:34 Unai Martinez-Corral
0 siblings, 0 replies; 2+ messages in thread
From: Unai Martinez-Corral @ 2020-03-07 17:34 UTC (permalink / raw)
To: qemu-devel; +Cc: riku.voipio, laurent
This breaks backward compatibility.
Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is
not present in other option names ('debian', 'systemd', 'persistent',
'credential'...). In order to keep consistency, the prefix is removed.
Signed-off-by: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
scripts/qemu-binfmt-conf.sh | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 251a78a2ce..2a035394e0 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -171,6 +171,7 @@ qemu_get_family() {
usage() {
cat <<EOF
+
Usage: qemu-binfmt-conf.sh [options]
Configure binfmt_misc to use qemu interpreter
@@ -179,8 +180,8 @@ Options and associated environment variables:
Argument Env-variable Description
-h|--help display this usage
--Q|--qemu-path PATH QEMU_PATH set path to qemu interpreter
--F|--qemu-suffix SUFFIX add a suffix to the default interpreter name
+-Q|--path PATH QEMU_PATH set path to qemu interpreter(s)
+-F|--suffix SUFFIX add a suffix to the default interpreter name
-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future
uses are cloned from the open file.
-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according
@@ -333,7 +334,7 @@ QEMU_CREDENTIAL="${QEMU_CREDENTIAL:-no}"
QEMU_SUFFIX=""
-options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@")
+options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
eval set -- "$options"
while true ; do
@@ -365,11 +366,11 @@ while true ; do
fi
fi
;;
- -Q|--qemu-path)
+ -Q|--path)
shift
QEMU_PATH="$1"
;;
- -F|--qemu-suffix)
+ -F|--suffix)
shift
QEMU_SUFFIX="$1"
;;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
2020-03-07 17:04 [PATCH v8 0/9] qemu-binfmt-conf.sh unai.martinezcorral
@ 2020-03-07 18:53 ` Unai Martinez-Corral
0 siblings, 0 replies; 2+ messages in thread
From: Unai Martinez-Corral @ 2020-03-07 18:53 UTC (permalink / raw)
To: qemu-devel; +Cc: riku.voipio, laurent
This breaks backward compatibility.
Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is
not present in other option names ('debian', 'systemd', 'persistent',
'credential'...). In order to keep consistency, the prefix is removed.
Signed-off-by: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
scripts/qemu-binfmt-conf.sh | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 251a78a2ce..2a035394e0 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -171,6 +171,7 @@ qemu_get_family() {
usage() {
cat <<EOF
+
Usage: qemu-binfmt-conf.sh [options]
Configure binfmt_misc to use qemu interpreter
@@ -179,8 +180,8 @@ Options and associated environment variables:
Argument Env-variable Description
-h|--help display this usage
--Q|--qemu-path PATH QEMU_PATH set path to qemu interpreter
--F|--qemu-suffix SUFFIX add a suffix to the default interpreter name
+-Q|--path PATH QEMU_PATH set path to qemu interpreter(s)
+-F|--suffix SUFFIX add a suffix to the default interpreter name
-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future
uses are cloned from the open file.
-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according
@@ -333,7 +334,7 @@ QEMU_CREDENTIAL="${QEMU_CREDENTIAL:-no}"
QEMU_SUFFIX=""
-options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@")
+options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
eval set -- "$options"
while true ; do
@@ -365,11 +366,11 @@ while true ; do
fi
fi
;;
- -Q|--qemu-path)
+ -Q|--path)
shift
QEMU_PATH="$1"
;;
- -F|--qemu-suffix)
+ -F|--suffix)
shift
QEMU_SUFFIX="$1"
;;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-07 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-07 17:34 [PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options Unai Martinez-Corral
-- strict thread matches above, loose matches on Subject: below --
2020-03-07 17:04 [PATCH v8 0/9] qemu-binfmt-conf.sh unai.martinezcorral
2020-03-07 18:53 ` [PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options Unai Martinez-Corral
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).