* [PATCH] mem-prealloc: initialize cond and mutex
@ 2020-03-06 8:50 Christian Borntraeger
2020-03-06 9:06 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Christian Borntraeger @ 2020-03-06 8:50 UTC (permalink / raw)
To: qemu-devel
Cc: Christian Borntraeger, qemu-s390x, Marc Hartmayer, bauerchen,
Paolo Bonzini
Guests with mem-prealloc do fail with
qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: qemu_mutex_lock_impl: Assertion `mutex->initialized' failed.
qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: qemu_cond_broadcast: Assertion `cond->initialized' failed.
Let us initialize cond and mutex.
Cc: bauerchen <bauerchen@tencent.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Fixes: 037fb5eb3941 ("mem-prealloc: optimize large guest startup")
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
util/oslib-posix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 897e8f3ba6..52650183d3 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -470,6 +470,8 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages,
char *addr = area;
int i = 0;
+ qemu_cond_init(&page_cond);
+ qemu_mutex_init(&page_mutex);
memset_thread_failed = false;
threads_created_flag = false;
memset_num_threads = get_memset_num_threads(smp_cpus);
--
2.25.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] mem-prealloc: initialize cond and mutex
2020-03-06 8:50 [PATCH] mem-prealloc: initialize cond and mutex Christian Borntraeger
@ 2020-03-06 9:06 ` Paolo Bonzini
2020-03-06 9:57 ` 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
2020-03-09 10:03 ` [PATCH] mem-prealloc: initialize cond and mutex Igor Mammedov
2 siblings, 0 replies; 12+ messages in thread
From: Paolo Bonzini @ 2020-03-06 9:06 UTC (permalink / raw)
To: Christian Borntraeger, qemu-devel; +Cc: qemu-s390x, Marc Hartmayer, bauerchen
On 06/03/20 09:50, Christian Borntraeger wrote:
> Guests with mem-prealloc do fail with
> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: qemu_mutex_lock_impl: Assertion `mutex->initialized' failed.
> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: qemu_cond_broadcast: Assertion `cond->initialized' failed.
>
> Let us initialize cond and mutex.
>
> Cc: bauerchen <bauerchen@tencent.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Fixes: 037fb5eb3941 ("mem-prealloc: optimize large guest startup")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> util/oslib-posix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 897e8f3ba6..52650183d3 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -470,6 +470,8 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages,
> char *addr = area;
> int i = 0;
>
> + qemu_cond_init(&page_cond);
> + qemu_mutex_init(&page_mutex);
> memset_thread_failed = false;
> threads_created_flag = false;
> memset_num_threads = get_memset_num_threads(smp_cpus);
>
Thank you very much. It's my fault, but is it too much to ask that
submitters test their patches???
Paolo
^ permalink raw reply [flat|nested] 12+ messages in thread
* 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-06 8:50 [PATCH] mem-prealloc: initialize cond and mutex Christian Borntraeger
2020-03-06 9:06 ` Paolo Bonzini
@ 2020-03-06 9:57 ` bauerchen(陈蒙蒙)
2020-03-09 9:17 ` Christian Borntraeger
2020-03-09 10:03 ` [PATCH] mem-prealloc: initialize cond and mutex Igor Mammedov
2 siblings, 1 reply; 12+ messages in thread
From: bauerchen(陈蒙蒙) @ 2020-03-06 9:57 UTC (permalink / raw)
To: Christian Borntraeger, qemu-devel
Cc: Christian Borntraeger, qemu-s390x, Marc Hartmayer, pbonzini
Very sorry for my fault, in fact,I test in a old qemu version ,and patch generated based a new one ;
All in all，its my fault, and I will check and test patch carefully In the future
If I need to submit the patch again ?
发件人： Christian Borntraeger
发送时间： 2020-03-06 16:50
收件人： qemu-devel
抄送： qemu-s390x; Christian Borntraeger; bauerchen(陈蒙蒙); Paolo Bonzini; Marc Hartmayer
主题： [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
Guests with mem-prealloc do fail with
qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: qemu_mutex_lock_impl: Assertion `mutex->initialized' failed.
qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: qemu_cond_broadcast: Assertion `cond->initialized' failed.
Let us initialize cond and mutex.
Cc: bauerchen <bauerchen@tencent.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Fixes: 037fb5eb3941 ("mem-prealloc: optimize large guest startup")
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
util/oslib-posix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 897e8f3ba6..52650183d3 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -470,6 +470,8 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages,
char *addr = area;
int i = 0;
+ qemu_cond_init(&page_cond);
+ qemu_mutex_init(&page_mutex);
memset_thread_failed = false;
threads_created_flag = false;
memset_num_threads = get_memset_num_threads(smp_cpus);
--
2.25.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-06 9:57 ` 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
@ 2020-03-09 9:17 ` Christian Borntraeger
0 siblings, 0 replies; 12+ messages in thread
From: Christian Borntraeger @ 2020-03-09 9:17 UTC (permalink / raw)
To: bauerchen(陈蒙蒙), qemu-devel
Cc: pbonzini, qemu-s390x, Marc Hartmayer
On 06.03.20 10:57, bauerchen(陈蒙蒙) wrote:
> Very sorry for my fault, in fact,I test in a old qemu version ,and patch generated based a new one ;
> All in all，its my fault, and I will check and test patch carefully In the future
> If I need to submit the patch again ?
Can you test and review my fixup? That will help Paolo to take my fix.
> 发件人： Christian Borntraeger
> 发送时间： 2020-03-06 16:50
> 收件人： qemu-devel
> 抄送： qemu-s390x; Christian Borntraeger; bauerchen(陈蒙蒙); Paolo Bonzini; Marc Hartmayer
> 主题： [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
> Guests with mem-prealloc do fail with
> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: qemu_mutex_lock_impl: Assertion `mutex->initialized' failed.
> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: qemu_cond_broadcast: Assertion `cond->initialized' failed.
>
> Let us initialize cond and mutex.
>
> Cc: bauerchen <bauerchen@tencent.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Fixes: 037fb5eb3941 ("mem-prealloc: optimize large guest startup")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> util/oslib-posix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 897e8f3ba6..52650183d3 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -470,6 +470,8 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages,
> char *addr = area;
> int i = 0;
> + qemu_cond_init(&page_cond);
> + qemu_mutex_init(&page_mutex);
> memset_thread_failed = false;
> threads_created_flag = false;
> memset_num_threads = get_memset_num_threads(smp_cpus);
> --
> 2.25.0
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mem-prealloc: initialize cond and mutex
2020-03-06 8:50 [PATCH] mem-prealloc: initialize cond and mutex Christian Borntraeger
2020-03-06 9:06 ` Paolo Bonzini
2020-03-06 9:57 ` 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
@ 2020-03-09 10:03 ` Igor Mammedov
2020-03-09 10:05 ` Paolo Bonzini
2 siblings, 1 reply; 12+ messages in thread
From: Igor Mammedov @ 2020-03-09 10:03 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Paolo Bonzini, qemu-s390x, Marc Hartmayer, qemu-devel, bauerchen
On Fri, 6 Mar 2020 03:50:14 -0500
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Guests with mem-prealloc do fail with
> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: qemu_mutex_lock_impl: Assertion `mutex->initialized' failed.
> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: qemu_cond_broadcast: Assertion `cond->initialized' failed.
>
> Let us initialize cond and mutex.
>
> Cc: bauerchen <bauerchen@tencent.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Fixes: 037fb5eb3941 ("mem-prealloc: optimize large guest startup")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> util/oslib-posix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 897e8f3ba6..52650183d3 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -470,6 +470,8 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages,
> char *addr = area;
> int i = 0;
>
> + qemu_cond_init(&page_cond);
> + qemu_mutex_init(&page_mutex);
Is it possible for touch_all_pages to be called several times?
If it's then it probably needs a guard against that to make
sure it won't explode, something like:
static bool page_mutex_inited;
if(page_mutex_inited)
page_mutex_inited = true
qemu_mutex_init(&page_mutex)
...
> memset_thread_failed = false;
> threads_created_flag = false;
> memset_num_threads = get_memset_num_threads(smp_cpus);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mem-prealloc: initialize cond and mutex
2020-03-09 10:03 ` [PATCH] mem-prealloc: initialize cond and mutex Igor Mammedov
@ 2020-03-09 10:05 ` Paolo Bonzini
2020-03-09 11:01 ` Christian Borntraeger
0 siblings, 1 reply; 12+ messages in thread
From: Paolo Bonzini @ 2020-03-09 10:05 UTC (permalink / raw)
To: Igor Mammedov, Christian Borntraeger
Cc: qemu-s390x, Marc Hartmayer, qemu-devel, bauerchen
On 09/03/20 11:03, Igor Mammedov wrote:
>> + qemu_cond_init(&page_cond);
>> + qemu_mutex_init(&page_mutex);
> Is it possible for touch_all_pages to be called several times?
> If it's then it probably needs a guard against that to make
> sure it won't explode, something like:
>
> static bool page_mutex_inited;
>
> if(page_mutex_inited)
> page_mutex_inited = true
> qemu_mutex_init(&page_mutex)
> ...
>
Hmm, good idea, it should also use GOnce.
Paolo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mem-prealloc: initialize cond and mutex
2020-03-09 10:05 ` Paolo Bonzini
@ 2020-03-09 11:01 ` Christian Borntraeger
2020-03-09 11:16 ` Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
0 siblings, 1 reply; 12+ messages in thread
From: Christian Borntraeger @ 2020-03-09 11:01 UTC (permalink / raw)
To: Paolo Bonzini, Igor Mammedov
Cc: qemu-s390x, Marc Hartmayer, qemu-devel, bauerchen
On 09.03.20 11:05, Paolo Bonzini wrote:
> On 09/03/20 11:03, Igor Mammedov wrote:
>>> + qemu_cond_init(&page_cond);
>>> + qemu_mutex_init(&page_mutex);
>> Is it possible for touch_all_pages to be called several times?
>> If it's then it probably needs a guard against that to make
>> sure it won't explode, something like:
>>
>> static bool page_mutex_inited;
>>
>> if(page_mutex_inited)
>> page_mutex_inited = true
>> qemu_mutex_init(&page_mutex)
>> ...
>>
>
> Hmm, good idea, it should also use GOnce.
Maybe start with a revert and let the original submitter send
a fixed up patch?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-09 11:01 ` Christian Borntraeger
@ 2020-03-09 11:16 ` bauerchen(陈蒙蒙)
2020-03-09 13:19 ` Igor Mammedov
0 siblings, 1 reply; 12+ messages in thread
From: bauerchen(陈蒙蒙) @ 2020-03-09 11:16 UTC (permalink / raw)
To: borntraeger, pbonzini, Igor Mammedov; +Cc: qemu-s390x, mhartmay, qemu-devel
Thanks, in fact,do_touch_pages is called just when vm starts up, but using init flag and Gonce maybe more elegant !
if needed,I can submit a new patch !
thanks very much!
bauerchen
From: Christian Borntraeger
Date: 2020-03-09 19:01
To: Paolo Bonzini; Igor Mammedov
CC: qemu-devel; qemu-s390x; Marc Hartmayer; bauerchen(陈蒙蒙)
Subject: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
On 09.03.20 11:05, Paolo Bonzini wrote:
> On 09/03/20 11:03, Igor Mammedov wrote:
>>> + qemu_cond_init(&page_cond);
>>> + qemu_mutex_init(&page_mutex);
>> Is it possible for touch_all_pages to be called several times?
>> If it's then it probably needs a guard against that to make
>> sure it won't explode, something like:
>>
>> static bool page_mutex_inited;
>>
>> if(page_mutex_inited)
>> page_mutex_inited = true
>> qemu_mutex_init(&page_mutex)
>> ...
>>
>
> Hmm, good idea, it should also use GOnce.
Maybe start with a revert and let the original submitter send
a fixed up patch?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-09 11:16 ` Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
@ 2020-03-09 13:19 ` Igor Mammedov
2020-03-10 7:06 ` bauerchen(陈蒙蒙)
0 siblings, 1 reply; 12+ messages in thread
From: Igor Mammedov @ 2020-03-09 13:19 UTC (permalink / raw)
To: bauerchen(陈蒙蒙)
Cc: borntraeger, qemu-s390x, mhartmay, qemu-devel, pbonzini
On Mon, 9 Mar 2020 11:16:10 +0000
bauerchen(陈蒙蒙) <bauerchen@tencent.com> wrote:
> Thanks, in fact,do_touch_pages is called just when vm starts up, but using init flag and Gonce maybe more elegant !
> if needed,I can submit a new patch !
> thanks very much!
it's called from os_mem_prealloc() -> touch_all_pages() which is called
at least once per an instance of hotsmem backend. So if several backends
are used then it should be called several times.
The same applies when a hostmem backend is added during runtime (hotplug)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-09 13:19 ` Igor Mammedov
@ 2020-03-10 7:06 ` bauerchen(陈蒙蒙)
2020-03-11 18:34 ` Paolo Bonzini
0 siblings, 1 reply; 12+ messages in thread
From: bauerchen(陈蒙蒙) @ 2020-03-10 7:06 UTC (permalink / raw)
To: Igor Mammedov; +Cc: borntraeger, qemu-s390x, mhartmay, qemu-devel, pbonzini
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
oh ,yes.Thanks
I want to know if I submit a new fixed patch or just a patch fixed current problem??
if a new fixed patch, maybe need a revert ?
________________________________
bauerchen(陈蒙蒙)
From: Igor Mammedov<mailto:imammedo@redhat.com>
Date: 2020-03-09 21:19
To: bauerchen(陈蒙蒙)<mailto:bauerchen@tencent.com>
CC: borntraeger<mailto:borntraeger@de.ibm.com>; pbonzini<mailto:pbonzini@redhat.com>; qemu-devel<mailto:qemu-devel@nongnu.org>; qemu-s390x<mailto:qemu-s390x@nongnu.org>; mhartmay<mailto:mhartmay@linux.ibm.com>
Subject: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
On Mon, 9 Mar 2020 11:16:10 +0000
bauerchen(陈蒙蒙) <bauerchen@tencent.com> wrote:
> Thanks, in fact,do_touch_pages is called just when vm starts up, but using init flag and Gonce maybe more elegant !
> if needed,I can submit a new patch !
> thanks very much!
it's called from os_mem_prealloc() -> touch_all_pages() which is called
at least once per an instance of hotsmem backend. So if several backends
are used then it should be called several times.
The same applies when a hostmem backend is added during runtime (hotplug)
[-- Attachment #2: Type: text/html, Size: 2515 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-10 7:06 ` bauerchen(陈蒙蒙)
@ 2020-03-11 18:34 ` Paolo Bonzini
2020-03-12 5:05 ` bauerchen(陈蒙蒙)
0 siblings, 1 reply; 12+ messages in thread
From: Paolo Bonzini @ 2020-03-11 18:34 UTC (permalink / raw)
To: bauerchen(陈蒙蒙), Igor Mammedov
Cc: borntraeger, qemu-s390x, mhartmay, qemu-devel
On 10/03/20 08:06, bauerchen(陈蒙蒙) wrote:
> oh ,yes.Thanks
> I want to know if I submit a new fixed patch or just a patch fixed
> current problem??
> if a new fixed patch, maybe need a revert ?
Sorry I missed this message. I have already sent a fixed patch, thanks!
Paolo
> ------------------------------------------------------------------------
> bauerchen(陈蒙蒙)
>
>
> *From:* Igor Mammedov <mailto:imammedo@redhat.com>
> *Date:* 2020-03-09 21:19
> *To:* bauerchen(陈蒙蒙) <mailto:bauerchen@tencent.com>
> *CC:* borntraeger <mailto:borntraeger@de.ibm.com>; pbonzini
> <mailto:pbonzini@redhat.com>; qemu-devel
> <mailto:qemu-devel@nongnu.org>; qemu-s390x
> <mailto:qemu-s390x@nongnu.org>; mhartmay <mailto:mhartmay@linux.ibm.com>
> *Subject:* Re: [PATCH] mem-prealloc: initialize cond and
> mutex(Internet mail)
> On Mon, 9 Mar 2020 11:16:10 +0000
> bauerchen(陈蒙蒙) <bauerchen@tencent.com> wrote:
>
> > Thanks, in fact,do_touch_pages is called just when vm starts up,
> but using init flag and Gonce maybe more elegant !
> > if needed,I can submit a new patch !
> > thanks very much!
>
> it's called from os_mem_prealloc() -> touch_all_pages() which is called
> at least once per an instance of hotsmem backend. So if several backends
> are used then it should be called several times.
> The same applies when a hostmem backend is added during runtime
> (hotplug)
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
2020-03-11 18:34 ` Paolo Bonzini
@ 2020-03-12 5:05 ` bauerchen(陈蒙蒙)
0 siblings, 0 replies; 12+ messages in thread
From: bauerchen(陈蒙蒙) @ 2020-03-12 5:05 UTC (permalink / raw)
To: pbonzini, Igor Mammedov; +Cc: borntraeger, qemu-s390x, mhartmay, qemu-devel
ok ,thanks Paolo
bauer
From: Paolo Bonzini
Date: 2020-03-12 02:34
To: bauerchen(陈蒙蒙); Igor Mammedov
CC: borntraeger; qemu-devel; qemu-s390x; mhartmay
Subject: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)
On 10/03/20 08:06, bauerchen(陈蒙蒙) wrote:
> oh ,yes.Thanks
> I want to know if I submit a new fixed patch or just a patch fixed
> current problem??
> if a new fixed patch, maybe need a revert ?
Sorry I missed this message. I have already sent a fixed patch, thanks!
Paolo
> ------------------------------------------------------------------------
> bauerchen(陈蒙蒙)
>
>
> *From:* Igor Mammedov <mailto:imammedo@redhat.com>
> *Date:* 2020-03-09 21:19
> *To:* bauerchen(陈蒙蒙) <mailto:bauerchen@tencent.com>
> *CC:* borntraeger <mailto:borntraeger@de.ibm.com>; pbonzini
> <mailto:pbonzini@redhat.com>; qemu-devel
> <mailto:qemu-devel@nongnu.org>; qemu-s390x
> <mailto:qemu-s390x@nongnu.org>; mhartmay <mailto:mhartmay@linux.ibm.com>
> *Subject:* Re: [PATCH] mem-prealloc: initialize cond and
> mutex(Internet mail)
> On Mon, 9 Mar 2020 11:16:10 +0000
> bauerchen(陈蒙蒙) <bauerchen@tencent.com> wrote:
>
> > Thanks, in fact,do_touch_pages is called just when vm starts up,
> but using init flag and Gonce maybe more elegant !
> > if needed,I can submit a new patch !
> > thanks very much!
>
> it's called from os_mem_prealloc() -> touch_all_pages() which is called
> at least once per an instance of hotsmem backend. So if several backends
> are used then it should be called several times.
> The same applies when a hostmem backend is added during runtime
> (hotplug)
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-03-12 5:06 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-06 8:50 [PATCH] mem-prealloc: initialize cond and mutex Christian Borntraeger
2020-03-06 9:06 ` Paolo Bonzini
2020-03-06 9:57 ` 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
2020-03-09 9:17 ` Christian Borntraeger
2020-03-09 10:03 ` [PATCH] mem-prealloc: initialize cond and mutex Igor Mammedov
2020-03-09 10:05 ` Paolo Bonzini
2020-03-09 11:01 ` Christian Borntraeger
2020-03-09 11:16 ` Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail) bauerchen(陈蒙蒙)
2020-03-09 13:19 ` Igor Mammedov
2020-03-10 7:06 ` bauerchen(陈蒙蒙)
2020-03-11 18:34 ` Paolo Bonzini
2020-03-12 5:05 ` bauerchen(陈蒙蒙)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).