From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH 0/2] qemu/queue.h: clear linked list pointers on remove
Date: Mon, 9 Mar 2020 16:40:10 +0000 [thread overview]
Message-ID: <20200309164010.GD46227@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200224103406.1894923-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On Mon, Feb 24, 2020 at 10:34:04AM +0000, Stefan Hajnoczi wrote:
> QLIST_REMOVE() and friends leave dangling linked list pointers in the node that
> was removed. This makes it impossible to decide whether a node is currently in
> a list or not. It also makes debugging harder.
>
> Based-on: 20200222085030.1760640-1-stefanha@redhat.com
> ("[PULL 00/31] Block patches")
>
> Stefan Hajnoczi (2):
> qemu/queue.h: clear linked list pointers on remove
> aio-posix: remove confusing QLIST_SAFE_REMOVE()
>
> include/qemu/queue.h | 19 +++++++++++++++----
> util/aio-posix.c | 2 +-
> 2 files changed, 16 insertions(+), 5 deletions(-)
>
> --
> 2.24.1
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-09 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 10:34 [PATCH 0/2] qemu/queue.h: clear linked list pointers on remove Stefan Hajnoczi
2020-02-24 10:34 ` [PATCH 1/2] " Stefan Hajnoczi
2020-02-24 11:51 ` Philippe Mathieu-Daudé
2020-02-25 9:01 ` Stefan Hajnoczi
2020-02-24 10:34 ` [PATCH 2/2] aio-posix: remove confusing QLIST_SAFE_REMOVE() Stefan Hajnoczi
2020-02-24 10:55 ` [PATCH 0/2] qemu/queue.h: clear linked list pointers on remove no-reply
2020-02-24 11:39 ` Stefan Hajnoczi
2020-02-24 11:54 ` Philippe Mathieu-Daudé
2020-02-25 9:05 ` Stefan Hajnoczi
2020-02-25 10:06 ` Philippe Mathieu-Daudé
2020-03-09 16:40 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309164010.GD46227@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).