From: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, laurent@vivier.eu
Subject: [PATCH v9 9/9] qemu-binfmt-conf.sh: add --test
Date: Mon, 9 Mar 2020 18:41:53 +0000 [thread overview]
Message-ID: <20200309184153.GI14@669c1c222ef4> (raw)
In-Reply-To: <20200309183521.GA9@669c1c222ef4>
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
scripts/qemu-binfmt-conf.sh | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 55224a68e1..21c8f63916 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -201,8 +201,7 @@ Options and associated environment variables:
Argument Env-variable Description
TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below);
- if empty, configure/clear all known targets;
- if 'NONE', no interpreter is configured.
+ if empty, configure/clear all known targets.
-h|--help display this usage
-Q|--path PATH QEMU_PATH set path to qemu interpreter(s)
-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name
@@ -212,6 +211,8 @@ TARGETS QEMU_TARGETS A single arch name or a list of them (see
to the binary to interpret
-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS;
then exit.
+-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not
+ configure any of the interpreters.
-e|--exportdir PATH define where to write configuration files
(default: $SYSTEMDDIR or $DEBIANDIR)
-s|--systemd don't write into /proc, generate file(s) for
@@ -225,6 +226,7 @@ QEMU_SUFFIX=$QEMU_SUFFIX
QEMU_PERSISTENT=$QEMU_PERSISTENT
QEMU_CREDENTIAL=$QEMU_CREDENTIAL
QEMU_CLEAR=$QEMU_CLEAR
+QEMU_TEST=$QEMU_TEST
To import templates with update-binfmts, use :
@@ -323,9 +325,6 @@ qemu_set_binfmts() {
# reduce the list of target interpreters to those given in the CLI
targets=${@:-$QEMU_TARGET}
- if [ "x$targets" = "xNONE" ]; then
- return
- fi
qemu_check_target_list $targets
# register the interpreter for each target except for the native one
@@ -377,12 +376,16 @@ QEMU_SUFFIX="${QEMU_SUFFIX:-}"
QEMU_PERSISTENT="${QEMU_PERSISTENT:-no}"
QEMU_CREDENTIAL="${QEMU_CREDENTIAL:-no}"
QEMU_CLEAR="${QEMU_CLEAR:-no}"
+QEMU_TEST="${QEMU_TEST:-no}"
-options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
+options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
eval set -- "$options"
while true; do
case "$1" in
+ -t|--test)
+ QEMU_TEST="yes"
+ ;;
-r|--clear)
QEMU_CLEAR="yes"
;;
@@ -431,6 +434,11 @@ shift
$CHECK
+if [ "x$QEMU_TEST" = "xyes" ]; then
+ BINFMT_SET=:
+ BINFMT_CLEAR=:
+fi
+
if [ "x$QEMU_CLEAR" = "xyes" ]; then
qemu_check_target_list "$@"
for t in $checked_target_list; do
--
2.25.1
next prev parent reply other threads:[~2020-03-09 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:35 [PATCH v9 0/9] qemu-binfmt-conf.sh Unai Martinez-Corral
2020-03-09 18:36 ` [PATCH v9 1/9] qemu-binfmt-conf.sh: enforce safe style consistency Unai Martinez-Corral
2020-03-09 18:37 ` [PATCH v9 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean Unai Martinez-Corral
2020-03-09 18:38 ` [PATCH v9 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT Unai Martinez-Corral
2020-03-09 18:38 ` [PATCH v9 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-* Unai Martinez-Corral
2020-03-09 18:39 ` [PATCH v9 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options Unai Martinez-Corral
2020-03-09 18:39 ` [PATCH v9 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX Unai Martinez-Corral
2020-03-09 18:40 ` [PATCH v9 7/9] qemu-binfmt-conf.sh: generalize <CPU> to positional [TARGETS] Unai Martinez-Corral
2020-03-09 18:41 ` [PATCH v9 8/9] qemu-binfmt-conf.sh: add option --clear Unai Martinez-Corral
2020-03-09 18:41 ` Unai Martinez-Corral [this message]
2020-03-09 19:00 ` [PATCH v9 0/9] qemu-binfmt-conf.sh no-reply
2020-03-09 19:19 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309184153.GI14@669c1c222ef4 \
--to=unai.martinezcorral@ehu.eus \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).