qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, cohuck@redhat.com,
	david@redhat.com
Subject: [PATCH v8 10/15] s390x: protvirt: Move diag 308 data over SIDA
Date: Tue, 10 Mar 2020 09:40:03 -0400	[thread overview]
Message-ID: <20200310134008.130038-11-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200310134008.130038-1-frankja@linux.ibm.com>

For protected guests the IPIB is written/read to/from the SIDA, so we
need those accesses to go through s390_cpu_pv_mem_read/write().

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 target/s390x/diag.c | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index 02918b37b8..417c4b53ab 100644
--- a/target/s390x/diag.c
+++ b/target/s390x/diag.c
@@ -87,6 +87,7 @@ static int diag308_parm_check(CPUS390XState *env, uint64_t r1, uint64_t addr,
 void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)
 {
     CPUState *cs = env_cpu(env);
+    S390CPU *cpu = S390_CPU(cs);
     uint64_t addr =  env->regs[r1];
     uint64_t subcode = env->regs[r3];
     IplParameterBlock *iplb;
@@ -123,13 +124,22 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)
             return;
         }
         iplb = g_new0(IplParameterBlock, 1);
-        cpu_physical_memory_read(addr, iplb, sizeof(iplb->len));
+        if (!s390_is_pv()) {
+            cpu_physical_memory_read(addr, iplb, sizeof(iplb->len));
+        } else {
+            s390_cpu_pv_mem_read(cpu, 0, iplb, sizeof(iplb->len));
+        }
+
         if (!iplb_valid_len(iplb)) {
             env->regs[r1 + 1] = DIAG_308_RC_INVALID;
             goto out;
         }
 
-        cpu_physical_memory_read(addr, iplb, be32_to_cpu(iplb->len));
+        if (!s390_is_pv()) {
+            cpu_physical_memory_read(addr, iplb, be32_to_cpu(iplb->len));
+        } else {
+            s390_cpu_pv_mem_read(cpu, 0, iplb, be32_to_cpu(iplb->len));
+        }
 
         if (!iplb_valid(iplb)) {
             env->regs[r1 + 1] = DIAG_308_RC_INVALID;
@@ -151,12 +161,17 @@ out:
         } else {
             iplb = s390_ipl_get_iplb();
         }
-        if (iplb) {
-            cpu_physical_memory_write(addr, iplb, be32_to_cpu(iplb->len));
-            env->regs[r1 + 1] = DIAG_308_RC_OK;
-        } else {
+        if (!iplb) {
             env->regs[r1 + 1] = DIAG_308_RC_NO_CONF;
+            return;
         }
+
+        if (!s390_is_pv()) {
+            cpu_physical_memory_write(addr, iplb, be32_to_cpu(iplb->len));
+        } else {
+            s390_cpu_pv_mem_write(cpu, 0, iplb, be32_to_cpu(iplb->len));
+        }
+        env->regs[r1 + 1] = DIAG_308_RC_OK;
         return;
     case DIAG308_PV_START:
         iplb = s390_ipl_get_iplb_pv();
-- 
2.20.1



  parent reply	other threads:[~2020-03-10 13:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 13:39 [PATCH v8 00/15] s390x: Protected Virtualization support Janosch Frank
2020-03-10 13:39 ` [PATCH v8 01/15] Sync pv Janosch Frank
2020-03-10 13:39 ` [PATCH v8 02/15] s390x: protvirt: Support unpack facility Janosch Frank
2020-03-10 15:26   ` David Hildenbrand
2020-03-10 15:49     ` Janosch Frank
2020-03-10 15:41   ` Christian Borntraeger
2020-03-10 16:01     ` Janosch Frank
2020-03-11 10:20     ` [PATCH v9] " Janosch Frank
2020-03-10 13:39 ` [PATCH v8 03/15] s390x: protvirt: Add migration blocker Janosch Frank
2020-03-10 14:57   ` David Hildenbrand
2020-03-10 15:02     ` Janosch Frank
2020-03-10 15:08       ` David Hildenbrand
2020-03-10 15:14         ` Janosch Frank
2020-03-10 15:24         ` [PATCH v9] " Janosch Frank
2020-03-10 15:26           ` David Hildenbrand
2020-03-10 13:39 ` [PATCH v8 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode Janosch Frank
2020-03-10 13:39 ` [PATCH v8 05/15] s390x: protvirt: KVM intercept changes Janosch Frank
2020-03-10 15:20   ` Christian Borntraeger
2020-03-10 15:23     ` Janosch Frank
2020-03-10 13:39 ` [PATCH v8 06/15] s390x: Add SIDA memory ops Janosch Frank
2020-03-10 13:40 ` [PATCH v8 07/15] s390x: protvirt: Move STSI data over SIDAD Janosch Frank
2020-03-10 13:40 ` [PATCH v8 08/15] s390x: protvirt: SCLP interpretation Janosch Frank
2020-03-10 13:40 ` [PATCH v8 09/15] s390x: protvirt: Set guest IPL PSW Janosch Frank
2020-03-10 13:40 ` Janosch Frank [this message]
2020-03-10 15:00   ` [PATCH v8 10/15] s390x: protvirt: Move diag 308 data over SIDA David Hildenbrand
2020-03-10 13:40 ` [PATCH v8 11/15] s390x: protvirt: Disable address checks for PV guest IO emulation Janosch Frank
2020-03-10 13:40 ` [PATCH v8 12/15] s390x: protvirt: Move IO control structures over SIDA Janosch Frank
2020-03-10 13:40 ` [PATCH v8 13/15] s390x: protvirt: Handle SIGP store status correctly Janosch Frank
2020-03-10 13:40 ` [PATCH v8 14/15] docs: Add protvirt docs Janosch Frank
2020-03-10 13:40 ` [PATCH v8 15/15] s390x: Add unpack facility feature to GA1 Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310134008.130038-11-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).