[PATCH 0/2] hw/mem/pc-dimm: Trivial code changes

[PATCH 0/2] hw/mem/pc-dimm: Trivial code changes

[Wainer dos Santos Moschetta]

Improve one error message and fix one code style warning.

Wainer dos Santos Moschetta (2):
  hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
  hw/mem/pc-dimm: Fix line over 80 characters warning

 hw/mem/pc-dimm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.24.1

[PATCH 1/2] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()

[Wainer dos Santos Moschetta]

The error report in pc_dimm_pre_plug() now has the slot
number printed.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 hw/mem/pc-dimm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 8f50b8afea..36edfcf467 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -44,8 +44,8 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine,
                                    &error_abort);
     if ((slot < 0 || slot >= machine->ram_slots) &&
          slot != PC_DIMM_UNASSIGNED_SLOT) {
-        error_setg(&local_err, "invalid slot number, valid range is [0-%"
-                   PRIu64 "]", machine->ram_slots - 1);
+        error_setg(&local_err, "invalid slot number %d, valid range is [0-%"
+                   PRIu64 "]", slot, machine->ram_slots - 1);
         goto out;
     }
 
-- 
2.24.1

[PATCH 2/2] hw/mem/pc-dimm: Fix line over 80 characters warning

[Wainer dos Santos Moschetta]

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 hw/mem/pc-dimm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 36edfcf467..6d62588fea 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -218,7 +218,8 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)
 
 static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)
 {
-    return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, &error_abort);
+    return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP,
+                                    &error_abort);
 }
 
 static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,
-- 
2.24.1

Re: [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes

[Stefano Garzarella]

On Tue, Mar 10, 2020 at 03:05:08PM -0300, Wainer dos Santos Moschetta wrote:
> Improve one error message and fix one code style warning.
> 
> Wainer dos Santos Moschetta (2):
>   hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
>   hw/mem/pc-dimm: Fix line over 80 characters warning
> 
>  hw/mem/pc-dimm.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes

[Laurent Vivier]

Le 10/03/2020 à 19:05, Wainer dos Santos Moschetta a écrit :
> Improve one error message and fix one code style warning.
> 
> Wainer dos Santos Moschetta (2):
>   hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
>   hw/mem/pc-dimm: Fix line over 80 characters warning
> 
>  hw/mem/pc-dimm.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Applied to my trivial-patches branch.

Thanks,
Laurent