* [PATCH 1/2] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
2020-03-10 18:05 [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes Wainer dos Santos Moschetta
@ 2020-03-10 18:05 ` Wainer dos Santos Moschetta
2020-03-10 18:05 ` [PATCH 2/2] hw/mem/pc-dimm: Fix line over 80 characters warning Wainer dos Santos Moschetta
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-03-10 18:05 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, imammedo, mst
The error report in pc_dimm_pre_plug() now has the slot
number printed.
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
hw/mem/pc-dimm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 8f50b8afea..36edfcf467 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -44,8 +44,8 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine,
&error_abort);
if ((slot < 0 || slot >= machine->ram_slots) &&
slot != PC_DIMM_UNASSIGNED_SLOT) {
- error_setg(&local_err, "invalid slot number, valid range is [0-%"
- PRIu64 "]", machine->ram_slots - 1);
+ error_setg(&local_err, "invalid slot number %d, valid range is [0-%"
+ PRIu64 "]", slot, machine->ram_slots - 1);
goto out;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] hw/mem/pc-dimm: Fix line over 80 characters warning
2020-03-10 18:05 [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes Wainer dos Santos Moschetta
2020-03-10 18:05 ` [PATCH 1/2] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug() Wainer dos Santos Moschetta
@ 2020-03-10 18:05 ` Wainer dos Santos Moschetta
2020-03-11 9:56 ` [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes Stefano Garzarella
2020-05-04 9:23 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-03-10 18:05 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, imammedo, mst
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
hw/mem/pc-dimm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 36edfcf467..6d62588fea 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -218,7 +218,8 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)
static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)
{
- return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, &error_abort);
+ return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP,
+ &error_abort);
}
static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes
2020-03-10 18:05 [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes Wainer dos Santos Moschetta
2020-03-10 18:05 ` [PATCH 1/2] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug() Wainer dos Santos Moschetta
2020-03-10 18:05 ` [PATCH 2/2] hw/mem/pc-dimm: Fix line over 80 characters warning Wainer dos Santos Moschetta
@ 2020-03-11 9:56 ` Stefano Garzarella
2020-05-04 9:23 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Garzarella @ 2020-03-11 9:56 UTC (permalink / raw)
To: Wainer dos Santos Moschetta; +Cc: qemu-trivial, imammedo, qemu-devel, mst
On Tue, Mar 10, 2020 at 03:05:08PM -0300, Wainer dos Santos Moschetta wrote:
> Improve one error message and fix one code style warning.
>
> Wainer dos Santos Moschetta (2):
> hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
> hw/mem/pc-dimm: Fix line over 80 characters warning
>
> hw/mem/pc-dimm.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes
2020-03-10 18:05 [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes Wainer dos Santos Moschetta
` (2 preceding siblings ...)
2020-03-11 9:56 ` [PATCH 0/2] hw/mem/pc-dimm: Trivial code changes Stefano Garzarella
@ 2020-05-04 9:23 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2020-05-04 9:23 UTC (permalink / raw)
To: Wainer dos Santos Moschetta, qemu-devel; +Cc: qemu-trivial, imammedo, mst
Le 10/03/2020 à 19:05, Wainer dos Santos Moschetta a écrit :
> Improve one error message and fix one code style warning.
>
> Wainer dos Santos Moschetta (2):
> hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug()
> hw/mem/pc-dimm: Fix line over 80 characters warning
>
> hw/mem/pc-dimm.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread