* [PATCH v2] configure: Improve zstd test
@ 2020-03-10 11:14 Juan Quintela
2020-03-12 10:59 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Juan Quintela @ 2020-03-10 11:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Juan Quintela
There were one error on the test (missing an s for --exists).
But we really need a recent zstd (1.4.0).
Thanks to Michal Privoznik to provide the right vension.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reported-by: Richard Henderson <richard.henderson@linaro.org>
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index cbf864bff1..f5454bd603 100755
--- a/configure
+++ b/configure
@@ -2475,7 +2475,8 @@ fi
# zstd check
if test "$zstd" != "no" ; then
- if $pkg_config --exist libzstd ; then
+ libzstd_minver="1.4.0"
+ if $pkg_config --atleast-version=$libzstd_minver libzstd ; then
zstd_cflags="$($pkg_config --cflags libzstd)"
zstd_libs="$($pkg_config --libs libzstd)"
LIBS="$zstd_libs $LIBS"
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] configure: Improve zstd test
2020-03-10 11:14 [PATCH v2] configure: Improve zstd test Juan Quintela
@ 2020-03-12 10:59 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-12 10:59 UTC (permalink / raw)
To: Juan Quintela; +Cc: Richard Henderson, qemu-devel
* Juan Quintela (quintela@redhat.com) wrote:
> There were one error on the test (missing an s for --exists).
> But we really need a recent zstd (1.4.0).
> Thanks to Michal Privoznik to provide the right vension.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
Queued for migration
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index cbf864bff1..f5454bd603 100755
> --- a/configure
> +++ b/configure
> @@ -2475,7 +2475,8 @@ fi
> # zstd check
>
> if test "$zstd" != "no" ; then
> - if $pkg_config --exist libzstd ; then
> + libzstd_minver="1.4.0"
> + if $pkg_config --atleast-version=$libzstd_minver libzstd ; then
> zstd_cflags="$($pkg_config --cflags libzstd)"
> zstd_libs="$($pkg_config --libs libzstd)"
> LIBS="$zstd_libs $LIBS"
> --
> 2.24.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-10 11:14 [PATCH v2] configure: Improve zstd test Juan Quintela
2020-03-12 10:59 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).