qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 02/36] target/arm: Update hflags in trans_CPS_v7m()
Date: Thu, 12 Mar 2020 16:44:25 +0000	[thread overview]
Message-ID: <20200312164459.25924-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20200312164459.25924-1-peter.maydell@linaro.org>

For M-profile CPUs, the FAULTMASK value affects the CPU's MMU index
(it changes the NegPri bit). We update the hflags after calls
to the v7m_msr helper in trans_MSR_v7m() but forgot to do so
in trans_CPS_v7m().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20200303174950.3298-3-peter.maydell@linaro.org
---
 target/arm/translate.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/target/arm/translate.c b/target/arm/translate.c
index 6259064ea7c..7f0154194cf 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -10590,7 +10590,7 @@ static bool trans_CPS(DisasContext *s, arg_CPS *a)
 
 static bool trans_CPS_v7m(DisasContext *s, arg_CPS_v7m *a)
 {
-    TCGv_i32 tmp, addr;
+    TCGv_i32 tmp, addr, el;
 
     if (!arm_dc_feature(s, ARM_FEATURE_M)) {
         return false;
@@ -10613,6 +10613,9 @@ static bool trans_CPS_v7m(DisasContext *s, arg_CPS_v7m *a)
         gen_helper_v7m_msr(cpu_env, addr, tmp);
         tcg_temp_free_i32(addr);
     }
+    el = tcg_const_i32(s->current_el);
+    gen_helper_rebuild_hflags_m32(cpu_env, el);
+    tcg_temp_free_i32(el);
     tcg_temp_free_i32(tmp);
     gen_lookup_tb(s);
     return true;
-- 
2.20.1



  parent reply	other threads:[~2020-03-12 16:46 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 16:44 [PULL 00/36] target-arm queue Peter Maydell
2020-03-12 16:44 ` [PULL 01/36] hw/intc/armv7m_nvic: Rebuild hflags on reset Peter Maydell
2020-03-12 16:44 ` Peter Maydell [this message]
2020-03-12 16:44 ` [PULL 03/36] target/arm: Recalculate hflags correctly after writes to CONTROL Peter Maydell
2020-03-12 16:44 ` [PULL 04/36] target/arm: Fix some comment typos Peter Maydell
2020-03-12 16:44 ` [PULL 05/36] aspeed/smc: Add some tracing Peter Maydell
2020-03-12 16:44 ` [PULL 06/36] aspeed/smc: Fix User mode select/unselect scheme Peter Maydell
2020-03-12 16:44 ` [PULL 07/36] target/arm: Check addresses for disabled regimes Peter Maydell
2020-03-12 16:44 ` [PULL 08/36] target/arm: Disable clean_data_tbi for system mode Peter Maydell
2020-03-12 16:44 ` [PULL 09/36] hw/arm/cubieboard: make sure SOC object isn't leaked Peter Maydell
2020-03-12 16:44 ` [PULL 10/36] hw/arm/fsl-imx25: Wire up eSDHC controllers Peter Maydell
2020-03-12 16:44 ` [PULL 11/36] hw/arm/fsl-imx25: Wire up USB controllers Peter Maydell
2020-03-12 16:44 ` [PULL 12/36] hw/arm: add Allwinner H3 System-on-Chip Peter Maydell
2020-03-12 16:44 ` [PULL 13/36] hw/arm: add Xunlong Orange Pi PC machine Peter Maydell
2020-03-12 16:44 ` [PULL 14/36] hw/arm/allwinner-h3: add Clock Control Unit Peter Maydell
2020-03-12 16:44 ` [PULL 15/36] hw/arm/allwinner-h3: add USB host controller Peter Maydell
2020-03-12 16:44 ` [PULL 16/36] hw/arm/allwinner-h3: add System Control module Peter Maydell
2020-03-12 16:44 ` [PULL 17/36] hw/arm/allwinner: add CPU Configuration module Peter Maydell
2020-03-12 16:44 ` [PULL 18/36] hw/arm/allwinner: add Security Identifier device Peter Maydell
2020-03-12 16:44 ` [PULL 19/36] hw/arm/allwinner: add SD/MMC host controller Peter Maydell
2020-03-12 16:44 ` [PULL 20/36] hw/arm/allwinner-h3: add EMAC ethernet device Peter Maydell
2020-03-12 16:44 ` [PULL 21/36] hw/arm/allwinner-h3: add Boot ROM support Peter Maydell
2020-03-20 12:07   ` Peter Maydell
2020-03-21 17:17     ` Niek Linnenbank
2020-03-21 19:47       ` Peter Maydell
2020-03-12 16:44 ` [PULL 22/36] hw/arm/allwinner-h3: add SDRAM controller device Peter Maydell
2020-03-20 15:46   ` Peter Maydell
2020-03-22 20:23     ` Niek Linnenbank
2020-03-22 21:17       ` Peter Maydell
2020-03-12 16:44 ` [PULL 23/36] hw/arm/allwinner: add RTC device support Peter Maydell
2020-03-12 16:44 ` [PULL 24/36] tests/boot_linux_console: Add a quick test for the OrangePi PC board Peter Maydell
2020-03-12 16:44 ` [PULL 25/36] tests/boot_linux_console: Add initrd test for the Orange Pi " Peter Maydell
2020-03-12 16:44 ` [PULL 26/36] tests/boot_linux_console: Add a SD card test for the OrangePi " Peter Maydell
2020-03-12 16:44 ` [PULL 27/36] tests/boot_linux_console: Add a SLOW test booting Ubuntu on OrangePi PC Peter Maydell
2020-03-12 16:44 ` [PULL 28/36] tests/boot_linux_console: Test booting NetBSD via U-Boot " Peter Maydell
2020-03-12 16:44 ` [PULL 29/36] docs: add Orange Pi PC document Peter Maydell
2020-03-12 16:44 ` [PULL 30/36] hw/arm/virt: Document 'max' value in gic-version property description Peter Maydell
2020-03-12 16:44 ` [PULL 31/36] hw/arm/virt: Introduce VirtGICType enum type Peter Maydell
2020-03-12 16:44 ` [PULL 32/36] hw/arm/virt: Introduce finalize_gic_version() Peter Maydell
2020-03-12 16:44 ` [PULL 33/36] target/arm/kvm: Let kvm_arm_vgic_probe() return a bitmap Peter Maydell
2020-03-12 16:44 ` [PULL 34/36] hw/arm/virt: kvm: Restructure finalize_gic_version() Peter Maydell
2020-03-12 16:44 ` [PULL 35/36] hw/arm/virt: kvm: allow gicv3 by default if v2 cannot work Peter Maydell
2020-03-12 16:44 ` [PULL 36/36] target/arm: kvm: Inject events at the last stage of sync Peter Maydell
2020-03-12 20:32 ` [PULL 00/36] target-arm queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312164459.25924-3-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).