From: Igor Mammedov <imammedo@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
Elad Gabay <elad.gabay@oracle.com>,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)
Date: Fri, 13 Mar 2020 11:05:16 +0100 [thread overview]
Message-ID: <20200313110516.6f4ca2b2@redhat.com> (raw)
In-Reply-To: <8b3f3166-cc60-eae2-c20d-ad4a593c3e30@oracle.com>
On Thu, 12 Mar 2020 19:28:31 +0200
Liran Alon <liran.alon@oracle.com> wrote:
> On 12/03/2020 18:27, Igor Mammedov wrote:
> > On Wed, 11 Mar 2020 19:08:26 +0200
> > Liran Alon <liran.alon@oracle.com> wrote:
> >> +
[...]
> > we typically do not version ACPI table changes (there might be exceptions
> > but it should be a justified one).
> > ACPI tables are considered to be a part of firmware (even though they are
> > generated by QEMU) so on QEMU upgrade user gets a new firmware along with
> > new ACPI tables.
>
> Hmm... I would have expected as a QEMU user that upgrading QEMU may
> update my firmware exposed table (Such as ACPI),
> but only if I don't specify I wish to run on a specific machine-type. In
> that case, I would've expect to be exposed with exact same firmware
> information.
That would be ideal but it's not the case with current QEMU, even with
specific machine type user will get new firmware when it's started with
upgraded QEMU which usually ships with new firmware.
mgmt layer theoretically can take care of maintaining different firmwares
on host and explicitly specify which should be used (though I'm not aware
of any doing it)
another issue with adding flags consistently for every acpi related
change would complicate code quite a bit making it hard to read/maintain,
hence flags are used only when we have to introduce them (i.e when it
would break guest).
> I understood that this was one of the main reasons why ACPI/SMBIOS
> generation was moved from SeaBIOS to QEMU.
If I recall correctly, Michael moved table to QEMU so we won't have to
extend ABI for constantly growing ACPI interface and then maintain it
forever, which indeed would require using compat machinery for every
knob (which is unsustainable).
[...]
next prev parent reply other threads:[~2020-03-13 10:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 17:08 [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET) Liran Alon
2020-03-11 18:59 ` no-reply
2020-03-11 19:08 ` Liran Alon
2020-03-11 20:24 ` Michael S. Tsirkin
2020-03-12 1:31 ` Liran Alon
2020-03-12 6:27 ` Michael S. Tsirkin
2020-03-11 19:00 ` no-reply
2020-03-11 20:36 ` Michael S. Tsirkin
2020-03-11 23:20 ` Liran Alon
2020-03-12 6:12 ` Michael S. Tsirkin
2020-03-12 11:30 ` Liran Alon
2020-03-12 12:19 ` Michael S. Tsirkin
2020-03-12 12:55 ` Liran Alon
2020-03-12 16:35 ` Igor Mammedov
2020-03-12 18:48 ` Liran Alon
2020-03-13 9:35 ` Igor Mammedov
2020-03-12 16:27 ` Igor Mammedov
2020-03-12 17:09 ` Michael S. Tsirkin
2020-03-13 9:36 ` Igor Mammedov
2020-03-13 15:26 ` Michael S. Tsirkin
2020-03-16 13:26 ` Igor Mammedov
2020-03-12 17:28 ` Liran Alon
2020-03-12 19:47 ` Michael S. Tsirkin
2020-03-12 21:17 ` Liran Alon
2020-03-13 10:05 ` Igor Mammedov [this message]
2020-03-13 14:23 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313110516.6f4ca2b2@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=elad.gabay@oracle.com \
--cc=liran.alon@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).