From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] tools/virtiofsd: add support for --socket-group
Date: Sat, 14 Mar 2020 13:25:08 +0000 [thread overview]
Message-ID: <20200314132508.GC313613@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200312104142.21259-1-alex.bennee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Thu, Mar 12, 2020 at 10:41:42AM +0000, Alex Bennée wrote:
> If you like running QEMU as a normal user (very common for TCG runs)
> but you have to run virtiofsd as a root user you run into connection
> problems. Adding support for an optional --socket-group allows the
> users to keep using the command line.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
> v1
> - tweak documentation and commentary
> ---
> docs/tools/virtiofsd.rst | 4 ++++
> tools/virtiofsd/fuse_i.h | 1 +
> tools/virtiofsd/fuse_lowlevel.c | 6 ++++++
> tools/virtiofsd/fuse_virtio.c | 20 ++++++++++++++++++--
> 4 files changed, 29 insertions(+), 2 deletions(-)
Dan's suggestion sounds like a good idea to me.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-14 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 10:41 [PATCH] tools/virtiofsd: add support for --socket-group Alex Bennée
2020-03-12 10:49 ` Daniel P. Berrangé
2020-03-14 13:33 ` Marc-André Lureau
2020-03-16 10:33 ` Daniel P. Berrangé
2020-03-17 9:54 ` Stefan Hajnoczi
2020-03-17 18:47 ` Dr. David Alan Gilbert
2020-03-17 23:21 ` Alex Bennée
2020-03-17 23:54 ` Marc-André Lureau
2020-03-14 13:25 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314132508.GC313613@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).