From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH 09/13] target/rx: Use prt_ldmi for XCHG_mr disassembly
Date: Sun, 15 Mar 2020 14:28:05 +0100 [thread overview]
Message-ID: <20200315132810.7022-10-f4bug@amsat.org> (raw)
In-Reply-To: <20200315132810.7022-1-f4bug@amsat.org>
From: Richard Henderson <richard.henderson@linaro.org>
Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190531134315.4109-21-richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/rx/disas.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/target/rx/disas.c b/target/rx/disas.c
index 0c4115669d..a0c444020c 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)
/* xchg dsp[rs].<mi>,rd */
static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
{
- static const char msize[][4] = {
- "b", "w", "l", "ub", "uw",
- };
- char dsp[8];
-
- rx_index_addr(ctx, dsp, a->ld, a->mi);
- prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
+ prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
return true;
}
--
2.21.1
next prev parent reply other threads:[~2020-03-15 13:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 13:27 [PATCH 00/13] target: Add Renesas RX architecture Philippe Mathieu-Daudé
2020-03-15 13:27 ` [PATCH 01/13] hw/registerfields.h: Add 8bit and 16bit register macros Philippe Mathieu-Daudé
2020-03-15 13:27 ` [PATCH 02/13] MAINTAINERS: Cover Renesas RX architecture Philippe Mathieu-Daudé
2020-03-15 13:27 ` [PATCH 03/13] target/rx: TCG translation Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 04/13] target/rx: TCG helpers Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 05/13] target/rx: CPU definitions Philippe Mathieu-Daudé
2020-03-15 15:42 ` Philippe Mathieu-Daudé
2020-03-16 5:28 ` Yoshinori Sato
2020-03-15 22:48 ` Richard Henderson
2020-03-15 13:28 ` [PATCH 06/13] target/rx: RX disassembler Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 07/13] target/rx: Disassemble rx_index_addr into a string Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 08/13] target/rx: Replace operand with prt_ldmi in disassembler Philippe Mathieu-Daudé
2020-03-15 13:28 ` Philippe Mathieu-Daudé [this message]
2020-03-15 13:28 ` [PATCH 10/13] target/rx: Emit all disassembly in one prt() Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 11/13] target/rx: Collect all bytes during disassembly Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 12/13] target/rx: Dump bytes for each insn " Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 13/13] Add rx-softmmu Philippe Mathieu-Daudé
2020-03-15 14:34 ` [PATCH 00/13] target: Add Renesas RX architecture no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315132810.7022-10-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).