qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH 12/13] target/rx: Dump bytes for each insn during disassembly
Date: Sun, 15 Mar 2020 14:28:08 +0100	[thread overview]
Message-ID: <20200315132810.7022-13-f4bug@amsat.org> (raw)
In-Reply-To: <20200315132810.7022-1-f4bug@amsat.org>

From: Richard Henderson <richard.henderson@linaro.org>

There are so many different forms of each RX instruction
that it will be very useful to be able to look at the bytes
to see on which path a bug may lie.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190531134315.4109-24-richard.henderson@linaro.org>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/rx/disas.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/target/rx/disas.c b/target/rx/disas.c
index dcfb7baf99..6dee7a0342 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d)
 /* Include the auto-generated decoder.  */
 #include "decode.inc.c"
 
-#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__)
+static void dump_bytes(DisasContext *ctx)
+{
+    int i, len = ctx->len;
+
+    for (i = 0; i < len; ++i) {
+        ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]);
+    }
+    ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t');
+}
+
+#define prt(...) \
+    do {                                                        \
+        dump_bytes(ctx);                                        \
+        ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__);  \
+    } while (0)
 
 #define RX_MEMORY_BYTE 0
 #define RX_MEMORY_WORD 1
-- 
2.21.1



  parent reply	other threads:[~2020-03-15 13:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 13:27 [PATCH 00/13] target: Add Renesas RX architecture Philippe Mathieu-Daudé
2020-03-15 13:27 ` [PATCH 01/13] hw/registerfields.h: Add 8bit and 16bit register macros Philippe Mathieu-Daudé
2020-03-15 13:27 ` [PATCH 02/13] MAINTAINERS: Cover Renesas RX architecture Philippe Mathieu-Daudé
2020-03-15 13:27 ` [PATCH 03/13] target/rx: TCG translation Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 04/13] target/rx: TCG helpers Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 05/13] target/rx: CPU definitions Philippe Mathieu-Daudé
2020-03-15 15:42   ` Philippe Mathieu-Daudé
2020-03-16  5:28     ` Yoshinori Sato
2020-03-15 22:48   ` Richard Henderson
2020-03-15 13:28 ` [PATCH 06/13] target/rx: RX disassembler Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 07/13] target/rx: Disassemble rx_index_addr into a string Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 08/13] target/rx: Replace operand with prt_ldmi in disassembler Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 09/13] target/rx: Use prt_ldmi for XCHG_mr disassembly Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 10/13] target/rx: Emit all disassembly in one prt() Philippe Mathieu-Daudé
2020-03-15 13:28 ` [PATCH 11/13] target/rx: Collect all bytes during disassembly Philippe Mathieu-Daudé
2020-03-15 13:28 ` Philippe Mathieu-Daudé [this message]
2020-03-15 13:28 ` [PATCH 13/13] Add rx-softmmu Philippe Mathieu-Daudé
2020-03-15 14:34 ` [PATCH 00/13] target: Add Renesas RX architecture no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315132810.7022-13-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).