From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 3/9] hw/core/qdev-properties: Fix code style
Date: Mon, 16 Mar 2020 01:11:05 +0100 [thread overview]
Message-ID: <20200316001111.31004-4-philmd@redhat.com> (raw)
In-Reply-To: <20200316001111.31004-1-philmd@redhat.com>
We will soon move this code, fix its style to avoid checkpatch.pl
to complain.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/core/qdev-properties.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 0e4da655c1..8ef949e3bd 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -553,15 +553,15 @@ static void set_mac(Object *obj, Visitor *v, const char *name, void *opaque,
if (!qemu_isxdigit(str[pos])) {
goto inval;
}
- if (!qemu_isxdigit(str[pos+1])) {
+ if (!qemu_isxdigit(str[pos + 1])) {
goto inval;
}
if (i == 5) {
- if (str[pos+2] != '\0') {
+ if (str[pos + 2] != '\0') {
goto inval;
}
} else {
- if (str[pos+2] != ':' && str[pos+2] != '-') {
+ if (str[pos + 2] != ':' && str[pos + 2] != '-') {
goto inval;
}
}
@@ -767,8 +767,8 @@ static void set_blocksize(Object *obj, Visitor *v, const char *name,
/* We rely on power-of-2 blocksizes for bitmasks */
if ((value & (value - 1)) != 0) {
error_setg(errp,
- "Property %s.%s doesn't take value '%" PRId64 "', it's not a power of 2",
- dev->id ?: "", name, (int64_t)value);
+ "Property %s.%s doesn't take value '%" PRId64 "', "
+ "it's not a power of 2", dev->id ?: "", name, (int64_t)value);
return;
}
--
2.21.1
next prev parent reply other threads:[~2020-03-16 1:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 0:11 [PATCH v2 0/9] user-mode: Prune build dependencies (part 3) Philippe Mathieu-Daudé
2020-03-16 0:11 ` [PATCH v2 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler Philippe Mathieu-Daudé
2020-03-16 0:11 ` [PATCH v2 2/9] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr() Philippe Mathieu-Daudé
2020-03-16 18:39 ` Richard Henderson
2020-03-16 0:11 ` Philippe Mathieu-Daudé [this message]
2020-03-16 0:11 ` [PATCH v2 4/9] hw/core/qdev-properties: Export enum-related functions Philippe Mathieu-Daudé
2020-03-16 0:11 ` [PATCH v2 5/9] hw/core/qdev-properties: Export qdev_prop_enum Philippe Mathieu-Daudé
2020-03-16 0:11 ` [PATCH v2 6/9] hw/core/qdev-properties: Export some integer-related functions Philippe Mathieu-Daudé
2020-03-16 0:11 ` [PATCH v2 7/9] hw/core/qdev-properties: Extract system-mode specific properties Philippe Mathieu-Daudé
2020-03-16 0:11 ` [PATCH v2 8/9] hw/core: Add qdev stub for user-mode Philippe Mathieu-Daudé
2020-03-16 18:56 ` Richard Henderson
2020-03-16 0:11 ` [PATCH v2 9/9] qapi: Restrict code generated " Philippe Mathieu-Daudé
2020-03-18 8:25 ` [PATCH v2 0/9] user-mode: Prune build dependencies (part 3) Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316001111.31004-4-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).