From: Gerd Hoffmann <kraxel@redhat.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function
Date: Mon, 16 Mar 2020 12:40:07 +0100 [thread overview]
Message-ID: <20200316114007.a4aie3vszsplkttq@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200312125524.7812-2-jandryuk@gmail.com>
Hi,
> + if (len > s->recv_used)
> + len = s->recv_used;
scripts/checkpatch.pl flags a codestyle error here.
> - if (len > s->recv_used)
> - len = s->recv_used;
Which is strictly speaking not your fault as you are just moving around
existing code. It's common practice though that codestyle is fixed up
too when touching code. Any chance you can make sure the patches pass
checkpatch & resend?
thanks,
Gerd
next prev parent reply other threads:[~2020-03-16 13:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 12:55 [PATCH 0/4] usb-serial: xHCI and timeout fixes Jason Andryuk
2020-03-12 12:55 ` [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function Jason Andryuk
2020-03-13 23:56 ` Samuel Thibault
2020-03-16 11:40 ` Gerd Hoffmann [this message]
2020-03-16 12:05 ` Jason Andryuk
2020-03-12 12:55 ` [PATCH 2/4] usb-serial: chunk data to wMaxPacketSize Jason Andryuk
2020-03-14 0:07 ` Samuel Thibault
2020-03-12 12:55 ` [PATCH 3/4] usb-serial: Increase receive buffer to 496 Jason Andryuk
2020-03-14 21:40 ` Samuel Thibault
2020-03-12 12:55 ` [PATCH 4/4] usb-serial: Fix timeout closing the device Jason Andryuk
2020-03-14 21:41 ` Samuel Thibault
2020-03-12 13:14 ` [PATCH 0/4] usb-serial: xHCI and timeout fixes no-reply
2020-03-12 13:31 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316114007.a4aie3vszsplkttq@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jandryuk@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).