From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: [PATCH v1 17/28] target/arm: default SVE length to 64 bytes for linux-user
Date: Mon, 16 Mar 2020 17:21:44 +0000 [thread overview]
Message-ID: <20200316172155.971-18-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200316172155.971-1-alex.bennee@linaro.org>
The Linux kernel chooses the default of 64 bytes for SVE registers on
the basis that it is the largest size on known hardware that won't
grow the signal frame. We still honour the sve-max-vq property and
userspace can expand the number of lanes by calling PR_SVE_SET_VL.
This should not make any difference to SVE enabled software as the SVE
is of course vector length agnostic.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
v2
- tweak zcr_el[1] instead
v7
- better form
---
target/arm/cpu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 3623ecefbd9..0909ce86a12 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -195,9 +195,10 @@ static void arm_cpu_reset(CPUState *s)
env->cp15.cpacr_el1 = deposit64(env->cp15.cpacr_el1, 20, 2, 3);
/* and to the SVE instructions */
env->cp15.cpacr_el1 = deposit64(env->cp15.cpacr_el1, 16, 2, 3);
- /* with maximum vector length */
- env->vfp.zcr_el[1] = cpu_isar_feature(aa64_sve, cpu) ?
- cpu->sve_max_vq - 1 : 0;
+ /* with reasonable vector length */
+ if (cpu_isar_feature(aa64_sve, cpu)) {
+ env->vfp.zcr_el[1] = MIN(cpu->sve_max_vq - 1, 3);
+ }
/*
* Enable TBI0 and TBI1. While the real kernel only enables TBI0,
* turning on both here will produce smaller code and otherwise
--
2.20.1
next prev parent reply other threads:[~2020-03-16 18:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:21 [PATCH v1 00/28 for 5.0] testing and gdbstub Alex Bennée
2020-03-16 17:21 ` [PATCH v1 01/28] tests/docker: Install tools to cross-debug and build Linux kernels Alex Bennée
2020-03-16 17:21 ` [PATCH v1 02/28] tests/docker: Update VirGL git repository URL Alex Bennée
2020-03-16 17:21 ` [PATCH v1 03/28] tests/docker: Remove obsolete VirGL --with-glx configure option Alex Bennée
2020-03-16 17:21 ` [PATCH v1 04/28] tests/docker: Update VirGL to v0.8.0 Alex Bennée
2020-03-16 17:21 ` [PATCH v1 05/28] travis.yml: Set G_MESSAGES_DEBUG do report GLib errors Alex Bennée
2020-03-16 17:21 ` [PATCH v1 06/28] gdbstub: make GDBState static and have common init function Alex Bennée
2020-03-16 17:21 ` [PATCH v1 07/28] gdbstub: stop passing GDBState * around and use global Alex Bennée
2020-03-16 17:21 ` [PATCH v1 08/28] gdbstub: move str_buf to GDBState and use GString Alex Bennée
2020-03-16 17:21 ` [PATCH v1 09/28] gdbstub: move mem_buf to GDBState and use GByteArray Alex Bennée
2020-03-16 17:21 ` [PATCH v1 10/28] gdbstub: add helper for 128 bit registers Alex Bennée
2020-03-16 17:21 ` [PATCH v1 11/28] target/arm: use gdb_get_reg helpers Alex Bennée
2020-03-16 17:21 ` [PATCH v1 12/28] target/m68k: " Alex Bennée
2020-03-17 9:48 ` Philippe Mathieu-Daudé
2020-03-16 17:21 ` [PATCH v1 13/28] target/i386: " Alex Bennée
2020-03-17 9:53 ` Philippe Mathieu-Daudé
2020-03-17 10:05 ` Philippe Mathieu-Daudé
2020-03-16 17:21 ` [PATCH v1 14/28] gdbstub: extend GByteArray to read register helpers Alex Bennée
2020-03-16 17:21 ` [PATCH v1 15/28] target/arm: prepare for multiple dynamic XMLs Alex Bennée
2020-03-16 17:21 ` [PATCH v1 16/28] target/arm: explicitly encode regnum in our XML Alex Bennée
2020-03-16 17:21 ` Alex Bennée [this message]
2020-03-16 17:21 ` [PATCH v1 18/28] target/arm: generate xml description of our SVE registers Alex Bennée
2020-03-16 17:21 ` [PATCH v1 19/28] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY Alex Bennée
2020-03-17 9:56 ` Philippe Mathieu-Daudé
2020-03-16 17:21 ` [PATCH v1 20/28] tests/tcg/aarch64: userspace system register test Alex Bennée
2020-03-17 10:24 ` Philippe Mathieu-Daudé
2020-03-17 11:03 ` Alex Bennée
2020-03-17 11:43 ` Philippe Mathieu-Daudé
2020-03-16 17:21 ` [PATCH v1 21/28] configure: allow user to specify what gdb to use Alex Bennée
2020-03-16 18:27 ` Peter Maydell
2020-03-17 9:46 ` Alex Bennée
2020-03-16 17:21 ` [PATCH v1 22/28] tests/guest-debug: add a simple test runner Alex Bennée
2020-03-17 10:30 ` Philippe Mathieu-Daudé
2020-03-16 17:21 ` [PATCH v1 23/28] tests/tcg/aarch64: add a gdbstub testcase for SVE registers Alex Bennée
2020-03-17 10:30 ` Philippe Mathieu-Daudé
2020-03-16 17:21 ` [PATCH v1 24/28] tests/tcg/aarch64: add SVE iotcl test Alex Bennée
2020-03-17 10:29 ` Philippe Mathieu-Daudé
2020-03-17 10:45 ` Aleksandar Markovic
2020-03-17 10:49 ` Peter Maydell
2020-03-17 13:57 ` Alex Bennée
2020-03-17 13:40 ` Aleksandar Markovic
2020-03-16 17:21 ` [PATCH v1 25/28] tests/tcg/aarch64: add test-sve-ioctl guest-debug test Alex Bennée
2020-03-16 17:21 ` [PATCH v1 26/28] gdbstub: change GDBState.last_packet to GByteArray Alex Bennée
2020-03-16 17:21 ` [PATCH v1 27/28] gdbstub: do not split gdb_monitor_write payload Alex Bennée
2020-03-16 17:21 ` [PATCH v1 28/28] gdbstub: Fix single-step issue by confirming 'vContSupported+' feature to gdb Alex Bennée
2020-03-16 21:26 ` [PATCH v1 00/28 for 5.0] testing and gdbstub no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316172155.971-18-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).