From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337E7C18E5B for ; Mon, 16 Mar 2020 19:16:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF74920674 for ; Mon, 16 Mar 2020 19:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SQoGRtMs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF74920674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDvDT-0002Iw-45 for qemu-devel@archiver.kernel.org; Mon, 16 Mar 2020 15:15:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39142) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDupn-00016g-57 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 14:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDupm-0007xj-5w for qemu-devel@nongnu.org; Mon, 16 Mar 2020 14:51:31 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:51561) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDupm-0007vu-25 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 14:51:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584384689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MiaNZR/YFUXbUQr2CW30itYe2jJLit5uoKbrlDDb9zo=; b=SQoGRtMsrJ0g7O4DZFLQ0PvxUXlmgKsJ4lx9Rk3hUikQXje0mMKfd6AN7PFkS+eQRDwbQn MPqKFaIrjMDeCAspRCESJPRURhFFfczloRDM3nxOYr5mVApC/A9ufT/rMSLsNeukDMnhah VJMPpZFUP1HFN06ksPe025kFt2JH8Xw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-kan1FIFhP5OOSycRvFGzqg-1; Mon, 16 Mar 2020 14:51:27 -0400 X-MC-Unique: kan1FIFhP5OOSycRvFGzqg-1 Received: by mail-wr1-f72.google.com with SMTP id p2so6924560wrw.8 for ; Mon, 16 Mar 2020 11:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fr7tR+uE5gurF7jZCvxXMmjEzQ0XGdfWsIrKdvCDUxM=; b=GtYKxgrOgbNqLUYR6cvXPCAUfoi7f37T60SlbngBb22bFZRVHored9gSQt5jC/OT3Z PNFb8Jx91TReS7PkKsLHgxbAxJLciWEhqbDdPRRw9wN9PFfi0VZ+Sn9skKXhhsegM5u9 VA7wKLLHGtlPc0Y7HI+QbKkzOcZcIKkqX/1vooLV4KTGiCsEBCYFe3YGvLgDVaO8ltSB pfZKggjGmT0DzkrK5jaT9yc+nhbGV34q1r6Y5wvreD83exRexofjZppTiupBlQy3ZmhK OHrescqbt9I+qxJjcuiYRX10vFt05+Yoq6oSpr0qzTKnnvgtez6jbqYPkXLcWyEFeEeH p07Q== X-Gm-Message-State: ANhLgQ2OsiiYi3EQqAffUOYmNfHEit/abcvsvhJYLZmPlV9IoDdfgPYE 9SASMb0ugNdm0dB5ko/orxGlKmziGgDL+kZ9PljbemUe1xxfyYo+dJRuGF24YeQj4yy0eoTz0pv GqcuwLwIYTdUsSSY= X-Received: by 2002:adf:82f7:: with SMTP id 110mr709004wrc.373.1584384686655; Mon, 16 Mar 2020 11:51:26 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs//rpAiK+xC5iYw0T7Oh1sadDsQ7K/U2GlCCkhy1nMZWCWbX1KSDGH9bvtWb4oYVJO/F2Vcw== X-Received: by 2002:adf:82f7:: with SMTP id 110mr708995wrc.373.1584384686494; Mon, 16 Mar 2020 11:51:26 -0700 (PDT) Received: from localhost.localdomain (96.red-83-59-163.dynamicip.rima-tde.net. [83.59.163.96]) by smtp.gmail.com with ESMTPSA id r28sm1158066wra.16.2020.03.16.11.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 11:51:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , qemu-devel@nongnu.org Subject: [PATCH v3 15/25] scripts/cocci: Patch to remove unnecessary memory_region_set_readonly() Date: Mon, 16 Mar 2020 19:49:56 +0100 Message-Id: <20200316185006.576-16-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200316185006.576-1-philmd@redhat.com> References: <20200316185006.576-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Add a semantic patch to remove memory_region_set_readonly() calls on ROM memory regions. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .../coccinelle/memory-region-housekeeping.cocci | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/scripts/coccinelle/memory-region-housekeeping.cocci b/scripts/= coccinelle/memory-region-housekeeping.cocci index 9cdde71bb1..5e6b31d8ba 100644 --- a/scripts/coccinelle/memory-region-housekeeping.cocci +++ b/scripts/coccinelle/memory-region-housekeeping.cocci @@ -48,6 +48,21 @@ p << possible_memory_region_init_rom.p; cocci.print_main("potential use of memory_region_init_rom*() in ", p) =20 =20 +// Do not call memory_region_set_readonly() on ROM alias +@@ +expression ROM, E1, E2, E3, E4; +expression ALIAS, E5, E6, E7, E8; +@@ +( + memory_region_init_rom(ROM, E1, E2, E3, E4); +| + memory_region_init_rom_nomigrate(ROM, E1, E2, E3, E4); +) + ... + memory_region_init_alias(ALIAS, E5, E6, ROM, E7, E8); +- memory_region_set_readonly(ALIAS, true); + + // Replace by-hand memory_region_init_ram_nomigrate/vmstate_register_ram // code sequences with use of the new memory_region_init_ram function. // Similarly for the _rom and _rom_device functions. --=20 2.21.1