From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BCCC10F29 for ; Tue, 17 Mar 2020 06:29:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68A5C20674 for ; Tue, 17 Mar 2020 06:29:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KqfdIQDV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68A5C20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE5jJ-0007ty-Ho for qemu-devel@archiver.kernel.org; Tue, 17 Mar 2020 02:29:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46255) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE5ig-0007N3-Ho for qemu-devel@nongnu.org; Tue, 17 Mar 2020 02:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE5if-0008WC-1m for qemu-devel@nongnu.org; Tue, 17 Mar 2020 02:28:54 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:44125) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jE5ie-0008NP-SO for qemu-devel@nongnu.org; Tue, 17 Mar 2020 02:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584426532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAD2MnMEfNsUlILMsE2Zh0k4hzdlA5hqxyWu+I3e8yA=; b=KqfdIQDVAospaThVrS4Ai1vqG3BlsMZsKsPC4T+jQGomWZxvQNjBYNIkfCiMTM3jXs0kMy YEoz6qqaO1F2WY3VVKnvG1vRO3Nxy+4Vvue7/ih0Gv23FZOPNMD/RAdurW9wtQ4UFVjSqB vQJa/kIJYIjpvgdkWNB6MaBJnVtGEGk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-ulEBHaCbMbSmuXuDIy9TLA-1; Tue, 17 Mar 2020 02:28:48 -0400 X-MC-Unique: ulEBHaCbMbSmuXuDIy9TLA-1 Received: by mail-wm1-f70.google.com with SMTP id y7so6721115wmd.4 for ; Mon, 16 Mar 2020 23:28:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bi+yrwbJme6Ru0T91P3OQcdiOiROgObE8J75lYvhAnY=; b=LIqmb9c2abaLKUXHLftIxsqFW/L8D66nSdyAMxoZcNU/w3omkn3FGrbRw6P5wbYk1w H3FFjXN2GyZ1X3HTQLugfRShz6EVgwRWHThMk/hIubaGIasIXXikue0UEGQVfV3hjIRu GTTA+ZIY4P2Z4rBRoEeEwVsHJWyeGBym1uTPjYNlWb2mbz40kp1lwmvpcqtAjHS1RCRF Gxt8JEwBXmzJ+fREI/oyxmeuhQ06unuerOCBzrpejvztsFgpWdweHMfJexZZM8Mgx0GS 3eoA7+F6tCFv69s/WLW3rJme2yE8KJb1JzniwWPlLWQVaBCzRuTe9z7kmrHUPYlj2DQ9 3EGg== X-Gm-Message-State: ANhLgQ3UymnZI1E//MTqm7Bine5jWIoo2GGPj3Zvqg0opRkviEHaU872 G/sbWYyBpdh7uv8+rjGpBHE5yJtWXinKTmQH/cFzOczg4pz5KGHbuf+NELjSWL1TpY0+IMKkwhl LMAHEzhjHznYxSw4= X-Received: by 2002:a1c:b60b:: with SMTP id g11mr3459193wmf.175.1584426526924; Mon, 16 Mar 2020 23:28:46 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvpjFouH0gjPekFW8Q8uc+ZAiCI2+iDmCus01fAcn7wjiX9RuW20E+TJ9R9ZcbCiLSJOCChuw== X-Received: by 2002:a1c:b60b:: with SMTP id g11mr3459168wmf.175.1584426526591; Mon, 16 Mar 2020 23:28:46 -0700 (PDT) Received: from redhat.com (bzq-109-67-31-208.red.bezeqint.net. [109.67.31.208]) by smtp.gmail.com with ESMTPSA id w19sm2622326wmi.0.2020.03.16.23.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 23:28:45 -0700 (PDT) Date: Tue, 17 Mar 2020 02:28:42 -0400 From: "Michael S. Tsirkin" To: Peter Xu Subject: Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM Message-ID: <20200317022707-mutt-send-email-mst@kernel.org> References: <20200226083654-mutt-send-email-mst@kernel.org> <20200226163618.31aa86ed.pasic@linux.ibm.com> <20200226115009-mutt-send-email-mst@kernel.org> <20200227140215.2d12149c.pasic@linux.ibm.com> <20200227104233-mutt-send-email-mst@kernel.org> <20200313134446.782c5f7c.pasic@linux.ibm.com> <20200313112902-mutt-send-email-mst@kernel.org> <20200313163122.GB95517@xz-x1> <20200316131723-mutt-send-email-mst@kernel.org> <20200316181405.GB184827@xz-x1> MIME-Version: 1.0 In-Reply-To: <20200316181405.GB184827@xz-x1> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , "Singh, Brijesh" , Jason Wang , qemu-devel@nongnu.org, qemu-stable@nongnu.org, Halil Pasic , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 16, 2020 at 02:14:05PM -0400, Peter Xu wrote: > On Mon, Mar 16, 2020 at 01:19:54PM -0400, Michael S. Tsirkin wrote: > > On Fri, Mar 13, 2020 at 12:31:22PM -0400, Peter Xu wrote: > > > On Fri, Mar 13, 2020 at 11:29:59AM -0400, Michael S. Tsirkin wrote: > > > > On Fri, Mar 13, 2020 at 01:44:46PM +0100, Halil Pasic wrote: > > > > > [..] > > > > > > >=20 > > > > > > > CCing Tom. @Tom does vhost-vsock work for you with SEV and cu= rrent qemu? > > > > > > >=20 > > > > > > > Also, one can specify iommu_platform=3Don on a device that ai= n't a part of > > > > > > > a secure-capable VM, just for the fun of it. And that breaks > > > > > > > vhost-vsock. Or is setting iommu_platform=3Don only valid if > > > > > > > qemu-system-s390x is protected virtualization capable? > > > > > > >=20 > > > > > > > BTW, I don't have a strong opinion on the fixes tag. We curre= ntly do not > > > > > > > recommend setting iommu_platform, and thus I don't think we c= are too > > > > > > > much about past qemus having problems with it. > > > > > > >=20 > > > > > > > Regards, > > > > > > > Halil > > > > > >=20 > > > > > >=20 > > > > > > Let's just say if we do have a Fixes: tag we want to set it cor= rectly to > > > > > > the commit that needs this fix. > > > > > >=20 > > > > >=20 > > > > > I finally did some digging regarding the performance degradation.= For > > > > > s390x the performance degradation on vhost-net was introduced by = commit > > > > > 076a93d797 ("exec: simplify address_space_get_iotlb_entry"). Befo= re > > > > > IOMMUTLBEntry.addr_mask used to be based on plen, which in turn w= as > > > > > calculated as the rest of the memory regions size (from address),= and > > > > > covered most of the guest address space. That is we didn't have a= whole > > > > > lot of IOTLB API overhead. > > > > >=20 > > > > > With commit 076a93d797 I see IOMMUTLBEntry.addr_mask =3D=3D 0xfff= which comes > > > > > as ~TARGET_PAGE_MASK from flatview_do_translate(). To have things= working > > > > > properly I applied 75e5b70e6, b021d1c044, and d542800d1e on the l= evel of > > > > > 076a93d797 and 076a93d797~1. > > > >=20 > > > > Peter, what's your take on this one? > > >=20 > > > Commit 076a93d797 was one of the patchset where we want to provide > > > sensible IOTLB entries and also that should start to work with huge > > > pages. > >=20 > > So the issue bundamentally is that it > > never produces entries larger than page size. > >=20 > > Wasteful even just with huge pages, all the more > > so which passthrough which could have giga-byte > > entries. > >=20 > > Want to try fixing that? >=20 > Yes we can fix that, but I'm still not sure whether changing the > interface of address_space_get_iotlb_entry() to cover adhoc regions is > a good idea, because I think it's still a memory core API and imho it > would still be good to have IOTLBs returned to be what the hardware > will be using (always page aligned IOTLBs). E.g. with virtio-iommu, there's no hardware in sight. Even with e.g. VTD page aligned does not mean TARGET_PAGE, can be much bigger. > Also it would still be > not ideal because vhost backend will still need to send the MISSING > messages and block for each of the continuous guest memory ranges > registered, so there will still be misterious delay. Not to say > logically all the caches can be invalidated too so in that sense I > think it's as hacky as the vhost speedup patch mentioned below.. >=20 > Ideally I think vhost should be able to know when PT is enabled or > disabled for the device, so the vhost backend (kernel or userspace) > should be able to directly use GPA for DMA. That might need some new > vhost interface. >=20 > For the s390's specific issue, I would think Jason's patch an simple > and ideal solution already. >=20 > Thanks, >=20 > >=20 > >=20 > > > Frankly speaking after a few years I forgot the original > > > motivation of that whole thing, but IIRC there's a patch that was > > > trying to speedup especially for vhost but I noticed it's not merged: > > >=20 > > > https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg00574.html > > >=20 > > > Regarding to the current patch, I'm not sure I understand it > > > correctly, but is that performance issue only happens when (1) there'= s > > > no intel-iommu device, and (2) there is iommu_platform=3Don specified > > > for the vhost backend? > > >=20 > > > If so, I'd confess I am not too surprised if this fails the boot with > > > vhost-vsock because after all we speicified iommu_platform=3Don > > > explicitly in the cmdline, so if we want it to work we can simply > > > remove that iommu_platform=3Don when vhost-vsock doesn't support it > > > yet... I thougth iommu_platform=3Don was added for that case - when = we > > > want to force IOMMU to be enabled from host side, and it should alway= s > > > be used with a vIOMMU device. > > >=20 > > > However I also agree that from performance POV this patch helps for > > > this quite special case. > > >=20 > > > Thanks, > > >=20 > > > --=20 > > > Peter Xu > >=20 >=20 > --=20 > Peter Xu