From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH v3 0/3] iotests: add JobRunner framework
Date: Tue, 17 Mar 2020 00:34:34 -0400 [thread overview]
Message-ID: <20200317043437.19464-1-jsnow@redhat.com> (raw)
Requires: 20200317004105.27059-1-jsnow@redhat.com
(This requires the iotests pylint & logging series.)
The basic idea is to make a generic job runtime manager and allow
callers to subclass the manager. Then, instead of adding callback
arguments to the function all the time, we have à la carte customization
of the loop.
To showcase this a little bit, I removed the pre_finalization argument
and made existing callers use a custom JobRunner; and then converted
test 040 to use this style of job runner.
Is it a simplification? No. Is it cool? Maybe. Did it remove the
duplicated job-running code in 040? yes.
V3:
- Rebased on logging series v8
- Converted 155's new usage of job_run
V2:
- Rebased on logging series; logging conditionals are pretty now.
- Inlined callback login in 257
- No longer based on bitmap-populate job (no test 287)
- Moved super() call to the beginning of test 040's callback
- Added docstrings and type annotations
John Snow (3):
qmp.py: change event_wait to use a dict
iotests: add JobRunner class
iotests: modify test 040 to use JobRunner
python/qemu/machine.py | 10 +-
tests/qemu-iotests/040 | 51 +++++----
tests/qemu-iotests/155 | 15 ++-
tests/qemu-iotests/255 | 9 +-
tests/qemu-iotests/257 | 54 +++++----
tests/qemu-iotests/260 | 5 +-
tests/qemu-iotests/iotests.py | 201 +++++++++++++++++++++++++---------
tests/qemu-iotests/pylintrc | 11 ++
8 files changed, 246 insertions(+), 110 deletions(-)
--
2.21.1
next reply other threads:[~2020-03-17 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 4:34 John Snow [this message]
2020-03-17 4:34 ` [PATCH v3 1/3] qmp.py: change event_wait to use a dict John Snow
2020-03-17 4:34 ` [PATCH v3 2/3] iotests: add JobRunner class John Snow
2020-03-17 4:34 ` [PATCH v3 3/3] iotests: modify test 040 to use JobRunner John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317043437.19464-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).