[PATCH] softmmu: fix crash with invalid -M memory-backend=

[PATCH] softmmu: fix crash with invalid -M memory-backend=

[Marc-André Lureau]

Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
ram_size matches size of machine.memory-backend")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 softmmu/vl.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/softmmu/vl.c b/softmmu/vl.c
index 5549f4b619..38e9c404f2 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -4287,6 +4287,11 @@ void qemu_init(int argc, char **argv, char **envp)
 
         backend = object_resolve_path_type(current_machine->ram_memdev_id,
                                            TYPE_MEMORY_BACKEND, NULL);
+        if (!backend) {
+            error_report("Memory backend '%s' not found",
+                         current_machine->ram_memdev_id);
+            exit(EXIT_FAILURE);
+        }
         backend_size = object_property_get_uint(backend, "size",  &error_abort);
         if (have_custom_ram_size && backend_size != ram_size) {
                 error_report("Size specified by -m option must match size of "
-- 
2.25.0.rc2.1.g09a9a1a997

Re: [PATCH] softmmu: fix crash with invalid -M memory-backend=

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200309145155.168942-1-marcandre.lureau@redhat.com/



Hi,

This series failed the docker-clang@ubuntu build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-ubuntu V=1 NETWORK=1
time make docker-test-clang@ubuntu SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  LINK    qemu-io
  LINK    qemu-edid
  LINK    fsdev/virtfs-proxy-helper
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    scsi/qemu-pr-helper
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    qemu-bridge-helper
  LINK    virtiofsd
  GEN     cris-softmmu/hmp-commands.h
---
  CC      mips-softmmu/qapi/qapi-events-machine-target.o
  CC      i386-softmmu/hw/xen/xen_pt_msi.o
  CC      mips64-softmmu/qapi/qapi-visit-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      aarch64-softmmu/hw/arm/virt.o
  CC      mips64el-softmmu/hw/display/virtio-gpu-base.o
  CC      mips-softmmu/qapi/qapi-events-misc-target.o
---
  CC      nios2-softmmu/exec-vary.o
  CC      aarch64-softmmu/hw/arm/xilinx_zynq.o
  CC      or1k-softmmu/tcg/tcg.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      i386-softmmu/hw/i386/kvm/i8259.o
  CC      nios2-softmmu/tcg/tcg.o
  CC      arm-softmmu/hw/arm/pxa2xx.o
---
  CC      mips64el-softmmu/qapi/qapi-types-misc-target.o
  CC      mipsel-softmmu/qapi/qapi-types-machine-target.o
  CC      mipsel-softmmu/qapi/qapi-types-misc-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      arm-softmmu/hw/arm/smmuv3.o
  CC      or1k-softmmu/qapi/qapi-types-machine-target.o
  CC      or1k-softmmu/qapi/qapi-types-misc-target.o
---
  CC      or1k-softmmu/qapi/qapi-visit-machine-target.o
  CC      or1k-softmmu/qapi/qapi-visit-misc-target.o
  CC      mips64el-softmmu/qapi/qapi-types.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      mipsel-softmmu/qapi/qapi-visit-machine-target.o
  CC      nios2-softmmu/hw/semihosting/config.o
  CC      nios2-softmmu/hw/semihosting/console.o
---
  GEN     ppc64-softmmu/config-target.h
  CC      i386-softmmu/trace/generated-helpers.o
  LINK    mips64el-softmmu/qemu-system-mips64el
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/exec.o
  GEN     arm-softmmu/target/arm/decode-a32-uncond.inc.c
  GEN     arm-softmmu/target/arm/decode-t32.inc.c
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  GEN     arm-softmmu/target/arm/decode-t16.inc.c
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/exec-vary.o
  CC      ppc64-softmmu/tcg/tcg.o
  CC      riscv64-softmmu/tcg/tcg.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc-softmmu/exec-vary.o
  CC      riscv32-softmmu/tcg/tcg-op.o
  CC      ppc-softmmu/tcg/tcg.o
---
  CC      riscv64-softmmu/tcg/tcg-op-gvec.o
  CC      aarch64-softmmu/target/arm/cpu64.o
  CC      riscv32-softmmu/tcg/tcg-op-vec.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/tcg/tcg-op.o
  CC      arm-softmmu/target/arm/crypto_helper.o
  CC      ppc-softmmu/tcg/tcg-op.o
---
  CC      sh4-softmmu/accel/stubs/hax-stub.o
  CC      sh4-softmmu/accel/stubs/hvf-stub.o
  CC      ppc64-softmmu/hw/display/vga.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  GEN     sparc64-softmmu/hmp-commands.h
  CC      riscv32-softmmu/hw/display/vga.o
  CC      sh4eb-softmmu/accel/stubs/whpx-stub.o
---
  CC      ppc64-softmmu/hw/ppc/spapr_rng.o
  CC      x86_64-softmmu/exec.o
  CC      riscv32-softmmu/softmmu/main.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      s390x-softmmu/hw/s390x/virtio-ccw-input.o
  CC      sparc64-softmmu/qapi/qapi-types-misc-target.o
  CC      riscv32-softmmu/gdbstub-xml.o
---
  CC      ppc64-softmmu/hw/ppc/spapr_rtas_ddw.o
  CC      s390x-softmmu/hw/s390x/s390-stattrib.o
  CC      sh4-softmmu/softmmu/main.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  GEN     x86_64-softmmu/gdbstub-xml.c
  CC      unicore32-softmmu/gdbstub.o
  CC      x86_64-softmmu/arch_init.o
---
  CC      x86_64-softmmu/gdbstub.o
  CC      s390x-softmmu/hw/s390x/s390-ccw.o
  CC      unicore32-softmmu/ioport.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      unicore32-softmmu/qtest.o
  LINK    sh4-softmmu/qemu-system-sh4
  CC      x86_64-softmmu/balloon.o
---
  CC      unicore32-softmmu/accel/tcg/tcg-runtime.o
  CC      x86_64-softmmu/accel/stubs/hvf-stub.o
  CC      s390x-softmmu/qapi/qapi-visit-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/hw/ppc/rs6000_mc.o
  CC      ppc-softmmu/target/ppc/kvm-stub.o
  CC      unicore32-softmmu/accel/tcg/tcg-runtime-gvec.o
  CC      ppc64-softmmu/hw/ppc/mac_oldworld.o
  CC      x86_64-softmmu/accel/stubs/whpx-stub.o
  CC      ppc-softmmu/target/ppc/dfp_helper.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      unicore32-softmmu/accel/tcg/cpu-exec.o
  CC      s390x-softmmu/qapi/qapi-visit-misc-target.o
  CC      ppc64-softmmu/hw/ppc/mac_newworld.o
---
  CC      x86_64-softmmu/hw/display/virtio-gpu-base.o
  CC      xtensaeb-softmmu/cpus.o
  CC      unicore32-softmmu/target/unicore32/translate.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      xtensa-softmmu/accel/stubs/whpx-stub.o
  GEN     alpha-linux-user/config-target.h
  GEN     aarch64-linux-user/config-target.h
---
  CC      s390x-softmmu/target/s390x/crypto_helper.o
  CC      alpha-linux-user/tcg/tcg-op.o
  CC      xtensaeb-softmmu/migration/ram.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      xtensa-softmmu/accel/tcg/cpu-exec.o
  CC      xtensa-softmmu/accel/tcg/cpu-exec-common.o
  CC      unicore32-softmmu/target/unicore32/ucf64_helper.o
---
  CC      xtensaeb-softmmu/accel/tcg/tcg-runtime.o
  CC      aarch64_be-linux-user/accel/stubs/hax-stub.o
  CC      xtensa-softmmu/hw/display/vga.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/target/ppc/mmu-book3s-v3.o
  CC      ppc64-softmmu/target/ppc/compat.o
  CC      ppc64-softmmu/target/ppc/mmu-radix64.o
---
  CC      aarch64_be-linux-user/linux-user/main.o
  CC      alpha-linux-user/accel/tcg/translate-all.o
  CC      aarch64-linux-user/linux-user/main.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      aarch64-linux-user/linux-user/syscall.o
  CC      xtensa-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      x86_64-softmmu/hw/vfio/spapr.o
---
  CC      alpha-linux-user/linux-user/syscall.o
  CC      xtensa-softmmu/hw/semihosting/config.o
  CC      xtensaeb-softmmu/hw/display/vga.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      xtensa-softmmu/hw/semihosting/console.o
  CC      aarch64-linux-user/linux-user/mmap.o
  CC      x86_64-softmmu/hw/vfio/display.o
---
  CC      xtensa-softmmu/hw/virtio/vhost-user-input-pci.o
  CC      aarch64_be-linux-user/linux-user/aarch64/signal.o
  CC      alpha-linux-user/linux-user/alpha/signal.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      x86_64-softmmu/hw/virtio/virtio-input-host-pci.o
  CC      arm-linux-user/thunk.o
  CC      aarch64-linux-user/linux-user/aarch64/cpu_loop.o
---
  CC      mips64-linux-user/tcg/optimize.o
  CC      mipsn32-linux-user/tcg/tcg-op-vec.o
  CC      microblaze-linux-user/linux-user/microblaze/cpu_loop.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      x86_64-softmmu/target/i386/mpx_helper.o
  CC      mipsn32el-linux-user/tcg/tcg-op-vec.o
  CC      mipsn32el-linux-user/tcg/tcg-op-gvec.o
---
  CC      mips64-linux-user/linux-user/mips64/signal.o
  CC      mips64el-linux-user/linux-user/syscall.o
  CC      mipsn32el-linux-user/linux-user/strace.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      mipsn32el-linux-user/linux-user/mmap.o
  CC      mipsn32el-linux-user/linux-user/signal.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      nios2-linux-user/accel/stubs/hax-stub.o
  CC      mipsn32-linux-user/linux-user/syscall.o
  CC      mipsel-linux-user/linux-user/uaccess.o
---
  LINK    tests/test-iov
  AR      libsoftfloat.a
  LINK    tests/test-bitmap
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-aio
  LINK    fp-test
  LINK    tests/test-aio-multithread
  LINK    tests/test-throttle
  LINK    tests/test-thread-pool
  LINK    tests/test-hbitmap
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-bdrv-drain
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-bdrv-graph-mod
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-blockjob
  LINK    tests/test-blockjob-txn
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-block-backend
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-block-iothread
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-image-locking
  LINK    tests/test-x86-cpuid
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-xbzrle
  LINK    tests/test-vmstate
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-cutils
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-shift128
  LINK    tests/test-mul64
  LINK    tests/test-int128
---
  LINK    tests/test-crypto-hmac
  LINK    tests/test-crypto-cipher
  LINK    tests/test-crypto-secret
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-crypto-tlscredsx509
  LINK    tests/test-crypto-tlssession
  LINK    tests/test-qga
---
  FLOAT TEST lt_quiet
  FLOAT TEST add
  FLOAT TEST sub
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  FLOAT TEST uint-to-float
  FLOAT TEST float-to-int
  FLOAT TEST mul
---
Looking for expected file 'tests/data/acpi/pc/DSDT.memhp'
Using expected file 'tests/data/acpi/pc/DSDT.memhp'
**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 8037
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-i386] Error 1
make: *** Waiting for unfinished jobs....
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: -accel kvm: failed to initialize kvm: No such file or directory
---
dbus-daemon[9479]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry

**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 9479
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
  TEST    check-qtest-arm: tests/qtest/qos-test
  TEST    check-qtest-aarch64: tests/qtest/test-hmp
  TEST    check-qtest-aarch64: tests/qtest/qos-test
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=db63572321d04ceb8f23298f45b4d250', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-je6p0etj/src/docker-src.2020-03-09-11.00.51.10739:/var/tmp/qemu:z,ro', 'qemu:ubuntu', '/var/tmp/qemu/run', 'test-clang']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=db63572321d04ceb8f23298f45b4d250
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-je6p0etj/src'
make: *** [docker-run-test-clang@ubuntu] Error 2

real    19m41.519s
user    0m9.495s


The full log is available at
http://patchew.org/logs/20200309145155.168942-1-marcandre.lureau@redhat.com/testing.docker-clang@ubuntu/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH] softmmu: fix crash with invalid -M memory-backend=

[Igor Mammedov]

On Mon,  9 Mar 2020 15:51:55 +0100
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:

> Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
> ram_size matches size of machine.memory-backend")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  softmmu/vl.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 5549f4b619..38e9c404f2 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -4287,6 +4287,11 @@ void qemu_init(int argc, char **argv, char **envp)
>  
>          backend = object_resolve_path_type(current_machine->ram_memdev_id,
>                                             TYPE_MEMORY_BACKEND, NULL);
> +        if (!backend) {
> +            error_report("Memory backend '%s' not found",
> +                         current_machine->ram_memdev_id);
> +            exit(EXIT_FAILURE);
> +        }
>          backend_size = object_property_get_uint(backend, "size",  &error_abort);
>          if (have_custom_ram_size && backend_size != ram_size) {
>                  error_report("Size specified by -m option must match size of "

Re: [PATCH] softmmu: fix crash with invalid -M memory-backend=

[Philippe Mathieu-Daudé]

On 3/9/20 3:51 PM, Marc-André Lureau wrote:
> Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
> ram_size matches size of machine.memory-backend")

<new line>

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   softmmu/vl.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 5549f4b619..38e9c404f2 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -4287,6 +4287,11 @@ void qemu_init(int argc, char **argv, char **envp)
>   
>           backend = object_resolve_path_type(current_machine->ram_memdev_id,
>                                              TYPE_MEMORY_BACKEND, NULL);
> +        if (!backend) {
> +            error_report("Memory backend '%s' not found",
> +                         current_machine->ram_memdev_id);
> +            exit(EXIT_FAILURE);
> +        }
>           backend_size = object_property_get_uint(backend, "size",  &error_abort);
>           if (have_custom_ram_size && backend_size != ram_size) {
>                   error_report("Size specified by -m option must match size of "
> 

Re: [PATCH] softmmu: fix crash with invalid -M memory-backend=

[Igor Mammedov]

On Mon,  9 Mar 2020 15:51:55 +0100
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:

> Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
> ram_size matches size of machine.memory-backend")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Paolo,

Can you pick up this patch for your pull req? 

> ---
>  softmmu/vl.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 5549f4b619..38e9c404f2 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -4287,6 +4287,11 @@ void qemu_init(int argc, char **argv, char **envp)
>  
>          backend = object_resolve_path_type(current_machine->ram_memdev_id,
>                                             TYPE_MEMORY_BACKEND, NULL);
> +        if (!backend) {
> +            error_report("Memory backend '%s' not found",
> +                         current_machine->ram_memdev_id);
> +            exit(EXIT_FAILURE);
> +        }
>          backend_size = object_property_get_uint(backend, "size",  &error_abort);
>          if (have_custom_ram_size && backend_size != ram_size) {
>                  error_report("Size specified by -m option must match size of "

Re: [PATCH] softmmu: fix crash with invalid -M memory-backend=

[Paolo Bonzini]

On 17/03/20 16:13, Igor Mammedov wrote:
> On Mon,  9 Mar 2020 15:51:55 +0100
> Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
> 
>> Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
>> ram_size matches size of machine.memory-backend")
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Paolo,
> 
> Can you pick up this patch for your pull req? 

I've done it already, but I can send more.

Paolo

>> ---
>>  softmmu/vl.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/softmmu/vl.c b/softmmu/vl.c
>> index 5549f4b619..38e9c404f2 100644
>> --- a/softmmu/vl.c
>> +++ b/softmmu/vl.c
>> @@ -4287,6 +4287,11 @@ void qemu_init(int argc, char **argv, char **envp)
>>  
>>          backend = object_resolve_path_type(current_machine->ram_memdev_id,
>>                                             TYPE_MEMORY_BACKEND, NULL);
>> +        if (!backend) {
>> +            error_report("Memory backend '%s' not found",
>> +                         current_machine->ram_memdev_id);
>> +            exit(EXIT_FAILURE);
>> +        }
>>          backend_size = object_property_get_uint(backend, "size",  &error_abort);
>>          if (have_custom_ram_size && backend_size != ram_size) {
>>                  error_report("Size specified by -m option must match size of "
>