From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly
Date: Tue, 17 Mar 2020 17:48:56 +0100 [thread overview]
Message-ID: <20200317174856.456810a5.cohuck@redhat.com> (raw)
In-Reply-To: <d40bc40f-c217-f464-9f65-ea8899bbb899@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]
On Thu, 12 Mar 2020 17:13:10 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:
> On 3/12/20 4:51 PM, Christian Borntraeger wrote:
> > On 11.03.20 14:21, Janosch Frank wrote:
> >> For protected VMs status storing is not done by QEMU anymore.
> >>
> >> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> >> Reviewed-by: Thomas Huth <thuth@redhat.com>
> >> Reviewed-by: David Hildenbrand <david@redhat.com>
> >
> >
> >> ---
> >> target/s390x/helper.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> >> index ed726849114f2f35..5022df8812d406c9 100644
> >> --- a/target/s390x/helper.c
> >> +++ b/target/s390x/helper.c
> >> @@ -25,6 +25,7 @@
> >> #include "qemu/timer.h"
> >> #include "qemu/qemu-print.h"
> >> #include "hw/s390x/ioinst.h"
> >> +#include "hw/s390x/pv.h"
> >> #include "sysemu/hw_accel.h"
> >> #include "sysemu/runstate.h"
> >> #ifndef CONFIG_USER_ONLY
> >> @@ -246,6 +247,11 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool store_arch)
> >> hwaddr len = sizeof(*sa);
> >> int i;
> >>
> >> + /* Storing will occur on next SIE entry for protected VMs */
> >
> > Maybe ... next SIE entry of the sending CPU ....
> > ?
>
> Well that would be the current cpu, right?
> So:
> /* For PVMs storing will occur when this cpu enters SIE again */
With that comment tweak,
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-17 16:52 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 13:21 [PATCH v9 00/15] s390x: Protected Virtualization support Janosch Frank
2020-03-11 13:21 ` [PATCH v9 01/15] Sync pv Janosch Frank
2020-03-11 13:21 ` [PATCH v9 02/15] s390x: protvirt: Support unpack facility Janosch Frank
2020-03-12 8:33 ` Christian Borntraeger
2020-03-13 9:35 ` Janosch Frank
2020-03-13 9:52 ` [PATCH v9] fixup! Fix subcode/pbt Janosch Frank
2020-03-13 14:30 ` Christian Borntraeger
2020-03-13 14:44 ` Janosch Frank
2020-03-16 14:27 ` Cornelia Huck
2020-03-16 14:47 ` Janosch Frank
2020-03-16 14:54 ` Cornelia Huck
2020-03-16 15:04 ` Christian Borntraeger
2020-03-16 17:57 ` Cornelia Huck
2020-03-16 19:42 ` Christian Borntraeger
2020-03-17 9:53 ` Cornelia Huck
2020-03-16 15:05 ` Janosch Frank
2020-03-16 17:58 ` Cornelia Huck
[not found] ` <a0edb6d5-284f-5f10-02e5-d2f252043d71@redhat.com>
2020-03-12 8:54 ` [PATCH v9 02/15] s390x: protvirt: Support unpack facility Janosch Frank
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 03/15] s390x: protvirt: Add migration blocker Janosch Frank
2020-03-12 8:42 ` Christian Borntraeger
2020-03-12 9:34 ` Janosch Frank
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-16 14:49 ` Cornelia Huck
2020-03-11 13:21 ` [PATCH v9 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode Janosch Frank
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-18 11:42 ` Cornelia Huck
2020-03-18 12:30 ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 05/15] s390x: protvirt: KVM intercept changes Janosch Frank
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-17 9:56 ` Cornelia Huck
2020-03-11 13:21 ` [PATCH v9 06/15] s390x: Add SIDA memory ops Janosch Frank
2020-03-12 8:50 ` Christian Borntraeger
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-17 10:24 ` Cornelia Huck
2020-03-17 11:56 ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD Janosch Frank
2020-03-12 10:42 ` Christian Borntraeger
2020-03-12 11:20 ` Janosch Frank
2020-03-17 10:28 ` Cornelia Huck
2020-03-17 10:32 ` Janosch Frank
2020-03-17 10:41 ` Cornelia Huck
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 08/15] s390x: protvirt: SCLP interpretation Janosch Frank
2020-03-11 13:24 ` David Hildenbrand
2020-03-11 13:31 ` Janosch Frank
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-13 13:14 ` Christian Borntraeger
2020-03-17 11:05 ` Cornelia Huck
2020-03-17 11:54 ` Janosch Frank
2020-03-17 12:01 ` Cornelia Huck
2020-03-11 13:21 ` [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW Janosch Frank
2020-03-12 15:08 ` Christian Borntraeger
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-13 14:21 ` Janosch Frank
2020-03-13 14:22 ` Christian Borntraeger
2020-03-13 14:29 ` Claudio Imbrenda
2020-03-13 14:32 ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 10/15] s390x: protvirt: Move diag 308 data over SIDA Janosch Frank
2020-03-12 15:17 ` Christian Borntraeger
2020-03-12 16:05 ` Janosch Frank
2020-03-12 16:09 ` Christian Borntraeger
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 11/15] s390x: protvirt: Disable address checks for PV guest IO emulation Janosch Frank
2020-03-12 15:41 ` Christian Borntraeger
2020-03-12 16:07 ` Janosch Frank
2020-03-12 16:10 ` Christian Borntraeger
2020-03-12 16:17 ` Janosch Frank
2020-03-13 7:38 ` Christian Borntraeger
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-17 11:36 ` Cornelia Huck
2020-03-17 12:00 ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 12/15] s390x: protvirt: Move IO control structures over SIDA Janosch Frank
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-13 13:15 ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly Janosch Frank
2020-03-12 15:51 ` Christian Borntraeger
2020-03-12 16:13 ` Janosch Frank
2020-03-13 7:39 ` Christian Borntraeger
2020-03-13 7:39 ` Christian Borntraeger
2020-03-17 16:48 ` Cornelia Huck [this message]
2020-03-13 12:57 ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 14/15] docs: Add protvirt docs Janosch Frank
[not found] ` <569575c9-5819-f890-e218-99f3a23bee99@redhat.com>
2020-03-12 12:10 ` Janosch Frank
2020-03-13 13:00 ` Claudio Imbrenda
2020-03-13 13:18 ` Janosch Frank
2020-03-13 13:28 ` Peter Maydell
2020-03-17 18:23 ` Cornelia Huck
2020-03-18 8:41 ` Janosch Frank
2020-03-18 11:25 ` Cornelia Huck
2020-03-18 12:34 ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 15/15] s390x: Add unpack facility feature to GA1 Janosch Frank
2020-03-13 13:01 ` Claudio Imbrenda
2020-03-17 18:06 ` Cornelia Huck
2020-03-18 8:44 ` Janosch Frank
2020-03-18 9:27 ` Cornelia Huck
2020-03-18 9:42 ` Janosch Frank
2020-03-11 14:15 ` [PATCH v9 00/15] s390x: Protected Virtualization support no-reply
2020-03-11 14:36 ` no-reply
2020-03-12 16:25 ` [PATCH v9] s390x: protvirt: Fence huge pages Janosch Frank
2020-03-13 8:21 ` Christian Borntraeger
2020-03-16 10:06 ` Janosch Frank
2020-03-16 16:33 ` Christian Borntraeger
2020-03-17 16:57 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317174856.456810a5.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).