From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46559C10DCE for ; Wed, 18 Mar 2020 10:17:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 106C72076D for ; Wed, 18 Mar 2020 10:17:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eRlSPp0g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 106C72076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEVlh-0001e0-61 for qemu-devel@archiver.kernel.org; Wed, 18 Mar 2020 06:17:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38779) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEVkQ-0000FP-Fa for qemu-devel@nongnu.org; Wed, 18 Mar 2020 06:16:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEVkO-0003lp-Kv for qemu-devel@nongnu.org; Wed, 18 Mar 2020 06:16:25 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:44358) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEVkO-0003k7-Dz for qemu-devel@nongnu.org; Wed, 18 Mar 2020 06:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584526583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRwAd6baRBfL0gFOtlnzoY0tqGGS/3afskJnH3zlAHc=; b=eRlSPp0geFoSF2rtjzjTfO5s+j4uNka/ZCEFwrRCAdONrptmgvAxS4AFRvlcJa/fmb9Qo5 sLMRlXE7W7Bd92XyIorF1hRFMSroC1ItEGlom2WfRmsjFgsXxvNvM2zWs8OMfa6EAC/6Uu PRor4wsw7CMRzbpS8u0zB1ZFdGPrB7Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-Ao_7YqDwMg2RjqxUJT8Ncw-1; Wed, 18 Mar 2020 06:16:21 -0400 X-MC-Unique: Ao_7YqDwMg2RjqxUJT8Ncw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9DCB3108442D; Wed, 18 Mar 2020 10:16:20 +0000 (UTC) Received: from work-vm (ovpn-115-3.ams2.redhat.com [10.36.115.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CBCA92D0E; Wed, 18 Mar 2020 10:16:14 +0000 (UTC) Date: Wed, 18 Mar 2020 10:16:10 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 3/4] tests/migration: Disable autoconverge test on Travis-CI s390x Message-ID: <20200318101610.GD2850@work-vm> References: <20200317200541.6246-1-philmd@redhat.com> <20200317200541.6246-4-philmd@redhat.com> <20200317202620.GJ3369@work-vm> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , Thomas Huth , Juan Quintela , Cornelia Huck , qemu-devel@nongnu.org, Peter Xu , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini , Alex =?iso-8859-1?Q?Benn=E9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Philippe Mathieu-Daud=E9 (philmd@redhat.com) wrote: > On 3/17/20 9:26 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daud=E9 (philmd@redhat.com) wrote: > > > This test fails on Travis-CI s390x when configured with --disable-tcg= : > > >=20 > > > $ make check-qtest > > > TEST check-qtest-s390x: tests/qtest/boot-serial-test > > > qemu-system-s390x: -accel tcg: invalid accelerator tcg > > > qemu-system-s390x: falling back to KVM > > > TEST check-qtest-s390x: tests/qtest/pxe-test > > > TEST check-qtest-s390x: tests/qtest/test-netfilter > > > TEST check-qtest-s390x: tests/qtest/test-filter-mirror > > > TEST check-qtest-s390x: tests/qtest/test-filter-redirector > > > TEST check-qtest-s390x: tests/qtest/drive_del-test > > > TEST check-qtest-s390x: tests/qtest/device-plug-test > > > TEST check-qtest-s390x: tests/qtest/virtio-ccw-test > > > TEST check-qtest-s390x: tests/qtest/cpu-plug-test > > > TEST check-qtest-s390x: tests/qtest/migration-test > > > ** > > > ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge= : 'got_stop' should be FALSE > > > ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_mig= rate_auto_converge: 'got_stop' should be FALSE > > > make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1 > >=20 > > Before we take the hammer to it, could you try reducing it's initial > > bandwidth, the code that says: > >=20 > > /* > > * Set the initial parameters so that the migration could not conv= erge > > * without throttling. > > */ > > migrate_set_parameter_int(from, "downtime-limit", 1); > > migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~1= 00Mb/s */ > >=20 > > knock a couple of 0's off that and see if it's happy. >=20 > You are right! One 0 is not enough, but a couple makes the test succeed. >=20 > Can that change have other (bad) effects on other archs? > IOW can I send a generic patch updating this value, or should I add a che= ck > on the architecture? I think generic is fine; as soon as the code notices that it's throttling it increases the bandwidth to let it complete, so it should be OK to have this low. Dave > Thanks! >=20 > >=20 > > Dave > >=20 > > > Per David Gilbert, it might be a threshold requiring tuning: > > > "it could just be the writing is slow on s390 and the migration > > > thread fast; in which case the autocomplete wouldn't be needed. > > > Perhaps we just need to reduce the bandwidth limit." > > >=20 > > > Disable the autoconverge test for now. > > >=20 > > > Signed-off-by: Philippe Mathieu-Daud=E9 > > > --- > > > tests/qtest/migration-test.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > >=20 > > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-tes= t.c > > > index 3d6cc83b88..878399666e 100644 > > > --- a/tests/qtest/migration-test.c > > > +++ b/tests/qtest/migration-test.c > > > @@ -1181,6 +1181,16 @@ static void test_migrate_auto_converge(void) > > > MigrateStart *args =3D migrate_start_new(); > > > QTestState *from, *to; > > > int64_t remaining, percentage; > > > + char *travis_arch; > > > + > > > + /* > > > + * This test does not work reliably on Travis s390x. > > > + */ > > > + travis_arch =3D getenv("TRAVIS_CPU_ARCH"); > > > + if (travis_arch && g_str_equal(travis_arch, "s390x")) { > > > + g_test_skip("Test does not work reliably on s390x Travis con= tainers."); > > > + return; > > > + } > > > /* > > > * We want the test to be stable and as fast as possible. > > > --=20 > > > 2.21.1 > > >=20 > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK