qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: yan@daynix.com, jasowang@redhat.com, quintela@redhat.com,
	qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro
Date: Wed, 18 Mar 2020 11:00:11 +0000	[thread overview]
Message-ID: <20200318110011.GG2850@work-vm> (raw)
In-Reply-To: <20200318091525.27044-7-yuri.benditovich@daynix.com>

* Yuri Benditovich (yuri.benditovich@daynix.com) wrote:
> Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is
> 16-bit field.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
> ---
>  include/migration/vmstate.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 30667631bc..baaefb6b9b 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -432,6 +432,16 @@ extern const VMStateInfo vmstate_info_qlist;
>      .offset     = vmstate_offset_pointer(_state, _field, _type),     \
>  }
>  
> +#define VMSTATE_VARRAY_UINT16_ALLOC(_field, _state, _field_num, _version, _info, _type) {\
> +    .name       = (stringify(_field)),                               \
> +    .version_id = (_version),                                        \
> +    .num_offset = vmstate_offset_value(_state, _field_num, uint16_t),\
> +    .info       = &(_info),                                          \
> +    .size       = sizeof(_type),                                     \
> +    .flags      = VMS_VARRAY_UINT16 | VMS_POINTER | VMS_ALLOC,       \
> +    .offset     = vmstate_offset_pointer(_state, _field, _type),     \
> +}
> +

Once you agree attribution with mst,

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>  #define VMSTATE_VARRAY_UINT16_UNSAFE(_field, _state, _field_num, _version, _info, _type) {\
>      .name       = (stringify(_field)),                               \
>      .version_id = (_version),                                        \
> -- 
> 2.17.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  parent reply	other threads:[~2020-03-18 11:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  9:15 [PATCH v5 0/7] reference implementation of RSS and hash report Yuri Benditovich
2020-03-18  9:15 ` [PATCH v5 1/7] virtio-net: introduce RSS and hash report features Yuri Benditovich
2020-03-18  9:15 ` [PATCH v5 2/7] virtio-net: implement RSS configuration command Yuri Benditovich
2020-03-18  9:15 ` [PATCH v5 3/7] virtio-net: implement RX RSS processing Yuri Benditovich
2020-03-18  9:15 ` [PATCH v5 4/7] tap: allow extended virtio header with hash info Yuri Benditovich
2020-03-18  9:15 ` [PATCH v5 5/7] virtio-net: reference implementation of hash report Yuri Benditovich
2020-03-18  9:15 ` [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro Yuri Benditovich
2020-03-18  9:42   ` Michael S. Tsirkin
2020-03-19 17:12     ` Yuri Benditovich
2020-03-19 17:55       ` Michael S. Tsirkin
2020-03-18 11:00   ` Dr. David Alan Gilbert [this message]
2020-03-18 13:02   ` Juan Quintela
2020-03-18 15:19     ` Michael S. Tsirkin
2020-03-18  9:15 ` [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report Yuri Benditovich
2020-03-18 10:48   ` Dr. David Alan Gilbert
2020-03-19 17:19     ` Yuri Benditovich
2020-03-19 17:23       ` Michael S. Tsirkin
2020-03-19 17:58       ` Juan Quintela
2020-03-19 18:09       ` Dr. David Alan Gilbert
2020-03-18  9:43 ` [PATCH v5 0/7] reference implementation of " Michael S. Tsirkin
2020-03-18  9:53 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318110011.GG2850@work-vm \
    --to=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).