From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
peterx@redhat.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v4 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip"
Date: Wed, 18 Mar 2020 10:52:04 -0400 [thread overview]
Message-ID: <20200318145204.74483-6-peterx@redhat.com> (raw)
In-Reply-To: <20200318145204.74483-1-peterx@redhat.com>
With the resamplefd list introduced, we can savely enable VFIO INTx
fast path again with split irqchip so it can still be faster than the
complete slow path.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/vfio/pci.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 09703362df..1c0aa27386 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -124,18 +124,6 @@ static void vfio_intx_enable_kvm(VFIOPCIDevice *vdev, Error **errp)
return;
}
- if (kvm_irqchip_is_split()) {
- /*
- * VFIO INTx is currently not working with split kernel
- * irqchip for level triggered interrupts. Go the slow path
- * as long as split is enabled so we can be at least
- * functional (even with poor performance).
- *
- * TODO: Remove this after all things fixed up.
- */
- return;
- }
-
/* Get to a known interrupt state */
qemu_set_fd_handler(irq_fd, NULL, NULL, vdev);
vfio_mask_single_irqindex(&vdev->vbasedev, VFIO_PCI_INTX_IRQ_INDEX);
--
2.24.1
next prev parent reply other threads:[~2020-03-18 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 14:51 [PATCH v4 0/5] vfio/pci: Fix up breakage against split irqchip and INTx Peter Xu
2020-03-18 14:52 ` [PATCH v4 1/5] vfio/pci: Disable INTx fast path if using split irqchip Peter Xu
2020-03-18 14:52 ` [PATCH v4 2/5] vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds Peter Xu
2020-03-18 14:52 ` [PATCH v4 3/5] KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd Peter Xu
2020-03-18 14:52 ` [PATCH v4 4/5] KVM: Kick resamplefd for split kernel irqchip Peter Xu
2020-03-18 14:52 ` Peter Xu [this message]
2020-03-31 22:32 ` [PATCH v4 0/5] vfio/pci: Fix up breakage against split irqchip and INTx Alex Williamson
2020-03-31 23:07 ` Peter Xu
2020-05-21 15:57 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318145204.74483-6-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).