From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, cohuck@redhat.com,
david@redhat.com
Subject: [PATCH v11 11/16] s390x: protvirt: Move diag 308 data over SIDA
Date: Thu, 19 Mar 2020 09:19:16 -0400 [thread overview]
Message-ID: <20200319131921.2367-12-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200319131921.2367-1-frankja@linux.ibm.com>
For protected guests the IPIB is written/read to/from the SIDA, so we
need those accesses to go through s390_cpu_pv_mem_read/write().
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
target/s390x/diag.c | 27 +++++++++++++++++++++------
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index b2cbefb8cfe4e5a2..1a4842956402e308 100644
--- a/target/s390x/diag.c
+++ b/target/s390x/diag.c
@@ -75,6 +75,7 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)
{
bool valid;
CPUState *cs = env_cpu(env);
+ S390CPU *cpu = S390_CPU(cs);
uint64_t addr = env->regs[r1];
uint64_t subcode = env->regs[r3];
IplParameterBlock *iplb;
@@ -111,13 +112,22 @@ void handle_diag_308(CPUS390XState *env, uint64_t r1, uint64_t r3, uintptr_t ra)
return;
}
iplb = g_new0(IplParameterBlock, 1);
- cpu_physical_memory_read(addr, iplb, sizeof(iplb->len));
+ if (!s390_is_pv()) {
+ cpu_physical_memory_read(addr, iplb, sizeof(iplb->len));
+ } else {
+ s390_cpu_pv_mem_read(cpu, 0, iplb, sizeof(iplb->len));
+ }
+
if (!iplb_valid_len(iplb)) {
env->regs[r1 + 1] = DIAG_308_RC_INVALID;
goto out;
}
- cpu_physical_memory_read(addr, iplb, be32_to_cpu(iplb->len));
+ if (!s390_is_pv()) {
+ cpu_physical_memory_read(addr, iplb, be32_to_cpu(iplb->len));
+ } else {
+ s390_cpu_pv_mem_read(cpu, 0, iplb, be32_to_cpu(iplb->len));
+ }
valid = subcode == DIAG308_PV_SET ? iplb_valid_pv(iplb) : iplb_valid(iplb);
if (!valid) {
@@ -140,12 +150,17 @@ out:
} else {
iplb = s390_ipl_get_iplb();
}
- if (iplb) {
- cpu_physical_memory_write(addr, iplb, be32_to_cpu(iplb->len));
- env->regs[r1 + 1] = DIAG_308_RC_OK;
- } else {
+ if (!iplb) {
env->regs[r1 + 1] = DIAG_308_RC_NO_CONF;
+ return;
}
+
+ if (!s390_is_pv()) {
+ cpu_physical_memory_write(addr, iplb, be32_to_cpu(iplb->len));
+ } else {
+ s390_cpu_pv_mem_write(cpu, 0, iplb, be32_to_cpu(iplb->len));
+ }
+ env->regs[r1 + 1] = DIAG_308_RC_OK;
return;
case DIAG308_PV_START:
iplb = s390_ipl_get_iplb_pv();
--
2.25.1
next prev parent reply other threads:[~2020-03-19 13:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 13:19 [PATCH v11 00/16] s390x: Protected Virtualization support Janosch Frank
2020-03-19 13:19 ` [PATCH v11 01/16] s390x: Move diagnose 308 subcodes and rcs into ipl.h Janosch Frank
2020-03-19 13:28 ` David Hildenbrand
2020-03-19 13:19 ` [PATCH v11 02/16] Sync pv Janosch Frank
2020-03-19 13:19 ` [PATCH v11 03/16] s390x: protvirt: Support unpack facility Janosch Frank
2020-03-20 21:10 ` Bruce Rogers
2020-03-23 7:15 ` Christian Borntraeger
2020-03-23 7:37 ` Christian Borntraeger
2020-03-23 8:29 ` Janosch Frank
2020-03-23 8:36 ` [PATCH v12] " Janosch Frank
2020-04-29 13:01 ` Cornelia Huck
2020-03-19 13:19 ` [PATCH v11 04/16] s390x: protvirt: Add migration blocker Janosch Frank
2020-03-19 13:19 ` [PATCH v11 05/16] s390x: protvirt: Inhibit balloon when switching to protected mode Janosch Frank
2020-03-19 13:19 ` [PATCH v11 06/16] s390x: protvirt: KVM intercept changes Janosch Frank
2020-03-19 13:19 ` [PATCH v11 07/16] s390x: Add SIDA memory ops Janosch Frank
2020-03-19 13:19 ` [PATCH v11 08/16] s390x: protvirt: Move STSI data over SIDAD Janosch Frank
2020-03-19 13:19 ` [PATCH v11 09/16] s390x: protvirt: SCLP interpretation Janosch Frank
2020-03-19 14:50 ` Christian Borntraeger
2020-03-19 13:19 ` [PATCH v11 10/16] s390x: protvirt: Set guest IPL PSW Janosch Frank
2020-03-19 13:19 ` Janosch Frank [this message]
2020-03-19 13:19 ` [PATCH v11 12/16] s390x: protvirt: Disable address checks for PV guest IO emulation Janosch Frank
2020-03-19 13:19 ` [PATCH v11 13/16] s390x: protvirt: Move IO control structures over SIDA Janosch Frank
2020-03-19 13:19 ` [PATCH v11 14/16] s390x: protvirt: Handle SIGP store status correctly Janosch Frank
2020-03-19 13:19 ` [PATCH v11 15/16] docs: system: Add protvirt docs Janosch Frank
2020-03-19 13:19 ` [PATCH v11 16/16] s390x: Add unpack facility feature to GA1 Janosch Frank
2020-03-23 17:13 ` [PATCH v11 00/16] s390x: Protected Virtualization support Cornelia Huck
2020-03-23 19:39 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319131921.2367-12-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).