* [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:30 ` Richard Henderson
2020-04-23 8:24 ` Juan Quintela
2020-03-16 12:00 ` [PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
` (9 subsequent siblings)
10 siblings, 2 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
The KVM files has been moved from target-ARCH to the target/ARCH/
folder in commit fcf5ef2a. Fix the pathname expansion.
Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 32867bc636..7898e338f6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -353,7 +353,7 @@ Overall KVM CPUs
M: Paolo Bonzini <pbonzini@redhat.com>
L: kvm@vger.kernel.org
S: Supported
-F: */kvm.*
+F: */*/kvm*
F: accel/kvm/
F: accel/stubs/kvm-stub.c
F: include/hw/kvm/
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob
2020-03-16 12:00 ` [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
@ 2020-03-16 18:30 ` Richard Henderson
2020-04-23 7:52 ` Philippe Mathieu-Daudé
2020-04-23 8:24 ` Juan Quintela
1 sibling, 1 reply; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:30 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> The KVM files has been moved from target-ARCH to the target/ARCH/
> folder in commit fcf5ef2a. Fix the pathname expansion.
>
> Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob
2020-03-16 18:30 ` Richard Henderson
@ 2020-04-23 7:52 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-23 7:52 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 7:30 PM, Richard Henderson wrote:
> On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
>> The KVM files has been moved from target-ARCH to the target/ARCH/
>> folder in commit fcf5ef2a. Fix the pathname expansion.
>>
>> Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder")
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> MAINTAINERS | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
Paolo, do you plan to queue this trivial patch or should I ask qemu-trivial?
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob
2020-03-16 12:00 ` [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-03-16 18:30 ` Richard Henderson
@ 2020-04-23 8:24 ` Juan Quintela
1 sibling, 0 replies; 34+ messages in thread
From: Juan Quintela @ 2020-04-23 8:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Riku Voipio, qemu-devel, Laurent Vivier, Aleksandar Markovic,
Paolo Bonzini, Aleksandar Rikalo, Alex Bennée
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> The KVM files has been moved from target-ARCH to the target/ARCH/
> folder in commit fcf5ef2a. Fix the pathname expansion.
>
> Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
2020-03-16 12:00 ` [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:30 ` Richard Henderson
2020-03-16 12:00 ` [PATCH 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
` (8 subsequent siblings)
10 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée, Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Richard Henderson <rth@twiddle.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>
---
MAINTAINERS | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7898e338f6..08d9556ab2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -405,6 +405,15 @@ S: Supported
F: target/i386/kvm.c
F: scripts/kvm/vmxcap
+Guest CPU Cores (other accelerators)
+------------------------------------
+Overall
+M: Richard Henderson <rth@twiddle.net>
+R: Paolo Bonzini <pbonzini@redhat.com>
+S: Maintained
+F: include/sysemu/accel.h
+F: accel/stubs/Makefile.objs
+
WHPX CPUs
M: Sunil Muthuswamy <sunilmut@microsoft.com>
S: Supported
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators
2020-03-16 12:00 ` [PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
@ 2020-03-16 18:30 ` Richard Henderson
0 siblings, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:30 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée, Richard Henderson
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> MAINTAINERS | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 03/11] MAINTAINERS: Add an entry for the HAX accelerator
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
2020-03-16 12:00 ` [PATCH 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-03-16 12:00 ` [PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 12:00 ` [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator Philippe Mathieu-Daudé
` (7 subsequent siblings)
10 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Vincent Palatin, Yu Ning, Philippe Mathieu-Daudé,
Riku Voipio, Laurent Vivier, Hang Yuan,
Sergio Andres Gomez Del Real, David Chou, Wenchao Wang, haxm-team,
Colin Xu, Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée, Tao Wu
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
Cc: Vincent Palatin <vpalatin@chromium.org>
Cc: Yu Ning <yu.ning@intel.com>
Cc: Tao Wu <lepton@google.com>
Cc: haxm-team@intel.com
Cc: Colin Xu <colin.xu@intel.com>
Cc: Hang Yuan <hang.yuan@intel.com>
Cc: David Chou <david.j.chou@intel.com>
Cc: Wenchao Wang <wenchao.wang@intel.com>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 08d9556ab2..7ec42a18f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -414,6 +414,12 @@ S: Maintained
F: include/sysemu/accel.h
F: accel/stubs/Makefile.objs
+HAX Accelerator
+S: Orphan
+F: accel/stubs/hax-stub.c
+F: target/i386/hax-all.c
+F: include/sysemu/hax.h
+
WHPX CPUs
M: Sunil Muthuswamy <sunilmut@microsoft.com>
S: Supported
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 12:12 ` Roman Bolshakov
2020-03-18 18:35 ` Cameron Esfahani via
2020-03-16 12:00 ` [PATCH 05/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
` (6 subsequent siblings)
10 siblings, 2 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Patrick Colp, Philippe Mathieu-Daudé, Riku Voipio,
Laurent Vivier, Cameron Esfahani, Sergio Andres Gomez Del Real,
Roman Bolshakov, Liran Alon, Reviewed-by : Nikita Leshenko,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée, Heiher
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: Patrick Colp <patrick.colp@oracle.com>
Cc: Cameron Esfahani <dirty@apple.com>
Cc: Liran Alon <liran.alon@oracle.com>
Cc: Heiher <r@hev.cc>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7ec42a18f7..bcf40afb85 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -420,6 +420,12 @@ F: accel/stubs/hax-stub.c
F: target/i386/hax-all.c
F: include/sysemu/hax.h
+HVF Accelerator
+S: Orphan
+F: accel/stubs/hvf-stub.c
+F: target/i386/hvf/hvf.c
+F: include/sysemu/hvf.h
+
WHPX CPUs
M: Sunil Muthuswamy <sunilmut@microsoft.com>
S: Supported
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator
2020-03-16 12:00 ` [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator Philippe Mathieu-Daudé
@ 2020-03-16 12:12 ` Roman Bolshakov
2020-03-16 12:36 ` Philippe Mathieu-Daudé
2020-03-17 23:24 ` Cameron Esfahani via
2020-03-18 18:35 ` Cameron Esfahani via
1 sibling, 2 replies; 34+ messages in thread
From: Roman Bolshakov @ 2020-03-16 12:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Riku Voipio, qemu-devel, Cameron Esfahani, Laurent Vivier,
Sergio Andres Gomez Del Real, Patrick Colp, Liran Alon,
Reviewed-by : Nikita Leshenko, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée, Heiher
Hi Philippe,
I can take the ownership if nobody wants it. At the moment I'm working
on APIC for HVF to get kvm-unit-tests fixed.
Next items on the list (in no particular order):
* MMX emulation
* SSE emulation
* qxl display
* gdb stub
* virtio-gpu/virgil running on metal
* VFIO-PCI based on macOS user-space DriverKit framework
Best regards,
Roman
On Mon, Mar 16, 2020 at 01:00:42PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> Cc: Patrick Colp <patrick.colp@oracle.com>
> Cc: Cameron Esfahani <dirty@apple.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Heiher <r@hev.cc>
> ---
> MAINTAINERS | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7ec42a18f7..bcf40afb85 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -420,6 +420,12 @@ F: accel/stubs/hax-stub.c
> F: target/i386/hax-all.c
> F: include/sysemu/hax.h
>
> +HVF Accelerator
> +S: Orphan
> +F: accel/stubs/hvf-stub.c
> +F: target/i386/hvf/hvf.c
> +F: include/sysemu/hvf.h
> +
> WHPX CPUs
> M: Sunil Muthuswamy <sunilmut@microsoft.com>
> S: Supported
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator
2020-03-16 12:12 ` Roman Bolshakov
@ 2020-03-16 12:36 ` Philippe Mathieu-Daudé
2020-03-17 23:24 ` Cameron Esfahani via
1 sibling, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:36 UTC (permalink / raw)
To: Roman Bolshakov, Paolo Bonzini
Cc: Riku Voipio, qemu-devel, Cameron Esfahani, Laurent Vivier,
Sergio Andres Gomez Del Real, Patrick Colp, Liran Alon,
Reviewed-by : Nikita Leshenko, Aleksandar Markovic,
Aleksandar Rikalo, Alex Bennée, Heiher
Hi Roman,
On 3/16/20 1:12 PM, Roman Bolshakov wrote:
> Hi Philippe,
>
> I can take the ownership if nobody wants it. At the moment I'm working
> on APIC for HVF to get kvm-unit-tests fixed.
>
> Next items on the list (in no particular order):
> * MMX emulation
> * SSE emulation
> * qxl display
> * gdb stub
> * virtio-gpu/virgil running on metal
> * VFIO-PCI based on macOS user-space DriverKit framework
Glad to hear :)
I suppose Paolo will be happy to have someone caring about HVF.
Do you mind sending a patch to step in?
Thanks,
Phil.
>
> Best regards,
> Roman
>
> On Mon, Mar 16, 2020 at 01:00:42PM +0100, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
>> Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
>> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
>> Cc: Patrick Colp <patrick.colp@oracle.com>
>> Cc: Cameron Esfahani <dirty@apple.com>
>> Cc: Liran Alon <liran.alon@oracle.com>
>> Cc: Heiher <r@hev.cc>
>> ---
>> MAINTAINERS | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7ec42a18f7..bcf40afb85 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -420,6 +420,12 @@ F: accel/stubs/hax-stub.c
>> F: target/i386/hax-all.c
>> F: include/sysemu/hax.h
>>
>> +HVF Accelerator
>> +S: Orphan
>> +F: accel/stubs/hvf-stub.c
>> +F: target/i386/hvf/hvf.c
>> +F: include/sysemu/hvf.h
>> +
>> WHPX CPUs
>> M: Sunil Muthuswamy <sunilmut@microsoft.com>
>> S: Supported
>> --
>> 2.21.1
>>
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator
2020-03-16 12:12 ` Roman Bolshakov
2020-03-16 12:36 ` Philippe Mathieu-Daudé
@ 2020-03-17 23:24 ` Cameron Esfahani via
2020-03-19 13:36 ` Roman Bolshakov
1 sibling, 1 reply; 34+ messages in thread
From: Cameron Esfahani via @ 2020-03-17 23:24 UTC (permalink / raw)
To: Roman Bolshakov
Cc: Philippe Mathieu-Daudé, Riku Voipio, qemu-devel,
Laurent Vivier, Sergio Andres Gomez Del Real, Patrick Colp,
Liran Alon, Reviewed-by : Nikita Leshenko, Aleksandar Markovic,
Paolo Bonzini, Aleksandar Rikalo, Alex Bennée, Heiher
Sorry I didn't see this yesterday.
We've (Apple) signed up for taking over HVF ownership. I didn't realize I needed to add to the MAINTAINERS list.
Roman, we also have a bunch of pending fixes for some of the issues you've listed. We're in the process of upstreaming them.
Cameron Esfahani
dirty@apple.com
"All that is necessary for the triumph of evil is that good men do nothing."
Edmund Burke
> On Mar 16, 2020, at 5:12 AM, Roman Bolshakov <r.bolshakov@yadro.com> wrote:
>
> Hi Philippe,
>
> I can take the ownership if nobody wants it. At the moment I'm working
> on APIC for HVF to get kvm-unit-tests fixed.
>
> Next items on the list (in no particular order):
> * MMX emulation
> * SSE emulation
> * qxl display
> * gdb stub
> * virtio-gpu/virgil running on metal
> * VFIO-PCI based on macOS user-space DriverKit framework
>
> Best regards,
> Roman
>
> On Mon, Mar 16, 2020 at 01:00:42PM +0100, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
>> Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
>> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
>> Cc: Patrick Colp <patrick.colp@oracle.com>
>> Cc: Cameron Esfahani <dirty@apple.com>
>> Cc: Liran Alon <liran.alon@oracle.com>
>> Cc: Heiher <r@hev.cc>
>> ---
>> MAINTAINERS | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7ec42a18f7..bcf40afb85 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -420,6 +420,12 @@ F: accel/stubs/hax-stub.c
>> F: target/i386/hax-all.c
>> F: include/sysemu/hax.h
>>
>> +HVF Accelerator
>> +S: Orphan
>> +F: accel/stubs/hvf-stub.c
>> +F: target/i386/hvf/hvf.c
>> +F: include/sysemu/hvf.h
>> +
>> WHPX CPUs
>> M: Sunil Muthuswamy <sunilmut@microsoft.com>
>> S: Supported
>> --
>> 2.21.1
>>
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator
2020-03-17 23:24 ` Cameron Esfahani via
@ 2020-03-19 13:36 ` Roman Bolshakov
0 siblings, 0 replies; 34+ messages in thread
From: Roman Bolshakov @ 2020-03-19 13:36 UTC (permalink / raw)
To: Cameron Esfahani
Cc: Alex Bennée, Riku Voipio, qemu-devel, Laurent Vivier,
Sergio Andres Gomez Del Real, Patrick Colp, Liran Alon,
Reviewed-by : Nikita Leshenko, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Philippe Mathieu-Daudé, Heiher
On Tue, Mar 17, 2020 at 04:24:44PM -0700, Cameron Esfahani wrote:
> Sorry I didn't see this yesterday.
>
> We've (Apple) signed up for taking over HVF ownership. I didn't realize I needed to add to the MAINTAINERS list.
>
> Roman, we also have a bunch of pending fixes for some of the issues you've listed. We're in the process of upstreaming them.
>
Hi Cameron,
That's great news. What exactly are you planning to upstream first?
BTW many thanks for the fixes you made last December.
Best regards,
Roman
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator
2020-03-16 12:00 ` [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator Philippe Mathieu-Daudé
2020-03-16 12:12 ` Roman Bolshakov
@ 2020-03-18 18:35 ` Cameron Esfahani via
1 sibling, 0 replies; 34+ messages in thread
From: Cameron Esfahani via @ 2020-03-18 18:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Cameron Esfahani via, Patrick Colp, Riku Voipio, Laurent Vivier,
Sergio Andres Gomez Del Real, Roman Bolshakov, Liran Alon,
Reviewed-by : Nikita Leshenko, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée, Heiher
Please add me to the HVF maintainers as well.
Cameron Esfahani
dirty@apple.com
"In the elder days of Art, Builders wrought with greatest care each minute and unseen part; For the gods see everywhere."
"The Builders", H. W. Longfellow
> On Mar 16, 2020, at 5:00 AM, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> Cc: Patrick Colp <patrick.colp@oracle.com>
> Cc: Cameron Esfahani <dirty@apple.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Heiher <r@hev.cc>
> ---
> MAINTAINERS | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7ec42a18f7..bcf40afb85 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -420,6 +420,12 @@ F: accel/stubs/hax-stub.c
> F: target/i386/hax-all.c
> F: include/sysemu/hax.h
>
> +HVF Accelerator
> +S: Orphan
> +F: accel/stubs/hvf-stub.c
> +F: target/i386/hvf/hvf.c
> +F: include/sysemu/hvf.h
> +
> WHPX CPUs
> M: Sunil Muthuswamy <sunilmut@microsoft.com>
> S: Supported
> --
> 2.21.1
>
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 05/11] Makefile: Write MINIKCONF variables as one entry per line
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (3 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:30 ` Richard Henderson
2020-03-16 12:00 ` [PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
` (5 subsequent siblings)
10 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
Having one entry per line helps reviews/refactors. As we are
going to modify the MINIKCONF variables, split them now to
ease further review.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 7df22fcc5d..d83a94bc53 100644
--- a/Makefile
+++ b/Makefile
@@ -418,8 +418,10 @@ MINIKCONF_ARGS = \
CONFIG_LINUX=$(CONFIG_LINUX) \
CONFIG_PVRDMA=$(CONFIG_PVRDMA)
-MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig
-MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig)
+MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \
+ $(SRC_PATH)/hw/Kconfig
+MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \
+ $(wildcard $(SRC_PATH)/hw/*/Kconfig)
MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 05/11] Makefile: Write MINIKCONF variables as one entry per line
2020-03-16 12:00 ` [PATCH 05/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
@ 2020-03-16 18:30 ` Richard Henderson
0 siblings, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:30 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> Having one entry per line helps reviews/refactors. As we are
> going to modify the MINIKCONF variables, split them now to
> ease further review.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (4 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 05/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:30 ` Richard Henderson
2020-03-16 12:00 ` [PATCH 07/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
` (4 subsequent siblings)
10 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
Move the accel selectors from the global Kconfig.host to their
own Kconfig file.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 1 +
Kconfig.host | 7 -------
accel/Kconfig | 6 ++++++
3 files changed, 7 insertions(+), 7 deletions(-)
create mode 100644 accel/Kconfig
diff --git a/Makefile b/Makefile
index d83a94bc53..d1e2ec10e7 100644
--- a/Makefile
+++ b/Makefile
@@ -419,6 +419,7 @@ MINIKCONF_ARGS = \
CONFIG_PVRDMA=$(CONFIG_PVRDMA)
MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \
+ $(SRC_PATH)/accel/Kconfig \
$(SRC_PATH)/hw/Kconfig
MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \
$(wildcard $(SRC_PATH)/hw/*/Kconfig)
diff --git a/Kconfig.host b/Kconfig.host
index 55136e037d..a6d871c399 100644
--- a/Kconfig.host
+++ b/Kconfig.host
@@ -2,9 +2,6 @@
# down to Kconfig. See also MINIKCONF_ARGS in the Makefile:
# these two need to be kept in sync.
-config KVM
- bool
-
config LINUX
bool
@@ -31,10 +28,6 @@ config VHOST_KERNEL
bool
select VHOST
-config XEN
- bool
- select FSDEV_9P if VIRTFS
-
config VIRTFS
bool
diff --git a/accel/Kconfig b/accel/Kconfig
new file mode 100644
index 0000000000..c21802bb49
--- /dev/null
+++ b/accel/Kconfig
@@ -0,0 +1,6 @@
+config KVM
+ bool
+
+config XEN
+ bool
+ select FSDEV_9P if VIRTFS
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config
2020-03-16 12:00 ` [PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
@ 2020-03-16 18:30 ` Richard Henderson
0 siblings, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:30 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> Move the accel selectors from the global Kconfig.host to their
> own Kconfig file.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 1 +
> Kconfig.host | 7 -------
> accel/Kconfig | 6 ++++++
> 3 files changed, 7 insertions(+), 7 deletions(-)
> create mode 100644 accel/Kconfig
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 07/11] accel/Kconfig: Add the TCG selector
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (5 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:31 ` Richard Henderson
2020-03-16 12:00 ` [PATCH 08/11] target/Kconfig: Allow targets to use Kconfig Philippe Mathieu-Daudé
` (3 subsequent siblings)
10 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
Expose the CONFIG_TCG selector to let minikconf.py uses it.
When building with --disable-tcg build, this helps to deselect
devices that are TCG-dependent.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 1 +
accel/Kconfig | 3 +++
2 files changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index d1e2ec10e7..1cf9d76ce7 100644
--- a/Makefile
+++ b/Makefile
@@ -405,6 +405,7 @@ endif
MINIKCONF_ARGS = \
$(CONFIG_MINIKCONF_MODE) \
$@ $*/config-devices.mak.d $< $(MINIKCONF_INPUTS) \
+ CONFIG_TCG=$(CONFIG_TCG) \
CONFIG_KVM=$(CONFIG_KVM) \
CONFIG_SPICE=$(CONFIG_SPICE) \
CONFIG_IVSHMEM=$(CONFIG_IVSHMEM) \
diff --git a/accel/Kconfig b/accel/Kconfig
index c21802bb49..2ad94a3839 100644
--- a/accel/Kconfig
+++ b/accel/Kconfig
@@ -1,3 +1,6 @@
+config TCG
+ bool
+
config KVM
bool
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 07/11] accel/Kconfig: Add the TCG selector
2020-03-16 12:00 ` [PATCH 07/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
@ 2020-03-16 18:31 ` Richard Henderson
0 siblings, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> Expose the CONFIG_TCG selector to let minikconf.py uses it.
>
> When building with --disable-tcg build, this helps to deselect
> devices that are TCG-dependent.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 1 +
> accel/Kconfig | 3 +++
> 2 files changed, 4 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 08/11] target/Kconfig: Allow targets to use Kconfig
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (6 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 07/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:33 ` Richard Henderson
2020-03-16 12:00 ` [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING Philippe Mathieu-Daudé
` (2 subsequent siblings)
10 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
Allow targets to select target-specific Kconfig values.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 6 ++++--
target/Kconfig | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
create mode 100644 target/Kconfig
diff --git a/Makefile b/Makefile
index 1cf9d76ce7..e402c33811 100644
--- a/Makefile
+++ b/Makefile
@@ -421,9 +421,11 @@ MINIKCONF_ARGS = \
MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \
$(SRC_PATH)/accel/Kconfig \
- $(SRC_PATH)/hw/Kconfig
+ $(SRC_PATH)/hw/Kconfig \
+ $(SRC_PATH)/target/Kconfig
MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \
- $(wildcard $(SRC_PATH)/hw/*/Kconfig)
+ $(wildcard $(SRC_PATH)/hw/*/Kconfig) \
+ $(wildcard $(SRC_PATH)/target/*/Kconfig)
MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
diff --git a/target/Kconfig b/target/Kconfig
new file mode 100644
index 0000000000..8b13789179
--- /dev/null
+++ b/target/Kconfig
@@ -0,0 +1 @@
+
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 08/11] target/Kconfig: Allow targets to use Kconfig
2020-03-16 12:00 ` [PATCH 08/11] target/Kconfig: Allow targets to use Kconfig Philippe Mathieu-Daudé
@ 2020-03-16 18:33 ` Richard Henderson
0 siblings, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:33 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> diff --git a/target/Kconfig b/target/Kconfig
> new file mode 100644
> index 0000000000..8b13789179
> --- /dev/null
> +++ b/target/Kconfig
> @@ -0,0 +1 @@
> +
Does this want a
# This file intentionally left blank.
?
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (7 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 08/11] target/Kconfig: Allow targets to use Kconfig Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:34 ` Richard Henderson
2020-03-18 10:31 ` Paolo Bonzini
2020-03-16 12:00 ` [PATCH 10/11] target/arm: " Philippe Mathieu-Daudé
2020-03-16 12:00 ` [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
10 siblings, 2 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée, Aurelien Jarno
On MIPS, the semihosting feature is always required on user-space.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
default-configs/mips-linux-user-common.mak | 4 ++++
default-configs/mips-linux-user.mak | 2 ++
default-configs/mips64-linux-user.mak | 2 ++
default-configs/mips64el-linux-user.mak | 2 ++
default-configs/mipsel-linux-user.mak | 2 ++
default-configs/mipsn32-linux-user.mak | 2 ++
default-configs/mipsn32el-linux-user.mak | 2 ++
7 files changed, 16 insertions(+)
create mode 100644 default-configs/mips-linux-user-common.mak
diff --git a/default-configs/mips-linux-user-common.mak b/default-configs/mips-linux-user-common.mak
new file mode 100644
index 0000000000..04947706e8
--- /dev/null
+++ b/default-configs/mips-linux-user-common.mak
@@ -0,0 +1,4 @@
+# Common mips*-linux-user CONFIG defines
+
+# CONFIG_SEMIHOSTING is always required on this architecture
+CONFIG_SEMIHOSTING=y
diff --git a/default-configs/mips-linux-user.mak b/default-configs/mips-linux-user.mak
index 31df57021e..c606e12444 100644
--- a/default-configs/mips-linux-user.mak
+++ b/default-configs/mips-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for mips-linux-user
+
+include mips-linux-user-common.mak
diff --git a/default-configs/mips64-linux-user.mak b/default-configs/mips64-linux-user.mak
index 1598bfcf7d..81e16ac2eb 100644
--- a/default-configs/mips64-linux-user.mak
+++ b/default-configs/mips64-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for mips64-linux-user
+
+include mips-linux-user-common.mak
diff --git a/default-configs/mips64el-linux-user.mak b/default-configs/mips64el-linux-user.mak
index 629f084086..6399af3fd5 100644
--- a/default-configs/mips64el-linux-user.mak
+++ b/default-configs/mips64el-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for mips64el-linux-user
+
+include mips-linux-user-common.mak
diff --git a/default-configs/mipsel-linux-user.mak b/default-configs/mipsel-linux-user.mak
index 4d0e4afb69..4a27d30b45 100644
--- a/default-configs/mipsel-linux-user.mak
+++ b/default-configs/mipsel-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for mipsel-linux-user
+
+include mips-linux-user-common.mak
diff --git a/default-configs/mipsn32-linux-user.mak b/default-configs/mipsn32-linux-user.mak
index 5b97919794..f3ac967463 100644
--- a/default-configs/mipsn32-linux-user.mak
+++ b/default-configs/mipsn32-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for mipsn32-linux-user
+
+include mips-linux-user-common.mak
diff --git a/default-configs/mipsn32el-linux-user.mak b/default-configs/mipsn32el-linux-user.mak
index d6367ff987..63fe4de4fd 100644
--- a/default-configs/mipsn32el-linux-user.mak
+++ b/default-configs/mipsn32el-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for mipsn32el-linux-user
+
+include mips-linux-user-common.mak
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING
2020-03-16 12:00 ` [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING Philippe Mathieu-Daudé
@ 2020-03-16 18:34 ` Richard Henderson
2020-03-18 10:31 ` Paolo Bonzini
1 sibling, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:34 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée, Aurelien Jarno
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> On MIPS, the semihosting feature is always required on user-space.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> default-configs/mips-linux-user-common.mak | 4 ++++
> default-configs/mips-linux-user.mak | 2 ++
> default-configs/mips64-linux-user.mak | 2 ++
> default-configs/mips64el-linux-user.mak | 2 ++
> default-configs/mipsel-linux-user.mak | 2 ++
> default-configs/mipsn32-linux-user.mak | 2 ++
> default-configs/mipsn32el-linux-user.mak | 2 ++
> 7 files changed, 16 insertions(+)
> create mode 100644 default-configs/mips-linux-user-common.mak
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING
2020-03-16 12:00 ` [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING Philippe Mathieu-Daudé
2020-03-16 18:34 ` Richard Henderson
@ 2020-03-18 10:31 ` Paolo Bonzini
2020-04-20 11:28 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 34+ messages in thread
From: Paolo Bonzini @ 2020-03-18 10:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic,
Aleksandar Rikalo, Alex Bennée, Aurelien Jarno
On 16/03/20 13:00, Philippe Mathieu-Daudé wrote:
> diff --git a/default-configs/mips-linux-user-common.mak b/default-configs/mips-linux-user-common.mak
> new file mode 100644
> index 0000000000..04947706e8
> --- /dev/null
> +++ b/default-configs/mips-linux-user-common.mak
> @@ -0,0 +1,4 @@
> +# Common mips*-linux-user CONFIG defines
> +
> +# CONFIG_SEMIHOSTING is always required on this architecture
> +CONFIG_SEMIHOSTING=y
If it is always required, it should be select-ed.
Same for patch 10.
Paolo
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING
2020-03-18 10:31 ` Paolo Bonzini
@ 2020-04-20 11:28 ` Philippe Mathieu-Daudé
[not found] ` <5ebee88a-4ce4-7406-a668-c64e1cc5ae6c@redhat.com>
0 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-20 11:28 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic,
Aleksandar Rikalo, Alex Bennée, Aurelien Jarno
Hi Paolo,
TLDR "how can I select a arch-specific feature?"
On 3/18/20 11:31 AM, Paolo Bonzini wrote:
> On 16/03/20 13:00, Philippe Mathieu-Daudé wrote:
>> diff --git a/default-configs/mips-linux-user-common.mak b/default-configs/mips-linux-user-common.mak
>> new file mode 100644
>> index 0000000000..04947706e8
>> --- /dev/null
>> +++ b/default-configs/mips-linux-user-common.mak
>> @@ -0,0 +1,4 @@
>> +# Common mips*-linux-user CONFIG defines
>> +
>> +# CONFIG_SEMIHOSTING is always required on this architecture
>> +CONFIG_SEMIHOSTING=y
>
> If it is always required, it should be select-ed.
I'm not sure how to do that...
Currently we have in hw/semihosting/Kconfig:
config SEMIHOSTING
bool
depends on TCG
default n
The only per-target generic entry point is minikconf command line.
1/ The less ugly option might be to add an optional target-devices.mak:
-- >8 --
diff --git a/Makefile.target b/Makefile.target
--- a/Makefile.target
+++ b/Makefile.target
@@ -5,6 +5,7 @@ BUILD_DIR?=$(CURDIR)/..
include ../config-host.mak
include config-target.mak
include $(SRC_PATH)/rules.mak
+-include $(SRC_PATH)/target/$(TARGET_BASE_ARCH)/target-devices.mak
ifdef CONFIG_SOFTMMU
include config-devices.mak
diff --git a/target/arm/target-devices.mak b/target/arm/target-devices.mak
new file mode 100644
--- /dev/null
+++ b/target/arm/target-devices.mak
@@ -0,0 +1 @@
+CONFIG_SEMIHOSTING=y
---
2/ I can have ./configure adding in config-devices.mak:
-- >8 --
@@ -7778,6 +7778,7 @@ echo "# Automatically generated by configure - do
not modify" > $config_target_m
bflt="no"
mttcg="no"
+target_require_semihosting="no"
interp_prefix1=$(echo "$interp_prefix" | sed "s/%M/$target_name/g")
gdb_xml_files=""
@@ -7806,6 +7807,7 @@ case "$target_name" in
TARGET_SYSTBL_ABI=common,oabi
bflt="yes"
mttcg="yes"
+ target_require_semihosting="yes"
gdb_xml_files="arm-core.xml arm-vfp.xml arm-vfp3.xml arm-neon.xml"
;;
aarch64|aarch64_be)
@@ -7813,6 +7815,7 @@ case "$target_name" in
TARGET_BASE_ARCH=arm
bflt="yes"
mttcg="yes"
+ target_require_semihosting="yes"
gdb_xml_files="aarch64-core.xml aarch64-fpu.xml arm-core.xml
arm-vfp.xml arm-vfp3.xml arm-neon.xml"
;;
cris)
@@ -8031,7 +8034,10 @@ fi
if test "$target_bsd_user" = "yes" ; then
echo "CONFIG_BSD_USER=y" >> $config_target_mak
fi
+if test "$target_require_semihosting" = "yes" ; then
+ echo "$target/config-devices.mak: CONFIG_SEMIHOSTING=y" >>
$config_host_mak
+fi
---
3/ Or force MINIKCONF_ARGS:
---
if test "$target_require_semihosting" = "yes" ; then
echo "MINIKCONF_ARGS += CONFIG_SEMIHOSTING=y" >> $config_target_mak
fi
---
Also note for ARM all configs require it, but for MIPS we only want it
for user-mode.
With 1/ this can be done as:
-- >8 --
diff --git a/target/mips/target-devices.mak b/target/mips/target-devices.mak
new file mode 100644
--- /dev/null
+++ b/target/mips/target-devices.mak
@@ -0,0 +1,3 @@
+ifndef CONFIG_SOFTMMU
+CONFIG_SEMIHOSTING=y
+endif
---
>
> Same for patch 10.
>
> Paolo
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 10/11] target/arm: Always enable CONFIG_SEMIHOSTING
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (8 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 18:35 ` Richard Henderson
2020-03-16 12:00 ` [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
10 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
On ARM, the semihosting feature is always required on user-space,
and is also used by system emulation.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
default-configs/aarch64-linux-user-common.mak | 4 ++++
default-configs/aarch64-linux-user.mak | 2 ++
default-configs/aarch64_be-linux-user.mak | 2 ++
default-configs/arm-linux-user-common.mak | 4 ++++
default-configs/arm-linux-user.mak | 2 ++
default-configs/arm-softmmu.mak | 4 +++-
default-configs/armeb-linux-user.mak | 2 ++
7 files changed, 19 insertions(+), 1 deletion(-)
create mode 100644 default-configs/aarch64-linux-user-common.mak
create mode 100644 default-configs/arm-linux-user-common.mak
diff --git a/default-configs/aarch64-linux-user-common.mak b/default-configs/aarch64-linux-user-common.mak
new file mode 100644
index 0000000000..94c0cdf826
--- /dev/null
+++ b/default-configs/aarch64-linux-user-common.mak
@@ -0,0 +1,4 @@
+# Common aarch64*-linux-user CONFIG defines
+
+# CONFIG_SEMIHOSTING is always required on this architecture
+CONFIG_SEMIHOSTING=y
diff --git a/default-configs/aarch64-linux-user.mak b/default-configs/aarch64-linux-user.mak
index 0a5b08a007..d27232cbc6 100644
--- a/default-configs/aarch64-linux-user.mak
+++ b/default-configs/aarch64-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for aarch64-linux-user
+
+include aarch64-linux-user-common.mak
diff --git a/default-configs/aarch64_be-linux-user.mak b/default-configs/aarch64_be-linux-user.mak
index a69d9d2e41..7dee7ba4cb 100644
--- a/default-configs/aarch64_be-linux-user.mak
+++ b/default-configs/aarch64_be-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for aarch64_be-linux-user
+
+include aarch64-linux-user-common.mak
diff --git a/default-configs/arm-linux-user-common.mak b/default-configs/arm-linux-user-common.mak
new file mode 100644
index 0000000000..67acd961f3
--- /dev/null
+++ b/default-configs/arm-linux-user-common.mak
@@ -0,0 +1,4 @@
+# Common arm*-linux-user CONFIG defines
+
+# CONFIG_SEMIHOSTING is always required on this architecture
+CONFIG_SEMIHOSTING=y
diff --git a/default-configs/arm-linux-user.mak b/default-configs/arm-linux-user.mak
index 413361a022..7d45e4d20a 100644
--- a/default-configs/arm-linux-user.mak
+++ b/default-configs/arm-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for arm-linux-user
+
+include arm-linux-user-common.mak
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 36a0e89daa..8b89d8c4c0 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -1,5 +1,8 @@
# Default configuration for arm-softmmu
+# CONFIG_SEMIHOSTING is always required on this architecture
+CONFIG_SEMIHOSTING=y
+
# TODO: ARM_V7M is currently always required - make this more flexible!
CONFIG_ARM_V7M=y
@@ -40,5 +43,4 @@ CONFIG_MICROBIT=y
CONFIG_FSL_IMX25=y
CONFIG_FSL_IMX7=y
CONFIG_FSL_IMX6UL=y
-CONFIG_SEMIHOSTING=y
CONFIG_ALLWINNER_H3=y
diff --git a/default-configs/armeb-linux-user.mak b/default-configs/armeb-linux-user.mak
index bf2ffe7038..485132f606 100644
--- a/default-configs/armeb-linux-user.mak
+++ b/default-configs/armeb-linux-user.mak
@@ -1 +1,3 @@
# Default configuration for armeb-linux-user
+
+include arm-linux-user-common.mak
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 10/11] target/arm: Always enable CONFIG_SEMIHOSTING
2020-03-16 12:00 ` [PATCH 10/11] target/arm: " Philippe Mathieu-Daudé
@ 2020-03-16 18:35 ` Richard Henderson
0 siblings, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> On ARM, the semihosting feature is always required on user-space,
> and is also used by system emulation.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> default-configs/aarch64-linux-user-common.mak | 4 ++++
> default-configs/aarch64-linux-user.mak | 2 ++
> default-configs/aarch64_be-linux-user.mak | 2 ++
> default-configs/arm-linux-user-common.mak | 4 ++++
> default-configs/arm-linux-user.mak | 2 ++
> default-configs/arm-softmmu.mak | 4 +++-
> default-configs/armeb-linux-user.mak | 2 ++
> 7 files changed, 19 insertions(+), 1 deletion(-)
> create mode 100644 default-configs/aarch64-linux-user-common.mak
> create mode 100644 default-configs/arm-linux-user-common.mak
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it
2020-03-16 12:00 [PATCH 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
` (9 preceding siblings ...)
2020-03-16 12:00 ` [PATCH 10/11] target/arm: " Philippe Mathieu-Daudé
@ 2020-03-16 12:00 ` Philippe Mathieu-Daudé
2020-03-16 13:49 ` Peter Maydell
2020-03-16 18:37 ` Richard Henderson
10 siblings, 2 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 12:00 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Riku Voipio, Laurent Vivier,
Aleksandar Markovic, Paolo Bonzini, Aleksandar Rikalo,
Alex Bennée
The semihosting feature is only meaningful when using TCG.
So far only the ARM/MIPS/LM32 provide the semihosting feature.
Do not enable it by default, and let the few targets requiring
it to manually select it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/semihosting/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/semihosting/Kconfig b/hw/semihosting/Kconfig
index efe0a30734..06e9262af2 100644
--- a/hw/semihosting/Kconfig
+++ b/hw/semihosting/Kconfig
@@ -1,3 +1,5 @@
config SEMIHOSTING
- bool
+ bool
+ depends on TCG
+ default n
--
2.21.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it
2020-03-16 12:00 ` [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
@ 2020-03-16 13:49 ` Peter Maydell
2020-03-16 14:01 ` Philippe Mathieu-Daudé
2020-03-16 18:37 ` Richard Henderson
1 sibling, 1 reply; 34+ messages in thread
From: Peter Maydell @ 2020-03-16 13:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Riku Voipio, QEMU Developers, Laurent Vivier, Aleksandar Markovic,
Paolo Bonzini, Aleksandar Rikalo, Alex Bennée
On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The semihosting feature is only meaningful when using TCG.
>
> So far only the ARM/MIPS/LM32 provide the semihosting feature.
Also m68k, nios2, xtensa. riscv eventually but not yet upstream.
>
> Do not enable it by default, and let the few targets requiring
> it to manually select it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/semihosting/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/semihosting/Kconfig b/hw/semihosting/Kconfig
> index efe0a30734..06e9262af2 100644
> --- a/hw/semihosting/Kconfig
> +++ b/hw/semihosting/Kconfig
> @@ -1,3 +1,5 @@
>
> config SEMIHOSTING
> - bool
> + bool
> + depends on TCG
> + default n
OK, this is the "do not enable by default" -- where is
the "but do enable by default for the targets that use it"
part of the config change ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it
2020-03-16 13:49 ` Peter Maydell
@ 2020-03-16 14:01 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-16 14:01 UTC (permalink / raw)
To: Peter Maydell
Cc: Riku Voipio, QEMU Developers, Laurent Vivier, Aleksandar Markovic,
Paolo Bonzini, Aleksandar Rikalo, Alex Bennée
On 3/16/20 2:49 PM, Peter Maydell wrote:
> On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> The semihosting feature is only meaningful when using TCG.
>>
>> So far only the ARM/MIPS/LM32 provide the semihosting feature.
>
> Also m68k, nios2, xtensa. riscv eventually but not yet upstream.
>
>>
>> Do not enable it by default, and let the few targets requiring
>> it to manually select it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> hw/semihosting/Kconfig | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/semihosting/Kconfig b/hw/semihosting/Kconfig
>> index efe0a30734..06e9262af2 100644
>> --- a/hw/semihosting/Kconfig
>> +++ b/hw/semihosting/Kconfig
>> @@ -1,3 +1,5 @@
>>
>> config SEMIHOSTING
>> - bool
>> + bool
>> + depends on TCG
>> + default n
>
> OK, this is the "do not enable by default" -- where is
> the "but do enable by default for the targets that use it"
> part of the config change ?
This is already the default for these targets, see:
commit 16932bb761e52c2ca9397b57af5bdc5bdc5ae6a4
Author: Alex Bennée <alex.bennee@linaro.org>
Date: Mon May 13 15:25:27 2019 +0100
semihosting: introduce CONFIG_SEMIHOSTING
There isn't much point building semihosting for platforms that don't
support it. Introduce a new symbol and enable it only for the
softmmu targets that need it.
I'll add that information in the description.
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it
2020-03-16 12:00 ` [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
2020-03-16 13:49 ` Peter Maydell
@ 2020-03-16 18:37 ` Richard Henderson
1 sibling, 0 replies; 34+ messages in thread
From: Richard Henderson @ 2020-03-16 18:37 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Riku Voipio, Laurent Vivier, Aleksandar Markovic, Paolo Bonzini,
Aleksandar Rikalo, Alex Bennée
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote:
> The semihosting feature is only meaningful when using TCG.
>
> So far only the ARM/MIPS/LM32 provide the semihosting feature.
>
> Do not enable it by default, and let the few targets requiring
> it to manually select it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/semihosting/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 34+ messages in thread