From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: eric.auger@redhat.com, Gerd Hoffmann <kraxel@redhat.com>, mst@redhat.com
Subject: [PATCH] virtio-iommu: depend on PCI
Date: Fri, 20 Mar 2020 11:41:47 +0100 [thread overview]
Message-ID: <20200320104147.643941-1-pbonzini@redhat.com> (raw)
The virtio-iommu device attaches itself to a PCI bus, so it makes
no sense to include it unless PCI is supported---and in fact
compilation fails without this change.
Reported-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/virtio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/Kconfig b/hw/virtio/Kconfig
index d29525b36f..83122424fa 100644
--- a/hw/virtio/Kconfig
+++ b/hw/virtio/Kconfig
@@ -12,7 +12,7 @@ config VIRTIO_RNG
config VIRTIO_IOMMU
bool
default y
- depends on VIRTIO
+ depends on PCI && VIRTIO
config VIRTIO_PCI
bool
--
2.24.1
next reply other threads:[~2020-03-20 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 10:41 Paolo Bonzini [this message]
2020-03-20 10:54 ` [PATCH] virtio-iommu: depend on PCI Auger Eric
2020-03-20 11:13 ` Paolo Bonzini
2020-03-20 11:26 ` Philippe Mathieu-Daudé
2020-03-20 11:36 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320104147.643941-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).