From: Stefan Hajnoczi <stefanha@gmail.com>
To: Julia Suvorova <jusual@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Yuval Shaia <yuval.shaia.ml@gmail.com>
Subject: Re: [PATCH] hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy
Date: Fri, 20 Mar 2020 15:20:22 +0000 [thread overview]
Message-ID: <20200320152022.GC138042@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200318134849.237011-1-jusual@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Wed, Mar 18, 2020 at 02:48:49PM +0100, Julia Suvorova wrote:
> ring->name is defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated
> strncpy with QEMU function.
> This case prevented QEMU from compiling with --enable-sanitizers.
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> ---
> hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is my equivalent patch
<20200316160702.478964-3-stefanha@redhat.com> but feel free to merge
this.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-20 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 13:48 [PATCH] hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy Julia Suvorova
2020-03-20 11:49 ` Yuval Shaia
2020-03-20 15:20 ` Stefan Hajnoczi [this message]
2020-03-20 17:30 ` Julia Suvorova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320152022.GC138042@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=jusual@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yuval.shaia.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).