From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1AA1C4332D for ; Fri, 20 Mar 2020 16:09:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCCEF20739 for ; Fri, 20 Mar 2020 16:09:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sinYBWdK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCCEF20739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFKDH-0006Pm-SE for qemu-devel@archiver.kernel.org; Fri, 20 Mar 2020 12:09:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39863) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFKAI-00020o-Nd for qemu-devel@nongnu.org; Fri, 20 Mar 2020 12:06:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFKAH-0001cv-HW for qemu-devel@nongnu.org; Fri, 20 Mar 2020 12:06:30 -0400 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:34714) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFKAH-0001cR-Br for qemu-devel@nongnu.org; Fri, 20 Mar 2020 12:06:29 -0400 Received: by mail-pj1-x1044.google.com with SMTP id q16so3592087pje.1 for ; Fri, 20 Mar 2020 09:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9N6FLF8sUw4XVnPIwBVzCdAPTwyubp1J/tKDvqzTiXA=; b=sinYBWdKPXM87ZyspIJS8N8F+GXUJppxt202/ZQkT99Eg8bR4pvRLUmgByGD0hx0xI nJFDBVddSlbNtOc6IsVeOcW7Tm6L5sPKvCgsoaOmuUD1XJlE+tis5nD6VRBTKIlAk5DF F3dSjk8o9T72oL00+HtVlQoDUpngTeVf5XJDLApLB4dZptJSlUEcLDh7ToUMgw/0JSa3 1mURHO/iqOuys/U9K3Ghrxbtn/e38w0ZJHpYIX2m3ib4knFoZLLa9ncbXOVHwRwdHJj2 TFxbgDdYz0RszcBptnHmH4N+Hg9u7TCGO2TPSUb8Y9QJEvorDknLz6jlFl39uxdiKDgP tulQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9N6FLF8sUw4XVnPIwBVzCdAPTwyubp1J/tKDvqzTiXA=; b=igcLGy2zSxRwtkFd7BjCMkftq2oovvZjJG9dr2x9tEFg9ZTLYAIe97bdmFgoTE5FFT usmilYxeoIXKsmUWTykDfxdq6sOkXm/AmYrJHxEgDatibfBaZAxRckjsEoBz2epOL+Wd GbTYpUW3Y57xHIvVgjxI4FqRIrsmSc83JwbVW8nLvg/Eqqa6UTOmKPbVa3pJ3sqnIERE SeMfsq2Yr950tCwum+XcS55tjgFOLKVwnevoTx+d6V7T+lG+TpqzdRh1DKVAxU65LTnz P4rnmihFhYKF1nPOqhOTzAkCnu5jaPTy0IpXQ4qUAfe0KEtFKgR/fajJULokBeB25cFG yXig== X-Gm-Message-State: ANhLgQ0lZPLyEVcRmqUffm9NUZbDAXTF1TZby6NpZs21qgb7TSbUY/PZ jXXh1FecxG+wCDod11nZw/UNa62YIrA= X-Google-Smtp-Source: ADFU+vv5jD6NaTiHidXgK0P+b1zwJQakVbWlD9CCBU8oZzxYkyml4HWfQSix+JohtFRh/Im48ygFUg== X-Received: by 2002:a17:902:eb49:: with SMTP id i9mr8953254pli.91.1584720388077; Fri, 20 Mar 2020 09:06:28 -0700 (PDT) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id nu13sm5272745pjb.22.2020.03.20.09.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 09:06:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/3] target/arm: Move computation of index in handle_simd_dupe Date: Fri, 20 Mar 2020 09:06:22 -0700 Message-Id: <20200320160622.8040-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200320160622.8040-1-richard.henderson@linaro.org> References: <20200320160622.8040-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::1044 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Coverity reports a BAD_SHIFT with ctz32(imm5), with imm5 == 0. This is an invalid encoding, but we diagnose that just below by rejecting size > 3. Avoid the warning by sinking the computation of index below the check. Reported-by: Coverity (CID 1421965) Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 032478614c..7580e46367 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -7422,7 +7422,7 @@ static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int index = imm5 >> (size + 1); + int index; if (size > 3 || (size == 3 && !is_q)) { unallocated_encoding(s); @@ -7433,6 +7433,7 @@ static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, return; } + index = imm5 >> (size + 1); tcg_gen_gvec_dup_mem(size, vec_full_reg_offset(s, rd), vec_reg_offset(s, rn, index, size), is_q ? 16 : 8, vec_full_reg_size(s)); -- 2.20.1