From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: kwolf@redhat.com, fam@euphon.net,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [RFC (fix for 5.0?)] block/io: do not do pointer arithmetic on void *
Date: Fri, 20 Mar 2020 16:08:14 +0000 [thread overview]
Message-ID: <20200320160814.GF138042@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200318142654.GH2173309@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Wed, Mar 18, 2020 at 02:26:54PM +0000, Daniel P. Berrangé wrote:
> On Wed, Mar 18, 2020 at 05:22:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >
> > Hi all!
> >
> > C standard doesn't allow pointer arithmetic on void *.
> > Still, gcc allows it as an extension:
> > https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer-Arith.html
> >
> > I can create a series of patches like this. Do we need it?
>
> I don't think so, we only care about gcc & clang.
I agree with Dan.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-20 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 14:22 [RFC (fix for 5.0?)] block/io: do not do pointer arithmetic on void * Vladimir Sementsov-Ogievskiy
2020-03-18 14:26 ` Daniel P. Berrangé
2020-03-18 14:39 ` Eric Blake
2020-03-20 16:08 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320160814.GF138042@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).