qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-block@nongnu.org, qemu-trivial@nongnu.org,
	"Markus Armbruster" <armbru@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Alistair Francis" <alistair@alistair23.me>,
	qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
	"John Snow" <jsnow@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Max Reitz" <mreitz@redhat.com>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH-for-5.0 06/11] hw/isa/i82378: Remove dead assignment
Date: Sat, 21 Mar 2020 12:46:10 +0100	[thread overview]
Message-ID: <20200321114615.5360-7-philmd@redhat.com> (raw)
In-Reply-To: <20200321114615.5360-1-philmd@redhat.com>

Rename the unique variable assigned as 'pit' which better
represents what it holds, to fix a warning reported by the
Clang static code analyzer:

    CC      hw/isa/i82378.o
  hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read
      isa = isa_create_simple(isabus, "i82374");
      ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/isa/i82378.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index dcb6b479ea..d9e6c7fa00 100644
--- a/hw/isa/i82378.c
+++ b/hw/isa/i82378.c
@@ -67,7 +67,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp)
     I82378State *s = I82378(dev);
     uint8_t *pci_conf;
     ISABus *isabus;
-    ISADevice *isa;
+    ISADevice *pit;
 
     pci_conf = pci->config;
     pci_set_word(pci_conf + PCI_COMMAND,
@@ -99,13 +99,13 @@ static void i82378_realize(PCIDevice *pci, Error **errp)
     isa_bus_irqs(isabus, s->i8259);
 
     /* 1 82C54 (pit) */
-    isa = i8254_pit_init(isabus, 0x40, 0, NULL);
+    pit = i8254_pit_init(isabus, 0x40, 0, NULL);
 
     /* speaker */
-    pcspk_init(isabus, isa);
+    pcspk_init(isabus, pit);
 
     /* 2 82C37 (dma) */
-    isa = isa_create_simple(isabus, "i82374");
+    isa_create_simple(isabus, "i82374");
 }
 
 static void i82378_init(Object *obj)
-- 
2.21.1



  parent reply	other threads:[~2020-03-21 11:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21 11:46 [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 01/11] block: Remove dead assignment Philippe Mathieu-Daudé
2020-03-21 11:56   ` Aleksandar Markovic
2020-03-21 15:11     ` BALATON Zoltan
2020-03-21 11:58   ` Laurent Vivier
2020-03-21 13:08     ` Markus Armbruster
2020-03-21 11:46 ` [PATCH-for-5.0 02/11] blockdev: " Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 03/11] hw/i2c/pm_smbus: " Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 04/11] hw/input/adb-kbd: " Philippe Mathieu-Daudé
2020-03-21 12:58   ` BALATON Zoltan
2020-03-21 11:46 ` [PATCH-for-5.0 05/11] hw/ide/sii3112: " Philippe Mathieu-Daudé
2020-03-21 13:04   ` BALATON Zoltan
2020-03-21 13:39   ` Aleksandar Markovic
2020-03-21 14:12     ` BALATON Zoltan
2020-03-21 14:16       ` Philippe Mathieu-Daudé
2020-03-21 14:20         ` BALATON Zoltan
2020-03-21 14:14     ` Philippe Mathieu-Daudé
2020-03-21 14:26       ` Philippe Mathieu-Daudé
2020-03-21 11:46 ` Philippe Mathieu-Daudé [this message]
2020-03-21 11:46 ` [PATCH-for-5.0 07/11] hw/gpio/aspeed_gpio: " Philippe Mathieu-Daudé
2020-03-21 13:22   ` BALATON Zoltan
2020-03-21 14:12     ` Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 08/11] hw/timer/exynos4210_mct: Remove dead assignments Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Philippe Mathieu-Daudé
2020-03-21 11:46 ` [PATCH-for-5.0 11/11] hw/scsi/esp-pci: Remove dead assignment Philippe Mathieu-Daudé
2020-03-21 12:01 ` [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes Aleksandar Markovic
2020-03-21 12:20   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200321114615.5360-7-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=andrew@aj.id.au \
    --cc=armbru@redhat.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=fam@euphon.net \
    --cc=hpoussin@reactos.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=joel@jms.id.au \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mjt@tls.msk.ru \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).