From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
"Markus Armbruster" <armbru@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Joel Stanley" <joel@jms.id.au>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Alistair Francis" <alistair@alistair23.me>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"John Snow" <jsnow@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Kevin Wolf" <kwolf@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Reitz" <mreitz@redhat.com>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH-for-5.0 v2 11/11] hw/scsi/esp-pci: Remove dead assignment
Date: Sat, 21 Mar 2020 15:41:10 +0100 [thread overview]
Message-ID: <20200321144110.5010-12-philmd@redhat.com> (raw)
In-Reply-To: <20200321144110.5010-1-philmd@redhat.com>
Fix warning reported by Clang static code analyzer:
CC hw/scsi/esp-pci.o
hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
size = 4;
^ ~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/scsi/esp-pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
index d5a1f9e017..2e6cc07d4e 100644
--- a/hw/scsi/esp-pci.c
+++ b/hw/scsi/esp-pci.c
@@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
val <<= shift;
val |= current & ~(mask << shift);
addr &= ~3;
- size = 4;
}
if (addr < 0x40) {
--
2.21.1
next prev parent reply other threads:[~2020-03-21 14:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 14:40 [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-03-21 14:41 ` [PATCH-for-5.0 v2 01/11] block: Avoid dead assignment Philippe Mathieu-Daudé
2020-03-23 15:48 ` Alistair Francis
2020-03-21 14:41 ` [PATCH-for-5.0 v2 02/11] blockdev: Remove " Philippe Mathieu-Daudé
2020-03-21 14:41 ` [PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: " Philippe Mathieu-Daudé
2020-03-23 15:50 ` Alistair Francis
2020-03-21 14:41 ` [PATCH-for-5.0 v2 04/11] hw/input/adb-kbd: " Philippe Mathieu-Daudé
2020-03-22 5:34 ` David Gibson
2020-03-21 14:41 ` [PATCH-for-5.0 v2 05/11] hw/ide/sii3112: " Philippe Mathieu-Daudé
2020-03-23 18:46 ` John Snow
2020-03-21 14:41 ` [PATCH-for-5.0 v2 06/11] hw/isa/i82378: " Philippe Mathieu-Daudé
2020-03-23 15:51 ` Alistair Francis
2020-03-21 14:41 ` [PATCH-for-5.0 v2 07/11] hw/gpio/aspeed_gpio: " Philippe Mathieu-Daudé
2020-03-22 8:02 ` Cédric Le Goater
2020-03-21 14:41 ` [PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments Philippe Mathieu-Daudé
2020-03-23 15:52 ` Alistair Francis
2020-03-21 14:41 ` [PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment Philippe Mathieu-Daudé
2020-03-23 15:53 ` Alistair Francis
2020-03-21 14:41 ` [PATCH-for-5.0 v2 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Philippe Mathieu-Daudé
2020-03-23 15:55 ` Alistair Francis
2020-03-21 14:41 ` Philippe Mathieu-Daudé [this message]
2020-03-23 14:33 ` [PATCH-for-5.0 v2 11/11] hw/scsi/esp-pci: Remove dead assignment Laurent Vivier
2020-03-21 14:43 ` [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes Philippe Mathieu-Daudé
2020-03-23 14:32 ` Laurent Vivier
2020-03-23 14:45 ` Philippe Mathieu-Daudé
2020-03-23 14:55 ` Laurent Vivier
2020-03-23 15:01 ` Philippe Mathieu-Daudé
2020-03-24 7:33 ` Chenqun (kuhn)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321144110.5010-12-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alistair@alistair23.me \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=fam@euphon.net \
--cc=hpoussin@reactos.org \
--cc=i.mitsyanko@gmail.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).