From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84700C10DCE for ; Tue, 24 Mar 2020 23:22:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4494B20663 for ; Tue, 24 Mar 2020 23:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YtGQMA3o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4494B20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGssW-0008A1-DO for qemu-devel@archiver.kernel.org; Tue, 24 Mar 2020 19:22:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51408) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGsrj-0006ns-Ke for qemu-devel@nongnu.org; Tue, 24 Mar 2020 19:21:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGsri-0001q5-CQ for qemu-devel@nongnu.org; Tue, 24 Mar 2020 19:21:47 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:40979) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGsri-0001ps-8L for qemu-devel@nongnu.org; Tue, 24 Mar 2020 19:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585092105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eb3RtJ9iryAInIr2hZ8/53UmmK7j2GmRw1hD46Cw0bU=; b=YtGQMA3oDRFSVVKHJMwbhG0JzOsHfq5Q+D6lcpqOnTGs5AVfxtYqQGfytQ39Pg30g3/mzx np/bLwPljTMHuJcOLUuBdWJpIbTabra+i1hbwvkTpOpq5ilIUyl1XaJp9yN2Z2JtstbGEE chwiy4EpBi3rLMS1jbebj2SEcJyQP7w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-6pUGjNIWMo-xXgKF5DP9mg-1; Tue, 24 Mar 2020 19:21:44 -0400 X-MC-Unique: 6pUGjNIWMo-xXgKF5DP9mg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD935802C89; Tue, 24 Mar 2020 23:21:40 +0000 (UTC) Received: from probe.redhat.com (ovpn-112-191.rdu2.redhat.com [10.10.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CC3D5D9C5; Tue, 24 Mar 2020 23:21:34 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v9 04/14] iotests: replace mutable list default args Date: Tue, 24 Mar 2020 19:20:53 -0400 Message-Id: <20200324232103.4195-5-jsnow@redhat.com> In-Reply-To: <20200324232103.4195-1-jsnow@redhat.com> References: <20200324232103.4195-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , ehabkost@redhat.com, qemu-block@nongnu.org, philmd@redhat.com, armbru@redhat.com, Max Reitz , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" It's bad hygiene: if we modify this list, it will be modified across all invocations. (Remaining bad usages are fixed in a subsequent patch which changes the function signature anyway.) Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Max Reitz --- tests/qemu-iotests/iotests.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 0eccca88e0..20da488ad6 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -139,7 +139,7 @@ def qemu_img_log(*args): log(result, filters=3D[filter_testfiles]) return result =20 -def img_info_log(filename, filter_path=3DNone, imgopts=3DFalse, extra_args= =3D[]): +def img_info_log(filename, filter_path=3DNone, imgopts=3DFalse, extra_args= =3D()): args =3D ['info'] if imgopts: args.append('--image-opts') @@ -353,7 +353,7 @@ def _filter(_key, value): return value return filter_qmp(qmsg, _filter) =20 -def log(msg, filters=3D[], indent=3DNone): +def log(msg, filters=3D(), indent=3DNone): '''Logs either a string message or a JSON serializable message (like Q= MP). If indent is provided, JSON serializable messages are pretty-printed.'= '' for flt in filters: @@ -569,7 +569,7 @@ def get_qmp_events_filtered(self, wait=3D60.0): result.append(filter_qmp_event(ev)) return result =20 - def qmp_log(self, cmd, filters=3D[], indent=3DNone, **kwargs): + def qmp_log(self, cmd, filters=3D(), indent=3DNone, **kwargs): full_cmd =3D OrderedDict(( ("execute", cmd), ("arguments", ordered_qmp(kwargs)) @@ -973,7 +973,7 @@ def case_notrun(reason): open('%s/%s.casenotrun' % (output_dir, seq), 'a').write( ' [case not run] ' + reason + '\n') =20 -def verify_image_format(supported_fmts=3D[], unsupported_fmts=3D[]): +def verify_image_format(supported_fmts=3D(), unsupported_fmts=3D()): assert not (supported_fmts and unsupported_fmts) =20 if 'generic' in supported_fmts and \ @@ -987,7 +987,7 @@ def verify_image_format(supported_fmts=3D[], unsupporte= d_fmts=3D[]): if not_sup or (imgfmt in unsupported_fmts): notrun('not suitable for this image format: %s' % imgfmt) =20 -def verify_protocol(supported=3D[], unsupported=3D[]): +def verify_protocol(supported=3D(), unsupported=3D()): assert not (supported and unsupported) =20 if 'generic' in supported: @@ -1006,11 +1006,11 @@ def verify_platform(supported=3DNone, unsupported= =3DNone): if not any((sys.platform.startswith(x) for x in supported)): notrun('not suitable for this OS: %s' % sys.platform) =20 -def verify_cache_mode(supported_cache_modes=3D[]): +def verify_cache_mode(supported_cache_modes=3D()): if supported_cache_modes and (cachemode not in supported_cache_modes): notrun('not suitable for this cache mode: %s' % cachemode) =20 -def verify_aio_mode(supported_aio_modes=3D[]): +def verify_aio_mode(supported_aio_modes=3D()): if supported_aio_modes and (aiomode not in supported_aio_modes): notrun('not suitable for this aio mode: %s' % aiomode) =20 @@ -1050,7 +1050,7 @@ def supported_formats(read_only=3DFalse): =20 return supported_formats.formats[read_only] =20 -def skip_if_unsupported(required_formats=3D[], read_only=3DFalse): +def skip_if_unsupported(required_formats=3D(), read_only=3DFalse): '''Skip Test Decorator Runs the test if all the required formats are whitelisted''' def skip_test_decorator(func): @@ -1101,11 +1101,11 @@ def execute_unittest(output, verbosity, debug): sys.stderr.write(out) =20 def execute_test(test_function=3DNone, - supported_fmts=3D[], + supported_fmts=3D(), supported_platforms=3DNone, - supported_cache_modes=3D[], supported_aio_modes=3D{}, - unsupported_fmts=3D[], supported_protocols=3D[], - unsupported_protocols=3D[]): + supported_cache_modes=3D(), supported_aio_modes=3D(), + unsupported_fmts=3D(), supported_protocols=3D(), + unsupported_protocols=3D()): """Run either unittest or script-style tests.""" =20 # We are using TEST_DIR and QEMU_DEFAULT_MACHINE as proxies to --=20 2.21.1