From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: anthony.perard@citrix.com, pbonzini@redhat.com, mst@redhat.com,
ehabkost@redhat.com, rth@twiddle.net
Subject: [PATCH for-5.0] xen: fixup RAM memory region initialization
Date: Fri, 27 Mar 2020 06:48:28 -0400 [thread overview]
Message-ID: <20200327104828.12647-1-imammedo@redhat.com> (raw)
Since bd457782b3b0 ("x86/pc: use memdev for RAM") Xen
machine fails to start with:
qemu-system-i386: xen: failed to populate ram at 0
The reason is that xen_ram_alloc() which is called by
memory_region_init_ram(), compares memory region with
statically allocated 'global' ram_memory memory region
that it uses for RAM, and does nothing in case it matches.
While it's possible feed machine->ram to xen_ram_alloc()
in the same manner to keep that hack working, I'd prefer
not to keep that circular dependency and try to untangle that.
However it doesn't look trivial to fix, so as temporary
fixup opt out Xen machine from memdev based RAM allocation,
and let xen_ram_alloc() do its trick for now.
Reported-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
PS:
- compile tested only
hw/i386/pc_piix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index e6756216f9..6cb352363d 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -953,6 +953,10 @@ static void xenfv_machine_options(MachineClass *m)
m->desc = "Xen Fully-virtualized PC";
m->max_cpus = HVM_MAX_VCPUS;
m->default_machine_opts = "accel=xen";
+ /*
+ * opt out of system RAM being allocated by generic code
+ */
+ m->default_ram_id = NULL;
}
DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init,
--
2.18.1
next reply other threads:[~2020-03-27 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:48 Igor Mammedov [this message]
2020-03-27 10:55 ` [PATCH for-5.0] xen: fixup RAM memory region initialization no-reply
2020-03-27 16:36 ` Igor Mammedov
2020-03-27 16:42 ` Paolo Bonzini
2020-03-30 16:52 ` Anthony PERARD
2020-04-02 12:29 ` Igor Mammedov
2020-04-02 13:25 ` Anthony PERARD
2020-04-02 14:30 ` Igor Mammedov
2020-04-07 11:36 ` Anthony PERARD
2020-04-08 8:45 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327104828.12647-1-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).