From: Li Qiang <liq3ea@163.com>
To: thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com,
jasowang@redhat.com
Cc: Li Qiang <liq3ea@163.com>, liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: [PATCH] qtest: add tulip test case
Date: Fri, 27 Mar 2020 09:11:46 -0700 [thread overview]
Message-ID: <20200327161146.16402-1-liq3ea@163.com> (raw)
The tulip networking card emulation has an OOB issue in
'tulip_copy_tx_buffers' when the guest provide malformed descriptor.
This test will trigger a ASAN heap overflow crash.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
tests/qtest/Makefile.include | 1 +
tests/qtest/tulip-test.c | 91 ++++++++++++++++++++++++++++++++++++
2 files changed, 92 insertions(+)
create mode 100644 tests/qtest/tulip-test.c
diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include
index 10a28de8a3..9e5a51d033 100644
--- a/tests/qtest/Makefile.include
+++ b/tests/qtest/Makefile.include
@@ -217,6 +217,7 @@ qos-test-obj-y += tests/qtest/es1370-test.o
qos-test-obj-y += tests/qtest/ipoctal232-test.o
qos-test-obj-y += tests/qtest/megasas-test.o
qos-test-obj-y += tests/qtest/ne2000-test.o
+qos-test-obj-y += tests/qtest/tulip-test.o
qos-test-obj-y += tests/qtest/nvme-test.o
qos-test-obj-y += tests/qtest/pca9552-test.o
qos-test-obj-y += tests/qtest/pci-test.o
diff --git a/tests/qtest/tulip-test.c b/tests/qtest/tulip-test.c
new file mode 100644
index 0000000000..d91ddfd765
--- /dev/null
+++ b/tests/qtest/tulip-test.c
@@ -0,0 +1,91 @@
+/*
+ * QTest testcase for DEC/Intel Tulip 21143
+ *
+ * Copyright (c) 2020 Li Qiang <liq3ea@gmail.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#include "qemu/osdep.h"
+#include "libqtest.h"
+#include "qemu/module.h"
+#include "libqos/qgraph.h"
+#include "libqos/pci.h"
+#include "qemu/bitops.h"
+#include "hw/net/tulip.h"
+
+typedef struct QTulip_pci QTulip_pci;
+
+struct QTulip_pci {
+ QOSGraphObject obj;
+ QPCIDevice dev;
+};
+
+static void *tulip_pci_get_driver(void *obj, const char *interface)
+{
+ QTulip_pci *tulip_pci = obj;
+
+ if (!g_strcmp0(interface, "pci-device")) {
+ return &tulip_pci->dev;
+ }
+
+ fprintf(stderr, "%s not present in tulip_pci\n", interface);
+ g_assert_not_reached();
+}
+
+static void *tulip_pci_create(void *pci_bus, QGuestAllocator *alloc, void *addr)
+{
+ QTulip_pci *tulip_pci = g_new0(QTulip_pci, 1);
+ QPCIBus *bus = pci_bus;
+
+ qpci_device_init(&tulip_pci->dev, bus, addr);
+ tulip_pci->obj.get_driver = tulip_pci_get_driver;
+
+ return &tulip_pci->obj;
+}
+
+static void tulip_large_tx(void *obj, void *data, QGuestAllocator *alloc)
+{
+ QTulip_pci *tulip_pci = obj;
+ QPCIDevice *dev = &tulip_pci->dev;
+ QPCIBar bar;
+ struct tulip_descriptor context;
+ char guest_data[4096];
+ uint64_t context_pa;
+ uint64_t guest_pa;
+
+ qpci_device_enable(dev);
+ bar = qpci_iomap(dev, 0, NULL);
+ context_pa = guest_alloc(alloc, sizeof(context));
+ guest_pa = guest_alloc(alloc, 4096);
+ memset(guest_data, 'A', sizeof(guest_data));
+ context.status = TDES0_OWN;
+ context.control = TDES1_BUF2_SIZE_MASK << TDES1_BUF2_SIZE_SHIFT |
+ TDES1_BUF1_SIZE_MASK << TDES1_BUF1_SIZE_SHIFT;
+ context.buf_addr2 = context_pa + sizeof(struct tulip_descriptor);
+ context.buf_addr1 = guest_pa;
+
+ qtest_memwrite(dev->bus->qts, context_pa, &context, sizeof(context));
+ qtest_memwrite(dev->bus->qts, guest_pa, guest_data, sizeof(guest_data));
+ qpci_io_writel(dev, bar, 0x20, context_pa);
+ qpci_io_writel(dev, bar, 0x30, 1 << 13);
+ guest_free(alloc, context_pa);
+ guest_free(alloc, guest_pa);
+}
+
+static void tulip_register_nodes(void)
+{
+ QOSGraphEdgeOptions opts = {
+ .extra_device_opts = "addr=04.0",
+ };
+ add_qpci_address(&opts, &(QPCIAddress) { .devfn = QPCI_DEVFN(4, 0) });
+
+ qos_node_create_driver("tulip", tulip_pci_create);
+ qos_node_consumes("tulip", "pci-bus", &opts);
+ qos_node_produces("tulip", "pci-device");
+
+ qos_add_test("tulip_large_tx", "tulip", tulip_large_tx, NULL);
+}
+
+libqos_init(tulip_register_nodes);
--
2.17.1
next reply other threads:[~2020-03-27 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 16:11 Li Qiang [this message]
2020-03-27 19:24 ` [PATCH] qtest: add tulip test case no-reply
2020-03-28 5:00 ` Li Qiang
2020-03-30 7:24 ` Jason Wang
2020-03-30 8:33 ` Li Qiang
2020-03-30 14:56 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327161146.16402-1-liq3ea@163.com \
--to=liq3ea@163.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@gmail.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).