From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: dim@FreeBSD.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>,
alex.bennee@linaro.org, roger.pau@citrix.com
Subject: [PATCH for-5.0 v3 3/7] configure: Do not force pie=no for non-x86
Date: Fri, 27 Mar 2020 15:03:49 -0700 [thread overview]
Message-ID: <20200327220353.27233-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200327220353.27233-1-richard.henderson@linaro.org>
PIE is supported on many other hosts besides x86.
The default for non-x86 is now the same as x86: pie is used
if supported, and may be forced via --enable/--disable-pie.
The original commit (40d6444e91c) said:
"Non-x86 are not changed, as they require TCG changes"
but I think that's wrong -- there's nothing about PIE that
affects TCG one way or another.
Tested on aarch64 (bionic) and ppc64le (centos 7) hosts.
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
configure | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/configure b/configure
index 2afcae61df..cbde833f6e 100755
--- a/configure
+++ b/configure
@@ -2107,16 +2107,6 @@ if ! compile_prog "-Werror" "" ; then
"Thread-Local Storage (TLS). Please upgrade to a version that does."
fi
-if test "$pie" = ""; then
- case "$cpu-$targetos" in
- i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
- ;;
- *)
- pie="no"
- ;;
- esac
-fi
-
if test "$pie" != "no" ; then
cat > $TMPC << EOF
--
2.20.1
next prev parent reply other threads:[~2020-03-27 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 22:03 [PATCH for-5.0 v3 0/7] configure: Improve PIE and other linkage Richard Henderson
2020-03-27 22:03 ` [PATCH for-5.0 v3 1/7] configure: Drop adjustment of textseg Richard Henderson
2020-03-27 22:03 ` [PATCH for-5.0 v3 2/7] tcg: Remove softmmu code_gen_buffer fixed address Richard Henderson
2020-03-27 22:03 ` Richard Henderson [this message]
2020-03-27 22:03 ` [PATCH for-5.0 v3 4/7] configure: Always detect -no-pie toolchain support Richard Henderson
2020-03-30 9:24 ` Alex Bennée
2020-03-27 22:03 ` [PATCH for-5.0 v3 5/7] configure: Unnest detection of -z, relro and -z, now Richard Henderson
2020-03-27 22:03 ` [PATCH for-5.0 v3 6/7] configure: Override the os default with --disable-pie Richard Henderson
2020-03-27 22:03 ` [PATCH for-5.0 v3 7/7] configure: Support -static-pie if requested Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327220353.27233-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=dim@FreeBSD.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roger.pau@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).