From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB380C43331 for ; Wed, 1 Apr 2020 08:16:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A41852078B for ; Wed, 1 Apr 2020 08:16:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A41852078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJYXv-0003aR-Qo for qemu-devel@archiver.kernel.org; Wed, 01 Apr 2020 04:16:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35282) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJYWs-0001rk-GV for qemu-devel@nongnu.org; Wed, 01 Apr 2020 04:15:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJYWr-00072G-CY for qemu-devel@nongnu.org; Wed, 01 Apr 2020 04:15:18 -0400 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:56477) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJYWo-0006f1-PK; Wed, 01 Apr 2020 04:15:14 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DB86A458E5; Wed, 1 Apr 2020 10:15:10 +0200 (CEST) From: Stefan Reiter To: qemu-devel@nongnu.org, qemu-block@nongnu.org Subject: [PATCH v4 0/3] Fix some AIO context locking in jobs Date: Wed, 1 Apr 2020 10:15:01 +0200 Message-Id: <20200401081504.200017-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, slp@redhat.com, mreitz@redhat.com, stefanha@redhat.com, jsnow@redhat.com, dietmar@proxmox.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Contains three seperate but related patches cleaning up and fixing some issues regarding aio_context_acquire/aio_context_release for jobs. Mostly affects blockjobs running for devices that have IO threads enabled AFAICT= . This is based on the discussions here: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07929.html Changes from v3: * commit_job appears to be unset in certain cases when replication_close = is called, only access when necessary to avoid SIGSEGV Missed this when shuffling around patches, sorry for noise with still-bro= ken v3. Changes from v2: * reordered patch 1 to the end to not introduce temporary breakages * added more fixes to job txn patch (should now pass the tests) Changes from v1: * fixed commit message for patch 1 * added patches 2 and 3 qemu: Stefan Reiter (3): job: take each job's lock individually in job_txn_apply replication: acquire aio context before calling job_cancel_sync backup: don't acquire aio_context in backup_clean block/backup.c | 4 ---- block/replication.c | 8 +++++++- job.c | 48 ++++++++++++++++++++++++++++++++++--------- tests/test-blockjob.c | 2 ++ 4 files changed, 47 insertions(+), 15 deletions(-) --=20 2.26.0